From libssh2-devel-bounces@cool.haxx.se Wed Mar 4 09:38:29 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t248c3h5012327; Wed, 4 Mar 2015 09:38:26 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t248c1ga011158 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 4 Mar 2015 09:38:01 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t248c0QH011106 for ; Wed, 4 Mar 2015 09:38:00 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Wed, 4 Mar 2015 09:38:00 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: Re: Ok, let's talk release again. For real. In-Reply-To: Message-ID: References: User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t248c3h5012327 On Sat, 21 Feb 2015, Daniel Stenberg wrote: > Do anyone have any stuff that should go in before a release? And then I mean > something you yourself plan to fix within a week or so. I intend to release libssh2 1.5.0 in exactly 7 days, on March 11th. -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Mar 4 10:15:33 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t249FRk7018994; Wed, 4 Mar 2015 10:15:32 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t249FQfI018374 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 4 Mar 2015 10:15:26 +0100 Received: (qmail 23239 invoked from network); 4 Mar 2015 09:18:28 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 4 Mar 2015 09:18:28 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software To: ios3@moontechnolabs.com X-Trac-Project: libssh2 Date: Wed, 04 Mar 2015 09:18:28 -0000 X-URL: https://trac.libssh2.org/ Subject: [libssh2] #295: latest libssh2 library with support 64 bit architecture fails to authenticate with public key (RSA) libssh2_userauth_publickey_fromfile X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/295 Message-ID: <041.461ecd84fb49ba812d54e2379f5b653a@libssh2.stuge.se> X-Trac-Ticket-ID: 295 X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t249FQfI018374 Cc: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: trac@libssh2.stuge.se, libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t249FRk7018994 #295: latest libssh2 library with support 64 bit architecture fails to authenticate with public key (RSA) libssh2_userauth_publickey_fromfile --------------------+-------------------- Reporter: ios3 | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.4.3 Component: API | Version: 1.4.2 Keywords: | Blocked By: Blocks: | --------------------+-------------------- It's working fine with older version of library to ssh with public key. But for same key If i tried to ssh it fails to authenticate and returns -18(LIBSSH2_ERROR_AUTHENTICATION_FAILED) in function "libssh2_userauth_publickey_fromfile(session, username, publickey, privatekey, passphrase)". What's wrong with new version of library? I am using it in iOS application. I am using version 1.4.3 -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Mar 4 10:25:21 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t249PJjL000376; Wed, 4 Mar 2015 10:25:21 +0100 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t249PHEx032554 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 4 Mar 2015 10:25:17 +0100 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 663C5208A4; Wed, 4 Mar 2015 04:25:15 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute2.internal (MEProxy); Wed, 04 Mar 2015 04:25:16 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:from:content-type :content-transfer-encoding:subject:message-id:date:to :mime-version; s=smtpout; bh=EdWjowyIxuwUTuYBVKWuGXvnLcY=; b=flm srm3XNP0pKYUIg+3HBqxH85aIc6XCKKUU4WOrneqP6w/tICxHxvMwPENn/JDP8T5 JVejCNNAPztdezulot8dPKf8PPtvtY2IfO1b7bwZqSNquk5Z/02x3FA2IQqZYNQS HTgXg5KMF9r4xxJiSdAt1uMRysJHjf/xckvVmU+s= X-Sasl-enc: uktPifMfkrMXs6VnKJbs7vp1aWLuqQ1U+LrNW3wYdwSX 1425461116 Received: from [192.168.4.37] (unknown [90.146.2.242]) by mail.messagingengine.com (Postfix) with ESMTPA id 1DDECC00297 for ; Wed, 4 Mar 2015 04:25:15 -0500 (EST) From: Jakob Egger Subject: Download libssh2 source via HTTPS? Message-Id: <40899080-0DEF-42EA-B861-ED3C9CD362BF@eggerapps.at> Date: Wed, 4 Mar 2015 10:25:14 +0100 To: libssh2 development Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) X-Mailer: Apple Mail (2.2070.6) X-MIME-Autoconverted: from quoted-printable to 8bit by giant.haxx.se id t249PHEx032554 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t249PJjL000376 Hi, is there currently a secure way to download the libssh2 source? I feel a bit uneasy about downloading from an unauthenticated server. GPG signatures don't really help when they are also hosted on an unsecure server. If missing HTTPS support is related to cost, I can offer to pay for an SSL certificate. Best regards, Jakob _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Mar 4 11:22:08 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t24ALtC7000598; Wed, 4 Mar 2015 11:22:06 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t24ALrd6000537 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 4 Mar 2015 11:21:53 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t24ALr4g000534 for ; Wed, 4 Mar 2015 11:21:53 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Wed, 4 Mar 2015 11:21:53 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: Re: Download libssh2 source via HTTPS? In-Reply-To: <40899080-0DEF-42EA-B861-ED3C9CD362BF@eggerapps.at> Message-ID: References: <40899080-0DEF-42EA-B861-ED3C9CD362BF@eggerapps.at> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t24ALtC7000598 On Wed, 4 Mar 2015, Jakob Egger wrote: > is there currently a secure way to download the libssh2 source? No, unfortunately not. But I would agree that it would be desireble for us to move in that direction. Personally, I wouldn't mind switching over to hosting the source code repo at github (which then could provide the code over HTTPS "for free") and then on a longer term switch to that bug tracker and allow pull requests there etc. All in the name of going where there's already a large amount of users, it brings features and it encourages and simplifies collaboration even further. Do it "like the kids do". And it makes the infrastructure less dependent on individual volunteers. > If missing HTTPS support is related to cost, I can offer to pay for an SSL > certificate. It is related to cost, but not strictly the price for the certificate but even more so the effort and maintenence cost in time and energy. Hence I would prefer to use an existing (and proven) infrastructure for it. My slightly longer term plan is to jump on the letsencrypt.com bandwagon once that goes live and offer HTTPS for libssh2.org (and all other sites I host) from then on. -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Mar 4 13:29:21 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t24CSoJk004400; Wed, 4 Mar 2015 13:29:18 +0100 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t24CSlGJ004351 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 4 Mar 2015 13:28:49 +0100 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 6A8AD20768; Wed, 4 Mar 2015 07:28:46 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Wed, 04 Mar 2015 07:28:47 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:from:content-type:message-id :mime-version:subject:date:references:to:in-reply-to; s=smtpout; bh=lnsnEM/Xo/WZxrYZkZP4lJ5sz/g=; b=E3wUuhEfzYSpfI0CbshpR+zvViES H8eLvKZEyO5EWvmwVYWsoHwcrb8Zam5/F09f9h7eq+zVouICbQq3Wn6Oq2ksr9PC MwDfMX73c2nNVrYo3UwrV6wJg+u+yK/2XYNRvOyrytTCoYq+5g52jxXJczMgTblB fXc0nP8vO+c2LVQ= X-Sasl-enc: TSLA5zZLZxqMt8MPNY5Rt6lWsNVTYXrXjph9LsrdqUkq 1425472127 Received: from [192.168.0.6] (unknown [86.56.148.245]) by mail.messagingengine.com (Postfix) with ESMTPA id 09B816800C0 for ; Wed, 4 Mar 2015 07:28:46 -0500 (EST) From: Jakob Egger Message-Id: <225C8C3D-EC6D-4458-9FB8-4DFCEC1DF136@eggerapps.at> Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: Download libssh2 source via HTTPS? Date: Wed, 4 Mar 2015 13:28:44 +0100 References: <40899080-0DEF-42EA-B861-ED3C9CD362BF@eggerapps.at> To: libssh2 development In-Reply-To: X-Mailer: Apple Mail (2.2070.6) X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============0692307532==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============0692307532== Content-Type: multipart/alternative; boundary="Apple-Mail=_47071E80-59D1-4BC4-B156-091FF094ABF3" --Apple-Mail=_47071E80-59D1-4BC4-B156-091FF094ABF3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > Am 04.03.2015 um 11:21 schrieb Daniel Stenberg : > Personally, I wouldn't mind switching over to hosting the source code = repo at github (which then could provide the code over HTTPS "for free") = and then on a longer term switch to that bug tracker and allow pull = requests there etc. All in the name of going where there's already a = large amount of users, it brings features and it encourages and = simplifies collaboration even further. Do it "like the kids do". And it = makes the infrastructure less dependent on individual volunteers. Yes, Github would be awesome. Is there an argument against moving to = Github? >> If missing HTTPS support is related to cost, I can offer to pay for = an SSL certificate. >=20 > It is related to cost, but not strictly the price for the certificate = but even more so the effort and maintenence cost in time and energy. = Hence I would prefer to use an existing (and proven) infrastructure for = it. >=20 > My slightly longer term plan is to jump on the letsencrypt.com = bandwagon once that goes live and offer HTTPS for libssh2.org (and all = other sites I host) from then on. If you move to Github, you could host the project website on github too. = We do that for http://postgresapp.com =E2=80=94 = everything is hosted on Github, for free (even binaries). Only drawback: = Github pages don't support https. Thus, if you want a secure download, = you have to go to the Github website and download from there. --Apple-Mail=_47071E80-59D1-4BC4-B156-091FF094ABF3 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
Am 04.03.2015 um 11:21 schrieb Daniel Stenberg <daniel@haxx.se>:
Personally, I wouldn't mind = switching over to hosting the source code repo at github (which then = could provide the code over HTTPS "for free") and then on a longer term = switch to that bug tracker and allow pull requests there etc. All in the = name of going where there's already a large amount of users, it brings = features and it encourages and simplifies collaboration even further. Do = it "like the kids do". And it makes the infrastructure less dependent on = individual volunteers.

Yes, Github would be awesome. Is there an argument = against moving to Github?


If missing HTTPS support = is related to cost, I can offer to pay for an SSL certificate.

It is related to cost, but not = strictly the price for the certificate but even more so the effort and = maintenence cost in time and energy. Hence I would prefer to use an = existing (and proven) infrastructure for it.

My slightly longer term plan is to jump on the letsencrypt.com bandwagon = once that goes live and offer HTTPS for libssh2.org (and all other sites I host) from then = on.

If you move to Github, = you could host the project website on github too. We do that for http://postgresapp.com =E2=80=94 everything is = hosted on Github, for free (even binaries). Only drawback: Github pages = don't support https. Thus, if you want a secure download, you have to go = to the Github website and download from there.

= --Apple-Mail=_47071E80-59D1-4BC4-B156-091FF094ABF3-- --===============0692307532== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============0692307532==-- From libssh2-devel-bounces@cool.haxx.se Wed Mar 4 14:01:08 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t24D10RM022509; Wed, 4 Mar 2015 14:01:07 +0100 Received: from mail-lb0-x22d.google.com (mail-lb0-x22d.google.com [IPv6:2a00:1450:4010:c04::22d]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t24D0wvW022433 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 4 Mar 2015 14:00:59 +0100 Received: by lbdu14 with SMTP id u14so22863778lbd.0 for ; Wed, 04 Mar 2015 05:00:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=bFQyoNjEeD3cWoc9rTdg+6SjssPYMAI3NvM8dKmlTno=; b=fx8pDEjTUefI06KXBA09T8CLJMmzvOIWiNGmUJ4ZzMOIkfiLjUOk5ervV4RijXkwIV 2fs3jsEUenTkSS/G5Yk+yLvtc7Ez1adG7vLif6NrTSODPvl3GofcZUKbvPP3PAcJgakx XUydvueA5ShcISSbCKlv8PU4lm5l5IetpwmNLlZrPV17m0DLvDDdtDWIQ2FvYK1cJtBd DOHyN5v5Jm2zDhA9WHr0PIfnVtD6T9/fVhiV7536RB9vnwSMWPXb+Kkayh21lq9t2W1J bs7kWTBKbzoZ4NMlgvPumhYK0iAcjRoujvm48uw4CzP3ES+GKvrDyKBYge104ZZEAevD LJqw== MIME-Version: 1.0 X-Received: by 10.112.63.165 with SMTP id h5mr3315558lbs.16.1425474054119; Wed, 04 Mar 2015 05:00:54 -0800 (PST) Received: by 10.25.38.18 with HTTP; Wed, 4 Mar 2015 05:00:54 -0800 (PST) In-Reply-To: <225C8C3D-EC6D-4458-9FB8-4DFCEC1DF136@eggerapps.at> References: <40899080-0DEF-42EA-B861-ED3C9CD362BF@eggerapps.at> <225C8C3D-EC6D-4458-9FB8-4DFCEC1DF136@eggerapps.at> Date: Wed, 4 Mar 2015 13:00:54 +0000 X-Google-Sender-Auth: NOAymjoNfRQQh0bL2sfo_d_msJQ Message-ID: Subject: Re: Download libssh2 source via HTTPS? From: Alexander Lamaison To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t24D10RM022509 On 4 March 2015 at 12:28, Jakob Egger wrote: > > Am 04.03.2015 um 11:21 schrieb Daniel Stenberg : > > Personally, I wouldn't mind switching over to hosting the source code repo > at github (which then could provide the code over HTTPS "for free") and then > on a longer term switch to that bug tracker and allow pull requests there > etc. All in the name of going where there's already a large amount of users, > it brings features and it encourages and simplifies collaboration even > further. Do it "like the kids do". And it makes the infrastructure less > dependent on individual volunteers. > > > Yes, Github would be awesome. Is there an argument against moving to Github? I've been meaning to suggest this for a long time now. We are short-staffed as it is. Spending time configuring our own servers, managing a Trac instance and moderating spam, is time that could be better spent on development. Another benefit of GitHub is the integration with third-party tooling such as code quality monitors, CI, etc. For example, the CMake branch of libssh2 is hosted on GitHub [1] and every commit is built on Linux [2] and Windows [3] in 40 configurations of architecture/compiler/crypto/zlib. To convert from Trac to GitHub, there a plenty of tools that handle the migration, such as https://github.com/trustmaster/trac2github. [1] https://github.com/alamaison/libssh2 [2] https://travis-ci.org/alamaison/libssh2/builds/45550541 [3] https://ci.appveyor.com/project/alamaison/libssh2/build/20 Alex -- Swish - Easy SFTP for Windows Explorer (http://www.swish-sftp.org) _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Mar 4 14:34:36 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t24DYMDm015491; Wed, 4 Mar 2015 14:34:34 +0100 Received: from foo.stuge.se (qmailr@foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t24DYL49015488 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 4 Mar 2015 14:34:21 +0100 Received: (qmail 2892 invoked by uid 501); 4 Mar 2015 13:34:21 -0000 Message-ID: <20150304133421.2891.qmail@stuge.se> Date: Wed, 4 Mar 2015 14:34:21 +0100 From: Peter Stuge To: libssh2 development Subject: Re: Download libssh2 source via HTTPS? Mail-Followup-To: libssh2 development References: <40899080-0DEF-42EA-B861-ED3C9CD362BF@eggerapps.at> <40899080-0DEF-42EA-B861-ED3C9CD362BF@eggerapps.at> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <40899080-0DEF-42EA-B861-ED3C9CD362BF@eggerapps.at> X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t24DYMDm015491 Jakob Egger wrote: > is there currently a secure way to download the libssh2 source? You can use: https://git.libssh2.org/libssh2.git https://trac.libssh2.org/ ..if you trust CAcert. > GPG signatures don't really help when they are also hosted on an > unsecure server. A GPG signature (like a cert) only tells you anything if you have established a trust relationship with the key. If you don't have any way to trust the key then the signature (and cert) tells you nothing. > If missing HTTPS support is related to cost, I can offer to pay for > an SSL certificate. If you want to go ahead with this I could send you a CSR which includes {trac,git}.libssh2.org, but there would also be other names in there, since the same IP is used for serving multiple things. (All of which are non-commercial.) Daniel Stenberg wrote: > Personally, I wouldn't mind switching over to hosting the source code repo > at github > All in the name of going where there's already a large amount of > users, it brings features and it encourages and simplifies collaboration > even further. Do it "like the kids do". Since when was being mainstream ever a good thing? GitHub Inc. is a privately held company in the USA. I don't see how it could be beneficial in any way for the project to give up its independence. > And it makes the infrastructure less dependent on individual volunteers. If we had been having lots of problems with the infrastructure I agree that this would have been a good argument. But I don't think that we've had so many problems that we need a change. >> If missing HTTPS support is related to cost, I can offer to pay for an SSL >> certificate. > > It is related to cost, but not strictly the price for the certificate but > even more so the effort and maintenence cost in time and energy. Please speak for yourself. The time for me to generate a new key and exchange the cert is negligible. > Hence I would prefer to use an existing (and proven) infrastructure for it. Our system with Trac, gitweb and git-daemon does https since 2012, so both existing and proven. :) > My slightly longer term plan is to jump on the letsencrypt.com bandwagon > once that goes live and offer HTTPS for libssh2.org (and all other sites I > host) from then on. FWIW I think that could be a fine plan. It's an interesting project and I might also jump on, but probably not right away. //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Mar 4 14:49:06 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t24Dn2Fo000780; Wed, 4 Mar 2015 14:49:06 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t24Dn1hY000643 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 4 Mar 2015 14:49:01 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t24Dn0BO000640 for ; Wed, 4 Mar 2015 14:49:00 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Wed, 4 Mar 2015 14:49:00 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: Re: Download libssh2 source via HTTPS? In-Reply-To: <20150304133421.2891.qmail@stuge.se> Message-ID: References: <40899080-0DEF-42EA-B861-ED3C9CD362BF@eggerapps.at> <40899080-0DEF-42EA-B861-ED3C9CD362BF@eggerapps.at> <20150304133421.2891.qmail@stuge.se> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t24Dn2Fo000780 On Wed, 4 Mar 2015, Peter Stuge wrote: >> All in the name of going where there's already a large amount of users, it >> brings features and it encourages and simplifies collaboration even >> further. Do it "like the kids do". > > Since when was being mainstream ever a good thing? Lowering barriers and reducing friction for newcomers are good things in my mind. Apparently I'm not the only one thinking so. > GitHub Inc. is a privately held company in the USA. I don't see how it could > be beneficial in any way for the project to give up its independence. It would not give up independence. It would use one or more services provided by that company. >> It is related to cost, but not strictly the price for the certificate but >> even more so the effort and maintenence cost in time and energy. > > Please speak for yourself. Did I *ever* speak for anyone else here? Of course I speak for myself and as the person admining www.libssh2.org. -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Mar 4 15:00:16 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t24E0C9g015988; Wed, 4 Mar 2015 15:00:15 +0100 Received: from foo.stuge.se (qmailr@foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t24E0BaC015984 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 4 Mar 2015 15:00:12 +0100 Received: (qmail 5317 invoked by uid 501); 4 Mar 2015 14:00:12 -0000 Message-ID: <20150304140012.5316.qmail@stuge.se> Date: Wed, 4 Mar 2015 15:00:12 +0100 From: Peter Stuge To: libssh2-devel@cool.haxx.se Subject: Re: Ok, let's talk release again. For real. Mail-Followup-To: libssh2-devel@cool.haxx.se References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t24E0C9g015988 Daniel Stenberg wrote: >> Do anyone have any stuff that should go in before a release? And then I >> mean something you yourself plan to fix within a week or so. > > I intend to release libssh2 1.5.0 in exactly 7 days, on March 11th. Cool! I'll try to take a look at --with-libssl-prefix before then, but no guarantees. //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Mar 4 15:03:58 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t24E3url019244; Wed, 4 Mar 2015 15:03:57 +0100 Received: from foo.stuge.se (qmailr@foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t24E3sTv019239 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 4 Mar 2015 15:03:55 +0100 Received: (qmail 5591 invoked by uid 501); 4 Mar 2015 14:03:55 -0000 Message-ID: <20150304140355.5590.qmail@stuge.se> Date: Wed, 4 Mar 2015 15:03:55 +0100 From: Peter Stuge To: libssh2-devel@cool.haxx.se Subject: Re: Ok, let's talk release again. For real. Mail-Followup-To: libssh2-devel@cool.haxx.se References: <033901d0508b$1d2b5640$578202c0$@qqmail.nl> <20150225024020.4507.qmail@stuge.se> <007101d053a0$0b65fb50$2231f1f0$@qqmail.nl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <007101d053a0$0b65fb50$2231f1f0$@qqmail.nl> X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t24E3url019244 Bert Huijben wrote: > > Bert Huijben wrote: > > > I currently use a patch in my own build (that version is attached). > > > > Is the new code backwards compatible - ie. works also with older > > versions of pageant? .. > The change itself is not relevant, but let me quote r9264's log message: > [[ > r9264 | simon | 2011-08-13 16:48:36 +0200 (za, 13 aug 2011) | 8 lines > > Readjust Pageant's SID check _again_, to make it the union of the > policies before and after r9178, and hence able to talk to both > 0.60-like and 0.61-like clients. > > I had failed to consider that many pieces of code derived from PuTTY > would have imported the Pageant client code, so we shouldn't randomly > stop supporting things just because _we_ aren't using them anymore. > ]] > > The code in libssh2 clearly falls in this category. Hm, the description above suggests to me that the new code does *not* work correctly with older versions of pageant? I guess I have to take a closer look. //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Mar 4 15:27:22 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t24ERFJs014801; Wed, 4 Mar 2015 15:27:21 +0100 Received: from foo.stuge.se (qmailr@foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t24EREi9014798 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 4 Mar 2015 15:27:14 +0100 Received: (qmail 7564 invoked by uid 501); 4 Mar 2015 14:27:15 -0000 Message-ID: <20150304142715.7563.qmail@stuge.se> Date: Wed, 4 Mar 2015 15:27:15 +0100 From: Peter Stuge To: libssh2-devel@cool.haxx.se Subject: Re: Download libssh2 source via HTTPS? Mail-Followup-To: libssh2-devel@cool.haxx.se References: <40899080-0DEF-42EA-B861-ED3C9CD362BF@eggerapps.at> <40899080-0DEF-42EA-B861-ED3C9CD362BF@eggerapps.at> <20150304133421.2891.qmail@stuge.se> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t24ERFJs014801 Daniel Stenberg wrote: >>> All in the name of going where there's already a large amount of users, >>> it brings features and it encourages and simplifies collaboration even >>> further. Do it "like the kids do". >> >> Since when was being mainstream ever a good thing? > > Lowering barriers and reducing friction for newcomers are good things > in my mind. I don't believe that "outsourcing" reduces friction. Quite the contrary. As long as what one wants is *exactly* what is intended for one to want then everything is fine. If one wants to do anything else, then one is out of luck - because that is not supported. Infinite friction. As for barriers - have you read the github.com ToS recently? https://github.com/site/terms The very first point is: A. Account Terms 1. You must be 13 years or older to use this Service. How about that for a barrier? If I was growing up on the internet today, I might want to contribute to libssh2 also before I'm 13. It is not common - but I think lowering the barrier is really important. 3. You must provide your name, a valid email address, and any other information requested in order to complete the signup process. That sounds like a significant barrier to me. "any other information requested" - and a completely arbitrary barrier at that. 7. One person or legal entity may not maintain more than one free account. That too sounds like a barrier to me. > Apparently I'm not the only one thinking so. Please read those terms again. I think they are absurd. (But I know that they are absolutely required, because the service is operated by a US company.) School teaches us that it is most convenient to be exactly like everybody else, at least in Sweden. I think it's much more important to look at things more critically than that, on a case-by-case basis. If GitHub Inc. or SourceForge Inc. provide e.g. mailing lists with spam filters, and nobody cares that the project becomes dependent on an unrelated third party to determine what is unwanted communication and what is not, then by all means, use the service. For me that threshold is very different for a mailing list than for a bug tracker or a source code repository. >> GitHub Inc. is a privately held company in the USA. I don't see how it >> could be beneficial in any way for the project to give up its >> independence. > > It would not give up independence. It would use one or more services > provided by that company. If the project uses those services then the project loses independence of those services. >>> It is related to cost, but not strictly the price for the certificate but >>> even more so the effort and maintenence cost in time and energy. >> >> Please speak for yourself. > > Did I *ever* speak for anyone else here? Never before! :) It did sound like you were speaking for the services I host. > Of course I speak for myself and as the person admining www.libssh2.org. That's of course all right! Thanks //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Mar 4 21:25:04 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t24KOhp0008074; Wed, 4 Mar 2015 21:25:01 +0100 Received: from mail-lb0-x22c.google.com (mail-lb0-x22c.google.com [IPv6:2a00:1450:4010:c04::22c]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t24KOf9B008020 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 4 Mar 2015 21:24:41 +0100 Received: by lbiz11 with SMTP id z11so20939366lbi.13 for ; Wed, 04 Mar 2015 12:24:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=4j/yjYXRusAXxQjSISV+WYIhw2ZXXVgyLALRT19Nca0=; b=RJR9svdVrFFR6FZCP9if8teUDGDCKp0E3tZ06nUdCXa00qta3y4fQ+urXMFeWuPWR7 8WcJqYAZqMaigYMFSYRR8omWkJs91PkvLJsJYuStDV5R14O0t2h25cokB29ODpyYyqSK cNd+zcudTRGqEcDtnM32tQIYcNoLiWG+1SPB4DNhTkedN7GxSV8V40FaPjipMe73+WiH GYYXdbDeNDK/9TVSZSA/iGmAz5a6sNcKd48/aaSTla2eLN6EHl+6MNCsXPMW2YYVDL9K 5Nsa2Z3niKteSx7Z2lrPAiEcyPs3wIkOaKpk4aSIDDIIc3kTPWUWiIKEaPyQ3S42Asjn 61LQ== MIME-Version: 1.0 X-Received: by 10.112.173.41 with SMTP id bh9mr4864033lbc.107.1425500677267; Wed, 04 Mar 2015 12:24:37 -0800 (PST) Received: by 10.25.38.18 with HTTP; Wed, 4 Mar 2015 12:24:37 -0800 (PST) In-Reply-To: <20150304133421.2891.qmail@stuge.se> References: <40899080-0DEF-42EA-B861-ED3C9CD362BF@eggerapps.at> <20150304133421.2891.qmail@stuge.se> Date: Wed, 4 Mar 2015 20:24:37 +0000 X-Google-Sender-Auth: fnqB5JbgNYGukwms83tdsbJwzCs Message-ID: Subject: Re: Download libssh2 source via HTTPS? From: Alexander Lamaison To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t24KOhp0008074 On 4 March 2015 at 13:34, Peter Stuge wrote: > Daniel Stenberg wrote: >> Personally, I wouldn't mind switching over to hosting the source code repo >> at github > >> All in the name of going where there's already a large amount of >> users, it brings features and it encourages and simplifies collaboration >> even further. Do it "like the kids do". > > Since when was being mainstream ever a good thing? > > GitHub Inc. is a privately held company in the USA. I don't see how it > could be beneficial in any way for the project to give up its independence. ... > As for barriers - have you read the github.com ToS recently? > https://github.com/site/terms > > The very first point is: > > A. Account Terms > 1. You must be 13 years or older to use this Service. > > How about that for a barrier? If I was growing up on the internet > today, I might want to contribute to libssh2 also before I'm 13. > > It is not common - but I think lowering the barrier is really important. > > 3. You must provide your name, a valid email address, and any other > information requested in order to complete the signup process. > > That sounds like a significant barrier to me. > "any other information requested" - and a completely arbitrary > barrier at that. > > > 7. One person or legal entity may not maintain more than one free > account. > > That too sounds like a barrier to me. ... > Please read those terms again. I think they are absurd. > > (But I know that they are absolutely required, because the service is > operated by a US company.) I understand why you disagree with some of these terms - I do too - but it's taking it too far to say that we cannot rely on any US company. That may give us 'independence', for what it's worth, but also leaves us out in the cold, unable to take advantage of new advances in collaboration and cloud services. And the reality is that we don't have to lose that independence at all. If we mirror our repo, we mitigate any possibility of being denied access to our own source code. Not that that was a reasonable likleyhood anyway, because, Git being Git, someone would have had an recent clone. As for your concerns about barriers, it's a stretch to take them seriously. No-one has to sign up to GitHub with a name or valid email to clone code. Nor to make a change, and email a patch to the mailing list. So our theoretical 13-year-old is not prevented from contributing exactly the way they do today. It is true that they would not be able to create a GitHub account and fork our code and submit pull requests, but they already can't do that, so they lose nothing. There are two theoretical ways this could negatively affect anyone: - Project committers would be subject to GitHub's T&Cs. That would mean they would have to give their real name and email address. In a security-focussed project I welcome that. I would be uneasy if anyone with they keys to the codebase refused to identify themselves. A number of crypto-based projects (e.g. Truecrypt [1]) have realised that anonymity and trust do not go hand in hand, and now insist on real identities. That said, nothing would prevent anonymous people _contributing_ to libssh2, they just couldn't be committers. Also, comitters under 13 would not be allowed. I'm pretty sure we can cross that bridge if we ever come to it. - People filing issues would be subject to GitHub's T&Cs. This is probably the only concern that exists in practice. Anonymous issues would not be possible. Nor could they be from under-13s. However, that does not prevent either of those categories of people from emailing the mailing list to report a bug. Many people do it this way anyway. Oh, and apparently there's a workaround for this too [2]. [1] https://truecrypt.ch/ [2] https://gitreports.com/ >> And it makes the infrastructure less dependent on individual volunteers. > > If we had been having lots of problems with the infrastructure I agree > that this would have been a good argument. But I don't think that we've > had so many problems that we need a change. Git has gone down from time to time. It usually comes back up before a few hours but it's still annoying. Trac has never been great, especially manually moderating the tickets, which has been a disaster. We were allowing bug reports through in 6-month chunks. By then the reporters have lost interest and conclude our project is dead. This isn't anyone's fault - we're not sysadmins and we have other things taking our time. But that's the point. Nowadays there are companies willing to take this burden from developers. Do we really want to keep doing this ourselves? And all of this discussion is without mentioning the benefits of GitHub for collaboration. It's great seeing someone fork your project, and to be able to follow their progress and even discuss their changes with them. This kind of engagement makes it more likely changes are contributed back, any the quality of those contributions is better. You asked if being mainstream is a good thing? Not necessarily. But that doesn't automatically make it bad. Alex -- Swish - Easy SFTP for Windows Explorer (http://www.swish-sftp.org) _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Mar 5 16:55:42 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t25Ft9xg014825; Thu, 5 Mar 2015 16:55:36 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t25Ft7JW014773 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 5 Mar 2015 16:55:07 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t25Ft7Yt014768 for ; Thu, 5 Mar 2015 16:55:07 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Thu, 5 Mar 2015 16:55:07 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: Re: Download libssh2 source via HTTPS? In-Reply-To: Message-ID: References: <40899080-0DEF-42EA-B861-ED3C9CD362BF@eggerapps.at> <20150304133421.2891.qmail@stuge.se> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t25Ft9xg014825 Hi, I've received several positive voices on the suggestion to start using github and one opposing. I'm still interested in hearing more opinions from more people, users and contributors. In the mean time, I pushed the libssh2 repo to github to show off how it could look: https://github.com/bagder/libssh2 It also shows that all our top contributors already have accounts on github. -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Mar 5 21:49:28 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t25Kn8QR015932; Thu, 5 Mar 2015 21:49:25 +0100 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t25KmWHO015569 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 5 Mar 2015 21:48:34 +0100 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t25KmWMp031476 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 5 Mar 2015 15:48:32 -0500 Received: from nbkamil.localnet ([10.40.204.39]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t25KmUoV007087; Thu, 5 Mar 2015 15:48:31 -0500 From: Kamil Dudka To: Daniel Stenberg Subject: Re: Download libssh2 source via HTTPS? Date: Thu, 05 Mar 2015 21:47 +0100 Message-ID: <109687106.rNUrHsPHZ7@nbkamil> User-Agent: KMail/4.14.3 (Linux/3.17.8-gentoo-r1; KDE/4.14.3; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Cc: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t25Kn8QR015932 On Thursday, March 05, 2015 16:55:07 Daniel Stenberg wrote: > Hi, > > I've received several positive voices on the suggestion to start using > github and one opposing. > > I'm still interested in hearing more opinions from more people, users and > contributors. I like the idea of moving the repository to github. Kamil > In the mean time, I pushed the libssh2 repo to github to show off how it > could look: https://github.com/bagder/libssh2 > > It also shows that all our top contributors already have accounts on github. _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Mar 5 22:58:58 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t25LwkF7022132; Thu, 5 Mar 2015 22:58:57 +0100 Received: from mail.panic.com (posh.panic.com [38.103.165.4]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t25LwihM022042 for ; Thu, 5 Mar 2015 22:58:44 +0100 Received: from [10.0.0.94] (unknown [38.103.165.36]) by mail.panic.com (Postfix) with ESMTPSA id A0928B6874A1 for ; Thu, 5 Mar 2015 13:58:36 -0800 (PST) Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: Download libssh2 source via HTTPS? From: Will Cosgrove In-Reply-To: <109687106.rNUrHsPHZ7@nbkamil> Date: Thu, 5 Mar 2015 13:58:36 -0800 Message-Id: <6E56E98B-6EBD-4B28-B7FD-480B6DF577C0@panic.com> References: <109687106.rNUrHsPHZ7@nbkamil> To: libssh2 development X-Mailer: Apple Mail (2.2070.6) X-MIME-Autoconverted: from quoted-printable to 8bit by giant.haxx.se id t25LwihM022042 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t25LwkF7022132 We (speaking for Panic) would also love to see the project moved to a better source control system. Github lowers the bar for contributors and encourages easy patch submissions. We have numerous patches we’d like to commit back, but frankly don’t have the time to create diffs for everything. Cheers, Will > On Mar 5, 2015, at 12:47 PM, Kamil Dudka wrote: > > On Thursday, March 05, 2015 16:55:07 Daniel Stenberg wrote: >> Hi, >> >> I've received several positive voices on the suggestion to start using >> github and one opposing. >> >> I'm still interested in hearing more opinions from more people, users and >> contributors. > > I like the idea of moving the repository to github. > > Kamil > >> In the mean time, I pushed the libssh2 repo to github to show off how it >> could look: https://github.com/bagder/libssh2 >> >> It also shows that all our top contributors already have accounts on github. > _______________________________________________ > libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Fri Mar 6 14:22:14 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t26DLmwJ027662; Fri, 6 Mar 2015 14:22:10 +0100 Received: from plane.gmane.org (plane.gmane.org [80.91.229.3]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t26DLl5F027653 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 6 Mar 2015 14:21:47 +0100 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1YTsCG-00064Q-TM for libssh2-devel@cool.haxx.se; Fri, 06 Mar 2015 14:21:45 +0100 Received: from 213.37.131.197.static.user.ono.com ([213.37.131.197]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 06 Mar 2015 14:21:44 +0100 Received: from sfandino by 213.37.131.197.static.user.ono.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 06 Mar 2015 14:21:44 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: libssh2-devel@cool.haxx.se From: Salvador Fandino Subject: Re: Download libssh2 source via HTTPS? Date: Fri, 06 Mar 2015 14:21:37 +0100 Lines: 11 Message-ID: <54F9A9E1.9090404@gmail.com> References: <40899080-0DEF-42EA-B861-ED3C9CD362BF@eggerapps.at> <20150304133421.2891.qmail@stuge.se> Mime-Version: 1.0 X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 213.37.131.197.static.user.ono.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 In-Reply-To: X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t26DLmwJ027662 On 03/05/2015 04:55 PM, Daniel Stenberg wrote: > Hi, > > I've received several positive voices on the suggestion to start using > github and one opposing. > > I'm still interested in hearing more opinions from more people, users > and contributors. github++ _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Fri Mar 6 22:45:45 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t26LjFMK020766; Fri, 6 Mar 2015 22:45:40 +0100 Received: from mail-ob0-x22b.google.com (mail-ob0-x22b.google.com [IPv6:2607:f8b0:4003:c01::22b]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t26LjD6n020475 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 6 Mar 2015 22:45:14 +0100 Received: by obcuz6 with SMTP id uz6so23362159obc.9 for ; Fri, 06 Mar 2015 13:45:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=4tiRVY8/f1M1qjH/Z3rpCmEIVScHbBxpwpIvkTsTmz0=; b=1B9oEzjJC376WaX5Gm4/uVk/N3MNGU+jNr3KuszJTiEQB8yQSGG2WZguN/6NJ0utsI FDCiMYz1XrWxF3Zg2Zc5faWCa3WHAMbx6cym1A4tXKXwpW+QRnsVBRWSjuClofUao4ZK pI/hPl5evsKwAiU9nnLX5gsOGsc56ET/u21QvWh6LrfQcj+bizOC7H/LLucWJO8jnDVA Jos5QVLu0uouXnl6YyuK85Fybs9bVlqvmaXF6j4AJ8VCvaqXQmqhsEalqC2z0Ke2MfRh 6SNMZJpYy14RXBoGAJKXgxtqqymOXZ7WAwoOLpa2srVsWMqXDhXsOwBDnSekXINYzvjy 0GTw== MIME-Version: 1.0 X-Received: by 10.182.215.133 with SMTP id oi5mr12599568obc.55.1425678309800; Fri, 06 Mar 2015 13:45:09 -0800 (PST) Received: by 10.202.74.69 with HTTP; Fri, 6 Mar 2015 13:45:09 -0800 (PST) Date: Fri, 6 Mar 2015 16:45:09 -0500 Message-ID: Subject: SSH_MSG_USERAUTH_BANNER support From: Bill Levine To: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============1505666171==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============1505666171== Content-Type: multipart/alternative; boundary=001a11c25434383f620510a599b5 --001a11c25434383f620510a599b5 Content-Type: text/plain; charset=UTF-8 I have a need to handle this banner message in my application. It doesn't seem to be supported in 1.4.3. I do see some talk of an upcoming release in the archives and was wondering if that might perhaps be included? If not, and my organization did add it, would that be something of interest to get back to you guys? Thanks. --001a11c25434383f620510a599b5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I have a need to handle this banner message in m= y application.=C2=A0 It doesn't seem to be supported in 1.4.3.

<= /div>I do see some talk of an upcoming release in the archives and was wond= ering if that might perhaps be included?=C2=A0 If not, and my organization = did add it, would that be something of interest to get back to you guys?
Thanks.

--001a11c25434383f620510a599b5-- --===============1505666171== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============1505666171==-- From libssh2-devel-bounces@cool.haxx.se Fri Mar 6 22:51:43 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t26LpfTh023027; Fri, 6 Mar 2015 22:51:42 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t26LpdCk023016 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 6 Mar 2015 22:51:39 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t26LpdbM023012 for ; Fri, 6 Mar 2015 22:51:39 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Fri, 6 Mar 2015 22:51:39 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: Re: SSH_MSG_USERAUTH_BANNER support In-Reply-To: Message-ID: References: User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t26LpfTh023027 On Fri, 6 Mar 2015, Bill Levine wrote: > I do see some talk of an upcoming release in the archives and was wondering > if that might perhaps be included? No, it isn't. What's in git now is basically what will be released so you can also see that for yourself. > If not, and my organization did add it, would that be something of interest > to get back to you guys? Yes please! -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Sun Mar 8 14:53:16 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t28DqmGg019036; Sun, 8 Mar 2015 14:53:13 +0100 Received: from mx.uxnr.de (mx.uxnr.de [89.238.84.48]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t28DqkNV019014 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 8 Mar 2015 14:52:46 +0100 Received: from marcs-mbp.ma01.uxnr.net (p5B0A4ED8.dip0.t-ipconnect.de [91.10.78.216]) by mx.uxnr.de (Postfix) with ESMTPSA id 7449E1C5A33A for ; Sun, 8 Mar 2015 14:52:47 +0100 (CET) X-DKIM: OpenDKIM Filter v2.6.8 mx.uxnr.de 7449E1C5A33A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=marc-hoersken.de; s=picard; t=1425822767; bh=eRkdCL6g0EI7wUHZfbtFqZY2Od+UDUUo6J3SBKWxsBA=; h=Subject:From:In-Reply-To:Date:References:To:From; b=o/dSsY6hZdUphuawxa4Z2DALVFn/Q5LOUKNfrwwIO/SsMFhvewj5oeUC3ZSgjB3zP ez2jOW3xn2FgMI/qEno7X63i4c4/glUQJo/Us1DYrw91Ng/MEtUyWvzTYOZjrKtOTA BJG2yly/uStpcsNuSfUhfJuwC0arQ0ZqTGZT/SMk= Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: Download libssh2 source via HTTPS? From: =?utf-8?Q?Marc_H=C3=B6rsken?= In-Reply-To: Date: Sun, 8 Mar 2015 14:52:38 +0100 Message-Id: <73F5BB8A-5207-4963-9C54-39134F7A8D75@marc-hoersken.de> References: <40899080-0DEF-42EA-B861-ED3C9CD362BF@eggerapps.at> <20150304133421.2891.qmail@stuge.se> To: libssh2 development X-Mailer: Apple Mail (2.2070.6) X-Spam-Status: No, score=0.1 required=5.0 tests=DKIM_SIGNED,T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on picard.vpn.uxnr.de X-MIME-Autoconverted: from quoted-printable to 8bit by giant.haxx.se id t28DqkNV019014 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t28DqmGg019036 Hi Daniel, I am basically open for the existing self-hosted platform, github and a hybrid of both, just like with curl. Best regards, Marc _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Sun Mar 8 18:53:08 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t28HqjD9027822; Sun, 8 Mar 2015 18:53:04 +0100 Received: from foo.stuge.se (qmailr@foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t28Hqh48027795 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 8 Mar 2015 18:52:43 +0100 Received: (qmail 6849 invoked by uid 501); 8 Mar 2015 17:52:43 -0000 Message-ID: <20150308175243.6848.qmail@stuge.se> Date: Sun, 8 Mar 2015 18:52:43 +0100 From: Peter Stuge To: libssh2-devel@cool.haxx.se Subject: Re: Download libssh2 source via HTTPS? Mail-Followup-To: libssh2-devel@cool.haxx.se References: <109687106.rNUrHsPHZ7@nbkamil> <6E56E98B-6EBD-4B28-B7FD-480B6DF577C0@panic.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6E56E98B-6EBD-4B28-B7FD-480B6DF577C0@panic.com> X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t28HqjD9027822 Will Cosgrove wrote: > We (speaking for Panic) would also love to see the project moved to > a better source control system. The project is already using Git, so Github is no different there. > Github lowers the bar for contributors and encourages easy patch > submissions. We have numerous patches we’d like to commit back, > but frankly don’t have the time to create diffs for everything. Sorry - this is very confusing. You have patches but not diffs? To me those two words refer to essentially the same thing. We'd love to see your contributions, but whether via Github or email or USB stick when meeting in person you will at a minimum need a branch in a local repository with your proposed changes, and go from there. You'll need to write meaningful commit mesages and have one commit per logical change. Whether you then push that branch to Github (git push) or send your changes to the mailing list (git send-email) shouldn't make much of a difference? Confused //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Sun Mar 8 20:17:26 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t28JHETL007602; Sun, 8 Mar 2015 20:17:25 +0100 Received: from mail.panic.com (posh.panic.com [38.103.165.4]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t28JHC4D007582 for ; Sun, 8 Mar 2015 20:17:12 +0100 Received: from [10.0.1.18] (c-76-115-128-120.hsd1.or.comcast.net [76.115.128.120]) by mail.panic.com (Postfix) with ESMTPSA id CF97FB6EA543 for ; Sun, 8 Mar 2015 12:17:03 -0700 (PDT) From: Will Cosgrove Mime-Version: 1.0 (1.0) Subject: Re: Download libssh2 source via HTTPS? Message-Id: <7DCB6E47-4409-45EA-A6A6-6BF58A4CBCD7@panic.com> Date: Sun, 8 Mar 2015 12:17:02 -0700 References: <109687106.rNUrHsPHZ7@nbkamil> <6E56E98B-6EBD-4B28-B7FD-480B6DF577C0@panic.com> <20150308175243.6848.qmail@stuge.se> In-Reply-To: <20150308175243.6848.qmail@stuge.se> To: libssh2 development X-Mailer: iPhone Mail (12B466) X-MIME-Autoconverted: from quoted-printable to 8bit by giant.haxx.se id t28JHC4D007582 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t28JHETL007602 > Will Cosgrove wrote: >> We (speaking for Panic) would also love to see the project moved to >> a better source control system. > > The project is already using Git, so Github is no different there. There are quite a few differences beyond just straight git. >> Github lowers the bar for contributors and encourages easy patch >> submissions. We have numerous patches we’d like to commit back, >> but frankly don’t have the time to create diffs for everything. > > Sorry - this is very confusing. You have patches but not diffs? To me > those two words refer to essentially the same thing. We are slightly out of band, thus we'd have to get up to date and create patches. That is all I'm getting at. With github, at simplifies the process slightly. > We'd love to see your contributions, but whether via Github or email > or USB stick when meeting in person you will at a minimum need a > branch in a local repository with your proposed changes, and go from > there. You'll need to write meaningful commit mesages and have one > commit per logical change. > > Whether you then push that branch to Github (git push) or send your > changes to the mailing list (git send-email) shouldn't make much of > a difference? We have created a trac issue including a diff with additional HMAC support #286 and it has never been applied. It's going on 11 months of just sitting there. That indicates a problem with the current process that I'd like to see resolved. Will _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Sun Mar 8 23:17:58 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t28MHat7020807; Sun, 8 Mar 2015 23:17:53 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t28MHZh1020799 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 8 Mar 2015 23:17:35 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t28MHZb3020796 for ; Sun, 8 Mar 2015 23:17:35 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Sun, 8 Mar 2015 23:17:35 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: Re: Download libssh2 source via HTTPS? In-Reply-To: <7DCB6E47-4409-45EA-A6A6-6BF58A4CBCD7@panic.com> Message-ID: References: <109687106.rNUrHsPHZ7@nbkamil> <6E56E98B-6EBD-4B28-B7FD-480B6DF577C0@panic.com> <20150308175243.6848.qmail@stuge.se> <7DCB6E47-4409-45EA-A6A6-6BF58A4CBCD7@panic.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t28MHat7020807 On Sun, 8 Mar 2015, Will Cosgrove wrote: > We have created a trac issue including a diff with additional HMAC support > #286 and it has never been applied. It's going on 11 months of just sitting > there. That indicates a problem with the current process that I'd like to > see resolved. Unfortunately, I think our greatest problem is that we're just not enough people with time and energy to spend on libssh2 issues. Issues posted to trac are basically not being read or handled by anyone, it is just a way to store them until someone at some point in the future wants to help out and push our project forward. This can be seen by the large amount of open issues, many of them very old. Also, personally, I would much more appreciate if people brought issues and disussions to the mailing list as I will see such more likely and timely and participate in that. -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Sun Mar 8 23:58:27 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t28MwKg6026594; Sun, 8 Mar 2015 23:58:26 +0100 Received: from mail.panic.com (posh.panic.com [38.103.165.4]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t28MwICK026575 for ; Sun, 8 Mar 2015 23:58:19 +0100 Received: from [10.0.1.18] (c-76-115-128-120.hsd1.or.comcast.net [76.115.128.120]) by mail.panic.com (Postfix) with ESMTPSA id CF7B9B6F2218 for ; Sun, 8 Mar 2015 15:58:09 -0700 (PDT) From: Will Cosgrove Mime-Version: 1.0 (1.0) Subject: Re: Download libssh2 source via HTTPS? Message-Id: Date: Sun, 8 Mar 2015 15:58:08 -0700 References: <109687106.rNUrHsPHZ7@nbkamil> <6E56E98B-6EBD-4B28-B7FD-480B6DF577C0@panic.com> <20150308175243.6848.qmail@stuge.se> <7DCB6E47-4409-45EA-A6A6-6BF58A4CBCD7@panic.com> In-Reply-To: To: libssh2 development X-Mailer: iPhone Mail (12B466) X-MIME-Autoconverted: from quoted-printable to 8bit by giant.haxx.se id t28MwICK026575 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t28MwKg6026594 Exactly, here's where I say our diff is as simple as a pull request on github. Review it and apply it to trunk, done. Posting diffs to an email list in 2015 as the preferred way of committing patches, IMHO, is a huge barrier to entry. At least it is for our team. Will > On Mar 8, 2015, at 3:17 PM, Daniel Stenberg wrote: > >> On Sun, 8 Mar 2015, Will Cosgrove wrote: >> >> We have created a trac issue including a diff with additional HMAC support #286 and it has never been applied. It's going on 11 months of just sitting there. That indicates a problem with the current process that I'd like to see resolved. > > Unfortunately, I think our greatest problem is that we're just not enough people with time and energy to spend on libssh2 issues. > > Issues posted to trac are basically not being read or handled by anyone, it is just a way to store them until someone at some point in the future wants to help out and push our project forward. This can be seen by the large amount of open issues, many of them very old. > > Also, personally, I would much more appreciate if people brought issues and disussions to the mailing list as I will see such more likely and timely and participate in that. > > -- > > / daniel.haxx.se > _______________________________________________ > libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Mar 9 06:19:57 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t295JVgq024435; Mon, 9 Mar 2015 06:19:54 +0100 Received: from mail-wg0-x234.google.com (mail-wg0-x234.google.com [IPv6:2a00:1450:400c:c00::234]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t295JT2p023763 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 9 Mar 2015 06:19:29 +0100 Received: by wggx12 with SMTP id x12so14747039wgg.10 for ; Sun, 08 Mar 2015 22:19:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=hAu3jLik4A2vSvhHR6Dj8GDc6IjGFW+RlkXp+hAsWDM=; b=zcFZlMJHyn/065OLY2nlK6mPJCfLdkUwfqZN3/kBm5KIosnGQXOp/DkdHdI1iqqYuc rz92b5K0Zuk1x5rfHWzyWcB1aENKFHtjcnCi9IngxFVrlfWuOiO0jyXhyhPJE+aQlxY/ 5vEe1pSnMo9O8BUvqHn7REh5mr7XysyIycN+zNwqacuVVpFLpR7QdCmi363pgXj600nz eF/hK+IMMUYyF4fMPF3GxCoJ5rTNZcanbVQubKr2ibMzwP+yJRg3zAx2tA2DsHRjz+5w zRH9PhhugbZJxeu094AVypsgwBJWNq+Ou1VeMjepS+XE1nFuT6Ev3MVJ17o0uUu/cGKI G5jQ== MIME-Version: 1.0 X-Received: by 10.180.77.19 with SMTP id o19mr34882956wiw.90.1425878364863; Sun, 08 Mar 2015 22:19:24 -0700 (PDT) Received: by 10.27.131.143 with HTTP; Sun, 8 Mar 2015 22:19:24 -0700 (PDT) Date: Mon, 9 Mar 2015 06:19:24 +0100 Message-ID: Subject: Re: Download libssh2 source via HTTPS? From: Tor Arntsen To: libssh2 development X-MIME-Autoconverted: from quoted-printable to 8bit by giant.haxx.se id t295JT2p023763 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t295JVgq024435 On 8 March 2015 at 23:58, Will Cosgrove wrote: > Exactly, here's where I say our diff is as simple as a pull request on github. Review it and apply it to trunk, done. Posting diffs to an email list in 2015 as the preferred way of committing patches, IMHO, is a huge barrier to entry. At least it is for our team. With Git it is actually very easy. After a one-time configuration it can be as exceedingly simple as: git send-email --to libssh2-devel@cool.haxx.se master..branch-with-my-fixes (try it with a --dry-run first) If the adressee is actually a commiter (and not the list) then the commiter name as address then git finds the email address automatically. Useful inside a team, for example. Particularly when not co-located. When that's said, I wouldn't mind a move to github. I agree with Peter's objections about github to some extent, but I believe we aren't actually being affected by that because after all Git is a distributed version control system and we are always in full control of the repository - because a github one would be just another copy among very many. -Tor _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Mar 9 15:41:38 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t29EfDZ3015281; Mon, 9 Mar 2015 15:41:33 +0100 Received: from foo.stuge.se (qmailr@foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t29EfBGe015206 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 9 Mar 2015 15:41:11 +0100 Received: (qmail 11801 invoked by uid 501); 9 Mar 2015 14:41:11 -0000 Message-ID: <20150309144111.11800.qmail@stuge.se> Date: Mon, 9 Mar 2015 15:41:11 +0100 From: Peter Stuge To: libssh2-devel@cool.haxx.se Subject: Re: Download libssh2 source via HTTPS? Mail-Followup-To: libssh2-devel@cool.haxx.se References: <109687106.rNUrHsPHZ7@nbkamil> <6E56E98B-6EBD-4B28-B7FD-480B6DF577C0@panic.com> <20150308175243.6848.qmail@stuge.se> <7DCB6E47-4409-45EA-A6A6-6BF58A4CBCD7@panic.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t29EfDZ3015281 Will Cosgrove wrote: > Exactly, here's where I say our diff is as simple as a pull request > on github. Review it and apply it to trunk, done. Posting diffs to > an email list in 2015 as the preferred way of committing patches, > IMHO, is a huge barrier to entry. At least it is for our team. # one-time configuration, needed for sending email; github needs other git config sendemail.from 'Will Cosgrove ' git config sendemail.to libssh2-devel@cool.haxx.se git config sendemail.suppresscc all git config sendemail.multiedit false # for each local branch of changes, neccessary whether github or email git checkout local_branch_name git fetch origin git rebase origin/master # emailing your commits to the mailing list git send-email origin/master.. # ..or pushing to github git push github local_branch_name //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Mar 9 15:42:41 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t29Eged1016405; Mon, 9 Mar 2015 15:42:41 +0100 Received: from foo.stuge.se (qmailr@foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t29Egcoa016400 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 9 Mar 2015 15:42:39 +0100 Received: (qmail 11895 invoked by uid 501); 9 Mar 2015 14:42:40 -0000 Message-ID: <20150309144240.11894.qmail@stuge.se> Date: Mon, 9 Mar 2015 15:42:40 +0100 From: Peter Stuge To: libssh2-devel@cool.haxx.se Subject: Re: Download libssh2 source via HTTPS? Mail-Followup-To: libssh2-devel@cool.haxx.se References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t29Eged1016405 Tor Arntsen wrote: > I agree with Peter's objections about github to some extent, but I > believe we aren't actually being affected by that because after all > Git is a distributed version control system and we are always in > full control of the repository - because a github one would be just > another copy among very many. Unfortunately that's not how repository consumers think. //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Mar 10 06:03:30 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2A3TntN024759; Tue, 10 Mar 2015 04:30:11 +0100 Received: from mail-we0-x22a.google.com (mail-we0-x22a.google.com [IPv6:2a00:1450:400c:c03::22a]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2A3TlYl024072 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2015 04:29:47 +0100 Received: by wesw55 with SMTP id w55so16948290wes.2 for ; Mon, 09 Mar 2015 20:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=fdWmohZHNzTQjvKgIbYJRljf0kZgNePsMteH330qBP8=; b=svIwYbB8gqjHdWBlggGOckCv+cwNNHVfr/5PbMGABNzL8gFrbZamJYqBXXxwOUlCmC AhDphmx7Y6mbr1GkZu9mJZMCNwbjEMYZYNt16UEq4Alzbczs+2WtTsbdF8H/4Ef4Rne8 nCq88uyXRZ25vt2YtPZbLYnZpSasV5EI60+3JFXxmu9WqZRoH/l8k8x6fS5NP45XXKIW 1OHURle96Z1YR47X7CYTSDpR+UdGMgrOsRThbpT1s3gSVrVdJnaUfGFATd9a+dsGJeTz 0P5llSpRpAuFBhdDejkguMJ1H161qZWH226/LXm//ZBqmfKTdsH21D3O8dPnVYbQHVQ2 BPtg== MIME-Version: 1.0 X-Received: by 10.180.77.19 with SMTP id o19mr44024172wiw.90.1425958181788; Mon, 09 Mar 2015 20:29:41 -0700 (PDT) Received: by 10.27.131.143 with HTTP; Mon, 9 Mar 2015 20:29:41 -0700 (PDT) In-Reply-To: <20150309144240.11894.qmail@stuge.se> References: <20150309144240.11894.qmail@stuge.se> Date: Tue, 10 Mar 2015 04:29:41 +0100 Message-ID: Subject: Re: Download libssh2 source via HTTPS? From: Tor Arntsen To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2A3TntN024759 On 9 March 2015 at 15:42, Peter Stuge wrote: > Tor Arntsen wrote: >> I agree with Peter's objections about github to some extent, but I >> believe we aren't actually being affected by that because after all >> Git is a distributed version control system and we are always in >> full control of the repository - because a github one would be just >> another copy among very many. > > Unfortunately that's not how repository consumers think. Hmm.. I don't see how that would matter? I'm not sure it's even true, certainly not for developers, in this case Git users.. it's not possible to use Git and not be aware of its distributed nature. But then again, imagining that indeed they didn't understand that, it *still* wouldn't make a diffrence because it *is* distributed, which means that there's nothing github can block us from doing. And as Daniel said, nothing is changed relative to how everyone can still contribute exactly as before - via the mailing list (re. the under-13 years old. And yes, that's silly by github.) -Tor _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Mar 10 09:50:02 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2A8ncYV018032; Tue, 10 Mar 2015 09:49:57 +0100 Received: from foo.stuge.se (foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2A8naJD017939 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 10 Mar 2015 09:49:36 +0100 Received: (qmail 7728 invoked by uid 501); 10 Mar 2015 08:49:31 -0000 Message-ID: <20150310084931.7727.qmail@stuge.se> Date: Tue, 10 Mar 2015 09:49:31 +0100 From: Peter Stuge To: libssh2-devel@cool.haxx.se Subject: Re: Download libssh2 source via HTTPS? Mail-Followup-To: libssh2-devel@cool.haxx.se References: <20150309144240.11894.qmail@stuge.se> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2A8ncYV018032 Tor Arntsen wrote: > >> I agree with Peter's objections about github to some extent, but I > >> believe we aren't actually being affected by that because after all > >> Git is a distributed version control system and we are always in > >> full control of the repository - because a github one would be just > >> another copy among very many. > > > > Unfortunately that's not how repository consumers think. > > Hmm.. I don't see how that would matter? I'm not sure it's even true, > certainly not for developers, in this case Git users.. The point is that facts never really matter, only perception matters. If repository consumers (that's developers and packagers) perceive that github.com is the primary distribution method for libssh2 then that will in practice be the *only* distribution method. > there's nothing github can block us from doing. Sure - but it just doesn't matter what we do on libssh2.org when consumers believe that github.com is the truth. When was the last time you looked for a second opinion? Thanks //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Mar 10 13:10:58 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2ACAZq7022841; Tue, 10 Mar 2015 13:10:53 +0100 Received: from mail-yk0-x22c.google.com (mail-yk0-x22c.google.com [IPv6:2607:f8b0:4002:c07::22c]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2ACAWl5022760 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2015 13:10:33 +0100 Received: by ykp9 with SMTP id 9so470747ykp.8 for ; Tue, 10 Mar 2015 05:10:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=rrSOla6xDcLvLaZVSI5UaPozC7T3poVyz5eTXPErXZI=; b=ApdeG8dJst1UmzYIfQCuRkl6YUPL68mMjuj3HsNEBIG8qZUVgRAGiHZO16KQDso+8J bL/n2MJRWguw/h4IhD1ejhMlJutf9lz/O76JB37dyv3hpuljkaeQtYGJHfxxAFi6/AXg ifMkeb+oxzeXFfgAxCbvkBsbaDETivmg1D9hsCS+k1te9Vx+zg1Y19XtBaKgXus3oY5f 8/szUr+rytfHf7LnwxYCjup6aX5+WpOGjagLvTmEJIXxfVfX/HX8PikdybmcSlFO8pBZ F2luTZeACTTvDdpNNKLef+V91hN0YTeuezfwWcyB1Y8zYTr3cgOSjdqk8vx/D02faGmX aWkw== MIME-Version: 1.0 X-Received: by 10.170.85.65 with SMTP id c62mr22784894yka.77.1425989426928; Tue, 10 Mar 2015 05:10:26 -0700 (PDT) Received: by 10.170.55.135 with HTTP; Tue, 10 Mar 2015 05:10:26 -0700 (PDT) In-Reply-To: <20150309144111.11800.qmail@stuge.se> References: <109687106.rNUrHsPHZ7@nbkamil> <6E56E98B-6EBD-4B28-B7FD-480B6DF577C0@panic.com> <20150308175243.6848.qmail@stuge.se> <7DCB6E47-4409-45EA-A6A6-6BF58A4CBCD7@panic.com> <20150309144111.11800.qmail@stuge.se> Date: Tue, 10 Mar 2015 22:10:26 +1000 X-Google-Sender-Auth: 6uJ8ig7_2fEulAYio6OFBueBbMM Message-ID: Subject: Re: Download libssh2 source via HTTPS? From: Bill Segall To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============0438807918==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============0438807918== Content-Type: multipart/alternative; boundary=001a113993863ee0d50510ee097a --001a113993863ee0d50510ee097a Content-Type: text/plain; charset=UTF-8 > > # emailing your commits to the mailing list > git send-email origin/master.. > > # ..or pushing to github > git push github local_branch_name > > You're right. There is effectively no difference between these two except .... 99% of developers know about the push and have never used send-email. But that's not actually the important distinction, what matters is what happens next. After the send-email some fraction of the developers engaged enough to be on a mailing list might be motivated enough to download and have a look at a patch but we've already presented a barrier to entry, cos it's not just click to look. And once we look at the patch, we get a lovely color encoded web view, we get to see the developer stats and their activity. If I'm doing especially well, the CI system might have shown me that the patch compiles, that the tests passed and that it even fixed an existing bug. To adopt the patch one of the chosen few might be able to click and accept it so we don't get emails that complain they posted a patch to the mailing list 6 months ago etc. And it's there for people to find, adopt, fork, improve, contribute further to at lower cost. The point I'm making is that engagement, process, and visibility (the UI thing) actually matter. People these days have an expectation about all of these things and if you're not meeting and hopefully exceeding those expectations you're losing the one currency that matters which is developer engagement. Regards, Bill. And what happens next --001a113993863ee0d50510ee097a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
# emailing your commits to the mailing list
git send-email origin/master..

# ..or pushing to github
git push github local_branch_name

<= br>
You're right. There is effectively no difference between = these two except ....

99% of developers know about= the push and have never used send-email.

But that= 's not actually the important distinction, what matters is what happens= next.=C2=A0

After the send-email some fraction of= the developers engaged enough to be on a mailing list might be motivated e= nough to download and have a look at a patch but we've already presente= d a barrier to entry, cos it's not just click to look.

And once we look at the patch, we get a lovely color encoded web v= iew, we get to see the developer stats and their activity.

If I'm doing especially well, the CI system might have shown m= e that the patch compiles, that the tests passed and that it even fixed an = existing bug.=C2=A0

To adopt the patch one of the = chosen few might be able to click and accept it so we don't get emails = that complain they posted a patch to the mailing list 6 months ago etc.

And it's there for people to find, adopt, fork, i= mprove, contribute further to at lower cost.

The p= oint I'm making is that engagement, process, and visibility (the UI thi= ng) actually matter. People these days have an expectation about all of the= se things and if you're not meeting and hopefully exceeding those expec= tations you're losing the one currency that matters which is developer = engagement.

Regards,
Bill.
And what happens next

=C2=A0
--001a113993863ee0d50510ee097a-- --===============0438807918== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============0438807918==-- From libssh2-devel-bounces@cool.haxx.se Tue Mar 10 13:22:13 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2ACM8ma014828; Tue, 10 Mar 2015 13:22:12 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2ACM73K014788 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 10 Mar 2015 13:22:07 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t2ACM6FY014784 for ; Tue, 10 Mar 2015 13:22:06 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Tue, 10 Mar 2015 13:22:06 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: git repo on github Message-ID: User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2ACM8ma014828 Hi friends, The verdict was loud and clear: github it is: https://github.com/bagder/libssh2 The README and web site have been updated accordingly. I've given the 7 top committers (apart from myself) push rights Both issues and pull requests are open. Oh, and btw, the web site is already on github since a long time in case someone would feel a desire to help out there: https://github.com/bagder/libssh2-www -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Mar 10 13:46:34 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2ACkQnQ026927; Tue, 10 Mar 2015 13:46:33 +0100 Received: from foo.stuge.se (qmailr@foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2ACkODY026906 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 10 Mar 2015 13:46:24 +0100 Received: (qmail 26104 invoked by uid 501); 10 Mar 2015 12:46:25 -0000 Message-ID: <20150310124625.26103.qmail@stuge.se> Date: Tue, 10 Mar 2015 13:46:24 +0100 From: Peter Stuge To: libssh2-devel@cool.haxx.se Subject: Re: The GitHub unicorn Mail-Followup-To: libssh2-devel@cool.haxx.se References: <109687106.rNUrHsPHZ7@nbkamil> <6E56E98B-6EBD-4B28-B7FD-480B6DF577C0@panic.com> <20150308175243.6848.qmail@stuge.se> <7DCB6E47-4409-45EA-A6A6-6BF58A4CBCD7@panic.com> <20150309144111.11800.qmail@stuge.se> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2ACkQnQ026927 Bill Segall wrote: > > # emailing your commits to the mailing list > > git send-email origin/master.. > > > > # ..or pushing to github > > git push github local_branch_name > > You're right. There is effectively no difference between these two except > .... > > 99% of developers know about the push and have never used send-email. I think the onus is on developers to educate themselves about the tools they use, rather than on projects to conform to what people are used to consume from GitHub Inc. Now don't get me wrong, some things on github.com are nice, but I still wouldn't go near them as infrastructure provider. It's nowhere near worth it for me. > After the send-email some fraction of the developers engaged enough to be > on a mailing list might be motivated enough to download and have a look at > a patch but we've already presented a barrier to entry, cos it's not just > click to look. I don't know about your mail program, but mine show patches sent to the mailing list right then and there - because they double as emails. That seems much less of a barrier; no need to click on anything. > And once we look at the patch, we get a lovely color encoded web view, Indeed a mailer doesn't really do that. > we get to see the developer stats and their activity. Who cares? I think the patch is more important. > If I'm doing especially well, the CI system might have shown me that the > patch compiles, that the tests passed and that it even fixed an existing > bug. CI is nice, but by no means exclusive to github.com. In fact, you would probably have to rely on a different service provider. Or a volunteer could set up our own. > To adopt the patch one of the chosen few might be able to click and accept > it so we don't get emails that complain they posted a patch to the mailing > list 6 months ago etc. I like piping emails to git, but my experience is that very few patches can actually be applied without further work, so some back-and-forth communication is neccessary. E.g. email. Or I guess one could choose to use Facebook. > And it's there for people to find, adopt, fork, improve, contribute > further to at lower cost. I disagree that only github.com provides that, or provides it best. > The point I'm making is that Sure, but.. > engagement, ..this is much easier said than done. Regardless of github.com or libssh2.org actual humans need to engage and manage contributions. libssh2 like pretty much every other project is understaffed, and no colourful web page will change that. > process, The self-hosted process with patches on mailing lists works really well for a large number of projects, including the Linux kernel. > and visibility (the UI thing) Being understaffed, it's important for the processes to be efficient, and email is both efficient and visible. The list and its archives are public, the bug tracker is public, the repo is public. > People these days have an expectation Maybe they should have fewer expectations and make more contributions? > if you're not meeting and hopefully exceeding those expectations > you're losing the one currency that matters which is developer > engagement. We can only speak about "losing" if we have had something, and as I wrote, this project, like all others, is understaffed. Using github.com (or any other!) services isn't magically bringing qualified contributors into the project. Your reasoning makes perfect sense for a startup trying to be the hippest in order to attract and keep developers who might care more about appearances (visibility) than about actual code. That's not really what libssh2 needs. //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Mar 10 13:48:41 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2ACmeTA003682; Tue, 10 Mar 2015 13:48:41 +0100 Received: from foo.stuge.se (qmailr@foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2ACmd1f003677 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 10 Mar 2015 13:48:39 +0100 Received: (qmail 26297 invoked by uid 501); 10 Mar 2015 12:48:39 -0000 Message-ID: <20150310124839.26296.qmail@stuge.se> Date: Tue, 10 Mar 2015 13:48:39 +0100 From: Peter Stuge To: libssh2-devel@cool.haxx.se Subject: Re: git repo on github Mail-Followup-To: libssh2-devel@cool.haxx.se References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2ACmeTA003682 Daniel Stenberg wrote: > The verdict was loud and clear: github it is: I'll close {trac,git}.libssh2.org then? //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Mar 10 13:52:08 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2ACq5vD011118; Tue, 10 Mar 2015 13:52:07 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2ACq4Cx011108 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 10 Mar 2015 13:52:04 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t2ACq3fw011105 for ; Tue, 10 Mar 2015 13:52:03 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Tue, 10 Mar 2015 13:52:03 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: Re: git repo on github In-Reply-To: <20150310124839.26296.qmail@stuge.se> Message-ID: References: <20150310124839.26296.qmail@stuge.se> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2ACq5vD011118 On Tue, 10 Mar 2015, Peter Stuge wrote: > I'll close {trac,git}.libssh2.org then? I would prefer if they would remain. We have a HUGE amount of open bugs in trac, would be a pitty to lose all those, and we don't have any transition strategy or anything for them... For me, trac is still our primary bug tracker. The git repo is less important but I figure it could be valuable to keep it around for a while more just in case. -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Mar 10 14:02:53 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2AD2mnJ006557; Tue, 10 Mar 2015 14:02:52 +0100 Received: from foo.stuge.se (qmailr@foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2AD2kKB005634 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 10 Mar 2015 14:02:46 +0100 Received: (qmail 27400 invoked by uid 501); 10 Mar 2015 13:02:46 -0000 Message-ID: <20150310130246.27399.qmail@stuge.se> Date: Tue, 10 Mar 2015 14:02:46 +0100 From: Peter Stuge To: libssh2-devel@cool.haxx.se Subject: Re: git repo on github Mail-Followup-To: libssh2-devel@cool.haxx.se References: <20150310124839.26296.qmail@stuge.se> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2AD2mnJ006557 Daniel Stenberg wrote: >> I'll close {trac,git}.libssh2.org then? > > I would prefer if they would remain. I'm fine either way. > We have a HUGE amount of open bugs in trac, would be a pitty to lose all > those, and we don't have any transition strategy or anything for them... > For me, trac is still our primary bug tracker. I think it's important that we have only one place for bugs. I'm fine with helping to migrate if anyone wants to do that. > The git repo is less important but I figure it could be valuable to keep it > around for a while more just in case. If we have multiple repos then I think they should be synchronized somehow, probably automatically, meaning that one repo will need to be the primary distribution point. It's certainly possible for people to "manually" push to multiple URLs at once, but they have to change their config then: git remote set-url --add origin $github_url //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Mar 10 14:27:05 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2ADQqGY020623; Tue, 10 Mar 2015 14:27:04 +0100 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2ADQow4020497 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 10 Mar 2015 14:26:51 +0100 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 3FC0E2137C; Tue, 10 Mar 2015 09:26:48 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute3.internal (MEProxy); Tue, 10 Mar 2015 09:26:49 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:from:content-type:message-id :mime-version:subject:date:references:to:in-reply-to; s=smtpout; bh=997jdUTAsnkUY3Ou1eOfXofxVtE=; b=T/EQ4y1xzuuHuQLWv2pl+CQh4Rjp 0Wv8Wq9StVhKC35bHf5vKP5d9gjTWPX6sbkBg0wkJrxbDoFyUAogh2Uy0gdZaJZo dFk0z0C6ZBXKn0sO7glDP21lTH+AKcH0jb4u1mvDD9CcpsAD1q6G6kEDMbvqUIWy OZcnriaAkfVa0RY= X-Sasl-enc: ucX3glWQ5fNEEtLowQm9qsw9IRsYCm/51uFv8gnBFtzC 1425994009 Received: from [192.168.4.37] (unknown [90.146.2.242]) by mail.messagingengine.com (Postfix) with ESMTPA id 50E1968020E for ; Tue, 10 Mar 2015 09:26:49 -0400 (EDT) From: Jakob Egger Message-Id: <804C94F3-820C-4FF1-B06D-A1AB2E91FF92@eggerapps.at> Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: git repo on github Date: Tue, 10 Mar 2015 14:26:47 +0100 References: To: libssh2 development In-Reply-To: X-Mailer: Apple Mail (2.2070.6) X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============0823482745==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============0823482745== Content-Type: multipart/alternative; boundary="Apple-Mail=_499695B1-002E-4D48-8AC3-161CB14324C6" --Apple-Mail=_499695B1-002E-4D48-8AC3-161CB14324C6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hi Daniel, What do you think about creating a Github "organization" for libssh2? Open Source organizations are free to create on Github. Creating an = organization would change the URL to github.com/libssh2/libssh2 = instead of github.com/bagder/libssh2 = . It would make it clear that this is = the official fork. Creating an organization would also make it more visible who is a member = of an organization (who has push rights to the repo). Jakob > Am 10.03.2015 um 13:22 schrieb Daniel Stenberg : >=20 > Hi friends, >=20 > The verdict was loud and clear: github it is: >=20 > https://github.com/bagder/libssh2 >=20 > The README and web site have been updated accordingly. I've given the = 7 top committers (apart from myself) push rights >=20 > Both issues and pull requests are open. >=20 > Oh, and btw, the web site is already on github since a long time in = case someone would feel a desire to help out there: >=20 > https://github.com/bagder/libssh2-www >=20 > --=20 >=20 > / daniel.haxx.se > _______________________________________________ > libssh2-devel = http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel --Apple-Mail=_499695B1-002E-4D48-8AC3-161CB14324C6 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii Hi Daniel,

What do you think about creating a Github "organization" for = libssh2?

Open = Source organizations are free to create on Github. Creating an = organization would change the URL to github.com/libssh2/libssh2 instead of github.com/bagder/libssh2. It would make it clear that = this is the official fork.

Creating an organization would also make it more visible who = is a member of an organization (who has push rights to the = repo).

Jakob

Am 10.03.2015 um 13:22 schrieb = Daniel Stenberg <daniel@haxx.se>:

Hi friends,

The verdict was loud and clear: github it = is:

 https://github.com/bagder/libssh2

The README and web site have been updated accordingly. I've = given the 7 top committers (apart from myself) push rights

Both issues and pull requests are open.

Oh, and btw, the web site is already on github = since a long time in case someone would feel a desire to help out = there:

 https://github.com/bagder/libssh2-www

--

/ daniel.haxx.se
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel<= br class=3D"">

= --Apple-Mail=_499695B1-002E-4D48-8AC3-161CB14324C6-- --===============0823482745== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============0823482745==-- From libssh2-devel-bounces@cool.haxx.se Tue Mar 10 15:48:54 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2AEmYwo012309; Tue, 10 Mar 2015 15:48:51 +0100 Received: from mail-we0-x234.google.com (mail-we0-x234.google.com [IPv6:2a00:1450:400c:c03::234]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2AEmXvr012249 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2015 15:48:33 +0100 Received: by wesw55 with SMTP id w55so2368622wes.2 for ; Tue, 10 Mar 2015 07:48:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=Q3Jc1rPlbfiZZPGHUxdUg/WTUXa2AuQPmCvwTjJmo8E=; b=JCoj8/c3tsaWbG8tZ8qHElNQxLC/ZXPDvxs1SWl7Du+t4tH8BqWeZrMnBwjztVy29c 1H8tOMvWT67M5PURq9UzPnNmno5YDFXeUVkwEIF276zsxXNOoqXf9iz7csJJWZE78C4I qN2kfXc9d16xFUvJEjsxJkkF+S5JxE7IFLMd2sOULuEN45v5pwUYf6wbG2CmKEn2iacZ DlyZ9UBLdkFPX8jcPLZ+O1a4JUClaOBf6kKTCh+IBlWllBta+NKC3FwIP6qj0719KXtY eyX63W1d9GK0r9fiDySXGYQNQwmQR7gWqbMpnMQTUKJ8DFxa517WsxLyzxnZwt5EDetp GK1w== MIME-Version: 1.0 X-Received: by 10.194.172.9 with SMTP id ay9mr68296950wjc.2.1425998908280; Tue, 10 Mar 2015 07:48:28 -0700 (PDT) Received: by 10.27.131.143 with HTTP; Tue, 10 Mar 2015 07:48:28 -0700 (PDT) In-Reply-To: References: <109687106.rNUrHsPHZ7@nbkamil> <6E56E98B-6EBD-4B28-B7FD-480B6DF577C0@panic.com> <20150308175243.6848.qmail@stuge.se> <7DCB6E47-4409-45EA-A6A6-6BF58A4CBCD7@panic.com> <20150309144111.11800.qmail@stuge.se> Date: Tue, 10 Mar 2015 15:48:28 +0100 Message-ID: Subject: Re: Download libssh2 source via HTTPS? From: Tor Arntsen To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2AEmYwo012309 On 10 March 2015 at 13:10, Bill Segall wrote: > After the send-email some fraction of the developers engaged enough to be on > a mailing list might be motivated enough to download and have a look at a > patch but we've already presented a barrier to entry, cos it's not just > click to look. Actually, no. That's not what happens or how it works. Patches to the mailing list will a) hit the major group of developers, and b) be immediately visible and easily discussable. It is *more* accessible than a pull request from github. I can state this with confidence because that's what we have on the libcurl mailing list - repo on github, and we have both pull requests (which I see because my github account is connected to the repo), and normal patches posted to the mailing list. The latter is by far the most convenient. It's already been decided to move the libssh2 repo to github, and I'm not opposed to that at all. But to me the pull request feature (or just about all the rest of its features) is not what's good with github - what's good is simply that it's a reliable, fast, git remote repo. And that's really all. The rest I don't see much need for. -Tor _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Tue Mar 10 16:20:26 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2AFKFp6032150; Tue, 10 Mar 2015 16:20:22 +0100 Received: from goalkeeper.city-fan.org (pghmcfc-1-pt.tunnel.tserv5.lon1.ipv6.he.net [IPv6:2001:470:1f08:d97::2]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2AFKDsR032070 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2015 16:20:14 +0100 Received: from roary.micron.com (roary.uk.virtensys.com [86.15.121.9]) (authenticated bits=0) by goalkeeper.city-fan.org (8.15.1/8.15.1) with ESMTPSA id t2AFKCXu028282 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Tue, 10 Mar 2015 15:20:13 GMT Message-ID: <54FF0BAC.9080309@city-fan.org> Date: Tue, 10 Mar 2015 15:20:12 +0000 From: Paul Howarth User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: libssh2-devel@cool.haxx.se Subject: Re: The GitHub unicorn References: <109687106.rNUrHsPHZ7@nbkamil> <6E56E98B-6EBD-4B28-B7FD-480B6DF577C0@panic.com> <20150308175243.6848.qmail@stuge.se> <7DCB6E47-4409-45EA-A6A6-6BF58A4CBCD7@panic.com> <20150309144111.11800.qmail@stuge.se> <20150310124625.26103.qmail@stuge.se> In-Reply-To: <20150310124625.26103.qmail@stuge.se> X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2AFKFp6032150 Another data point for you all: as a downstream packager in Fedora (mainly lots of perl modules but also some other things, one of which is libssh2), I'm familiar with preparing and applying patches, and sending them upstream as and when appropriate. Given that I already have the patches I'm using downstream, I find that projects that exclusively use github are actually more of a hassle to contribute to (for an occasional contributor) because I need to fork the repo, apply my patch, push it back and create a pull request just to send my patch upstream, as opposed to a simple email with an attachment to the upstream maintainer/mailing list. I see that the github flow is an addition to the traditional flow rather than a replacement here - please keep it that way. Paul. _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Mar 11 08:17:28 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2B7H3Hj023387; Wed, 11 Mar 2015 08:17:25 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2B7H11h023229 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 11 Mar 2015 08:17:01 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t2B7H0Ka023222 for ; Wed, 11 Mar 2015 08:17:00 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Wed, 11 Mar 2015 08:17:00 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: [SECURITY ADVISORY] Using SSH_MSG_KEXINIT data unbounded Message-ID: User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2B7H3Hj023387 Using `SSH_MSG_KEXINIT` data unbounded ====================================== Project libssh2 Security Advisory, March 11th 2015 - [Permalink](http://www.libssh2.org/adv_20150311.html) VULNERABILITY ------------- When negotiating a new SSH session with a remote server, one of libssh2's functions for doing the key exchange (`kex_agree_methods()`) was naively reading data from the incoming packet and using it without doing sufficient range checks. The `SSH_MSG_KEXINIT` packet arrives to libssh2 with a set of strings, sent as a series of LENGTH + DATA pairs. libssh2 would go through the list and read the LENGTH field, read the string following the LENGTH and then advance the pointer LENGTH bytes in memory and expect to find the next LENGTH + DATA pair there. Then move on until seven subsequent strings are taken care of. It would naively assume that the (unsigned 32 bit) LENGTH fields were valid. This packet arrives in the negotiating phase so the remote server has not yet been deemed to be a known or trusted party. A malicious attacker could man in the middle a real server and cause libssh2 using clients to crash (denial of service) or otherwise read and use completely unintended memory areas in this process. There are no known exploits of this flaw at this time. INFO ---- The Common Vulnerabilities and Exposures (CVE) project has assigned the name CVE-2015-1782 to this issue. AFFECTED VERSIONS ----------------- - Affected versions: all versions to and including 1.4.3 - Not affected versions: libssh2 >= 1.5.0 libssh2 is used by many applications, but not always advertised as such! THE SOLUTION ------------ libssh2 1.5.0 makes sure that the LENGTH fields read from the packet fit within the received packet size before attempting to read them, or it fails graciously. A patch for this problem is available at: http://www.libssh2.org/CVE-2015-1782.patch RECOMMENDATIONS --------------- We suggest you take one of the following actions immediately, in order of preference: A - Upgrade to libssh2 1.5.0 B - Apply the patch and rebuild libssh2 TIME LINE --------- It was first reported to the libssh2 project on January 25 2015. We contacted distros@openwall on March 6. libssh2 1.5.0 was released on March 11th 2015, coordinated with the publication of this advisory. CREDITS ------- Reported by Mariusz Ziulek. Patch written by Mariusz Ziulek and Daniel Stenberg, Thanks a lot! -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Mar 11 08:19:55 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2B7JrUA029426; Wed, 11 Mar 2015 08:19:55 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2B7JqZM029419 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 11 Mar 2015 08:19:52 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t2B7JqOC029414 for ; Wed, 11 Mar 2015 08:19:52 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Wed, 11 Mar 2015 08:19:52 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: [RELEASE] libssh2 1.5.0 is released! Message-ID: User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="1129329158-595437267-1426058392=:11109" X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --1129329158-595437267-1426058392=:11109 Content-Type: TEXT/PLAIN; format=flowed; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT Hi all, I'm happy to announce a brand new libssh2 release, version 1.5.0 no less than 834 days since the previous one. You will of course find the new one at the usual place: http://www.libssh2.org/ Also pay special attention to the Security Advisory we release synchronized with this release. libssh2 1.5.0 ============= This release includes the following changes: o Added Windows Cryptography API: Next Generation based backend This release includes the following bugfixes: o Security Advisory for CVE-2015-1782, using SSH_MSG_KEXINIT data unbounded o missing _libssh2_error in _libssh2_channel_write o knownhost: Fix DSS keys being detected as unknown. o knownhost: Restore behaviour of `libssh2_knownhost_writeline` with short buffer. o libssh2.h: on Windows, a socket is of type SOCKET, not int o libssh2_priv.h: a 1 bit bit-field should be unsigned o windows build: do not export externals from static library o Fixed two potential use-after-frees of the payload buffer o Fixed a few memory leaks in error paths o userauth: Fixed an attempt to free from stack on error o agent_list_identities: Fixed memory leak on OOM o knownhosts: Abort if the hosts buffer is too small o sftp_close_handle: ensure the handle is always closed o channel_close: Close the channel even in the case of errors o docs: added missing libssh2_session_handshake.3 file o docs: fixed a bunch of typos o userauth_password: pass on the underlying error code o _libssh2_channel_forward_cancel: accessed struct after free o _libssh2_packet_add: avoid using uninitialized memory o _libssh2_channel_forward_cancel: avoid memory leaks on error o _libssh2_channel_write: client spins on write when window full o windows build: fix build errors o publickey_packet_receive: avoid junk in returned pointers o channel_receive_window_adjust: store windows size always o userauth_hostbased_fromfile: zero assign to avoid uninitialized use o configure: change LIBS not LDFLAGS when checking for libs o agent_connect_unix: make sure there's a trailing zero o MinGW build: Fixed redefine warnings. o sftpdir.c: added authentication method detection. o Watcom build: added support for WinCNG build. o configure.ac: replace AM_CONFIG_HEADER with AC_CONFIG_HEADERS o sftp_statvfs: fix for servers not supporting statfvs extension o knownhost.c: use LIBSSH2_FREE macro instead of free o Fixed compilation using mingw-w64 o knownhost.c: fixed that 'key_type_len' may be used uninitialized o configure: Display individual crypto backends on separate lines o examples on Windows: check for WSAStartup return code o examples on Windows: check for socket return code o agent.c: check return code of MapViewOfFile o kex.c: fix possible NULL pointer de-reference with session->kex o packet.c: fix possible NULL pointer de-reference within listen_state o tests on Windows: check for WSAStartup return code o userauth.c: improve readability and clarity of for-loops o examples on Windows: use native SOCKET-type instead of int o packet.c: i < 256 was always true and i would overflow to 0 o kex.c: make sure mlist is not set to NULL o session.c: check return value of session_nonblock in debug mode o session.c: check return value of session_nonblock during startup o userauth.c: make sure that sp_len is positive and avoid overflows o knownhost.c: fix use of uninitialized argument variable wrote o openssl: initialise the digest context before calling EVP_DigestInit() o libssh2_agent_init: init ->fd to LIBSSH2_INVALID_SOCKET o configure.ac: Add zlib to Requires.private in libssh2.pc if using zlib o configure.ac: Rework crypto library detection o configure.ac: Reorder --with-* options in --help output o configure.ac: Call zlib zlib and not libz in text but keep option names o Fix non-autotools builds: Always define the LIBSSH2_OPENSSL CPP macro o sftp: seek: Don't flush buffers on same offset o sftp: statvfs: Along error path, reset the correct 'state' variable. o sftp: Add support for fsync (OpenSSH extension). o _libssh2_channel_read: fix data drop when out of window o comp_method_zlib_decomp: Improve buffer growing algorithm o _libssh2_channel_read: Honour window_size_initial o window_size: redid window handling for flow control reasons o knownhosts: handle unknown key types This release would not have looked like this without help, code, reports and advice from friends like these: Alexander Lamaison, Bob Kast, Dan Fandrich, Daniel Stenberg, Guenter Knauf, Kamil Dudka, Leif Salomonsson, Marc Hörsken, Mark McPherson, Matthias Kerestesch, Mikhail Gusarov, Peter Stuge, Richard W.M. Jones, Salvador Fandino, Seth Willits, Mariusz Ziulek Thanks! (and sorry if I forgot to mention someone) -- / daniel.haxx.se --1129329158-595437267-1426058392=:11109 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --1129329158-595437267-1426058392=:11109-- From libssh2-devel-bounces@cool.haxx.se Wed Mar 11 10:49:10 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2B9ms8Q000396; Wed, 11 Mar 2015 10:49:08 +0100 Received: from mail-we0-x22b.google.com (mail-we0-x22b.google.com [IPv6:2a00:1450:400c:c03::22b]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2B9mnlF000321 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2015 10:48:50 +0100 Received: by wesu56 with SMTP id u56so7799248wes.12 for ; Wed, 11 Mar 2015 02:48:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qqmail.nl; s=google; h=from:to:references:in-reply-to:subject:date:message-id:mime-version :content-type:content-transfer-encoding:thread-index :content-language; bh=BoOYE/PalTGf5N2g5rrY8NOtrvaMsNMjiEXz+H0owNw=; b=FRdO8TYxn92XNf/mGPvluIbDC+4lbT1rXYlzl8o+FFC/zQ3LNSRNdQlNxbMwCPFflN AWyJwzl85QQv9ae9f7KlNN2r5pTTfep4RmQ0vD583i/BzOZfh5fMUc5QrDbpt9IJl4y6 0Q60xfz2jz/bEBNnPr5or58fAx59XnqlRcCLM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:references:in-reply-to:subject:date :message-id:mime-version:content-type:content-transfer-encoding :thread-index:content-language; bh=BoOYE/PalTGf5N2g5rrY8NOtrvaMsNMjiEXz+H0owNw=; b=TBtcE2kQ8oXH09BVKdj7H0WP7Y84/TrNUyZsvnzaed/FkXP1PXbkzJOfgifk03ICf6 G/4vGS0aEfgXg3yO3GQN8yn6FgTk3v2d/HUrleAYb8X6vs2ROAGbA1efbPoLd+BxdpVq 1c7sZwoY2HOu2MKbSHJBj0a4CjxQ0xUmSv+K8kS4nsYDZn7jfDjwL+LCXvdlMqIN1Bcc Cep5a2YhzUtLyxUGXwdIanyazk2xpqR+12xFcJHj5x3XOzIpidEZQR6YjoKHy0KeTQ+f Y74h0u/KDr3GmMBPHKhkWrP5G5J+NHhKUSuS3/7o8E1hQxnzLrXePGsyOEPubzNB2jP9 /bsQ== X-Gm-Message-State: ALoCoQnKTbj2cH0mptzFunZyABimAkiNIkiYKGtouQN5537ODa89f+Ok4VDhwD6rdnjUOo6eLkoS X-Received: by 10.194.177.167 with SMTP id cr7mr37844068wjc.19.1426067325463; Wed, 11 Mar 2015 02:48:45 -0700 (PDT) Received: from i72600 ([2001:610:66e:0:a1fe:7b28:1850:b511]) by mx.google.com with ESMTPSA id w4sm5324051wib.19.2015.03.11.02.48.44 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 11 Mar 2015 02:48:44 -0700 (PDT) From: "Bert Huijben" To: "'libssh2 development'" References: In-Reply-To: Subject: RE: [RELEASE] libssh2 1.5.0 is released! Date: Wed, 11 Mar 2015 10:48:40 +0100 Message-ID: <034901d05be0$8e846e70$ab8d4b50$@qqmail.nl> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQIOYzuq8t8/xSIhppolaaYpn3BDS5ya+ejA Content-Language: nl X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2B9ms8Q000396 > -----Original Message----- > From: libssh2-devel [mailto:libssh2-devel-bounces@cool.haxx.se] On Behalf Of > Daniel Stenberg > Sent: woensdag 11 maart 2015 08:20 > To: libssh2 development > Subject: [RELEASE] libssh2 1.5.0 is released! > > Hi all, > > I'm happy to announce a brand new libssh2 release, version 1.5.0 no less than > 834 days since the previous one. You will of course find the new one at the > usual place: http://www.libssh2.org/ The tag you created still thinks it is libssh2 1.4.4 development. But I think you already fixed that on MASTER for the next release. To avoid future problems it could be an idea to create an 1.5.x branch (to create patch releases from after merging fixes) and bump trunk directly through to 1.6.x. Bert _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Mar 11 10:56:45 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2B9ug2C012277; Wed, 11 Mar 2015 10:56:44 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2B9ueHG012272 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 11 Mar 2015 10:56:40 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t2B9ueIh012268 for ; Wed, 11 Mar 2015 10:56:40 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Wed, 11 Mar 2015 10:56:40 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: RE: [RELEASE] libssh2 1.5.0 is released! In-Reply-To: <034901d05be0$8e846e70$ab8d4b50$@qqmail.nl> Message-ID: References: <034901d05be0$8e846e70$ab8d4b50$@qqmail.nl> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2B9ug2C012277 On Wed, 11 Mar 2015, Bert Huijben wrote: > The tag you created still thinks it is libssh2 1.4.4 development. Yes. This is a side-effect of the version being done for the tarball by the maketgz script so the actual release-string is never used in the git repo. > But I think you already fixed that on MASTER for the next release. I bumped it for the next development period, yes. It is not a fix for the problem at the time of the next release... > To avoid future problems it could be an idea to create an 1.5.x branch (to > create patch releases from after merging fixes) and bump trunk directly > through to 1.6.x. That wouldn't fix this problem. To fix this particular problem I would have to change the header in git to say the correct version before I package the release. Is it really a problem to anyone though? The release is made with maketgz using the files in the git repo with the appropriate tag. The output tarball will have the correct version number in it. -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Mar 11 11:05:48 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2BA5f7B025318; Wed, 11 Mar 2015 11:05:47 +0100 Received: from mail-we0-x22b.google.com (mail-we0-x22b.google.com [IPv6:2a00:1450:400c:c03::22b]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2BA5d4b025234 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2015 11:05:39 +0100 Received: by wevl61 with SMTP id l61so7961964wev.6 for ; Wed, 11 Mar 2015 03:05:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qqmail.nl; s=google; h=from:to:references:in-reply-to:subject:date:message-id:mime-version :content-type:content-transfer-encoding:thread-index :content-language; bh=VHjNtQxseTxaqC6ORQ2M0EnyvVXy8YbCdty8m+rZqMk=; b=H5Xro7NbzBHrkIRhRVl7PkaimUSOtTxKDU+Yjd7Br/3nyFPIQl/TBvU38Z+VzX7akp T47NHcSUmKp7ZrJWCME7xif09F04HabanI0DfaobO5BBPmY6Bzq+Oa2XHKrOBz3o9DOR l8EpbAiZ77428uTYe31kTLwRzNbR7nkitJKVY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:references:in-reply-to:subject:date :message-id:mime-version:content-type:content-transfer-encoding :thread-index:content-language; bh=VHjNtQxseTxaqC6ORQ2M0EnyvVXy8YbCdty8m+rZqMk=; b=C34JPVCwLXk8qFb2wj+vh0tpefMhUhDs+ye4PLx0AWAVr/1Org0sPIlOrGXvaFdUyl rhVDINYiJosCitEcS/S0mSBwo0vCaQgFZiDmvJ8D2ajoelf8dDSlNAXVJOVt9OGiUFkm JqIfNsW5Q0oxz39uOBf/CXx30VisNVcLNWUIwEwiEMr3qcuiynw2siVrGoISmFGX/5HC TjCGRDo22/ZosJYt414fi6C7t4Vr+r25d+fFBs841qanVWgyQ7FDVX16AtCUiMHPNFB0 /I5BWt8a1Q36U3hKfNgRROKOV0lDRFFhJJ0NbWXCQRwPTeRzr9avtD44Za1ix6QtohCR 9xpQ== X-Gm-Message-State: ALoCoQnXIMRd6t8sl2m3PsoLkksU+MEKC12mLuzqpciGsae9WUPZJspo5mDillnuyJp9EUmPXr7C X-Received: by 10.180.102.234 with SMTP id fr10mr17730751wib.48.1426068335333; Wed, 11 Mar 2015 03:05:35 -0700 (PDT) Received: from i72600 ([2001:610:66e:0:a1fe:7b28:1850:b511]) by mx.google.com with ESMTPSA id u16sm4752415wjr.5.2015.03.11.03.05.33 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 11 Mar 2015 03:05:33 -0700 (PDT) From: "Bert Huijben" To: "'libssh2 development'" References: <034901d05be0$8e846e70$ab8d4b50$@qqmail.nl> In-Reply-To: Subject: RE: [RELEASE] libssh2 1.5.0 is released! Date: Wed, 11 Mar 2015 11:05:28 +0100 Message-ID: <034c01d05be2$e7e6e630$b7b4b290$@qqmail.nl> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQIOYzuq8t8/xSIhppolaaYpn3BDSwMzYE9wAjdS/r2cb6e8IA== Content-Language: nl X-MIME-Autoconverted: from quoted-printable to 8bit by giant.haxx.se id t2BA5d4b025234 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2BA5f7B025318 > -----Original Message----- > From: libssh2-devel [mailto:libssh2-devel-bounces@cool.haxx.se] On Behalf Of > Daniel Stenberg > Sent: woensdag 11 maart 2015 10:57 > To: libssh2 development > Subject: RE: [RELEASE] libssh2 1.5.0 is released! > > On Wed, 11 Mar 2015, Bert Huijben wrote: > > > The tag you created still thinks it is libssh2 1.4.4 development. > > Yes. This is a side-effect of the version being done for the tarball by the > maketgz script so the actual release-string is never used in the git repo. > > > But I think you already fixed that on MASTER for the next release. > > I bumped it for the next development period, yes. It is not a fix for the > problem at the time of the next release... > > > To avoid future problems it could be an idea to create an 1.5.x branch (to > > create patch releases from after merging fixes) and bump trunk directly > > through to 1.6.x. > > That wouldn't fix this problem. To fix this particular problem I would have to > change the header in git to say the correct version before I package the > release. > > Is it really a problem to anyone though? The release is made with maketgz > using the files in the git repo with the appropriate tag. The output tarball > will have the correct version number in it. It is a small problem to me (but I have to work around it for a few other packages as well). When I build packages for inclusion in SharpSvn and SharpGit, I run a tool that automatically adds their version control locations to the .pdb debug symbols. That way when somebody uses my debug symbols in Visual Studio, VS will just fetch the original sourcefiles directly from sourcecontrol when he/she steps through the code. So in most cases I try to build from source repositories instead of from tarballs, as tarballs don't have these sourcecontrol locations available. The slightly bigger problem is that it also affects the banner used for authentication to servers... 1.5.0 build from the tag will now identify as 1.4.4_dev, while 1.5.0_dev would be more accurate. If a server would have different behavior for different versions of libssh2, it would choose the wrong behavior. (But I think currently only some clients such as putty really use this behavior tweaking) Bert _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Mar 11 11:07:51 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2BA7nKK029515; Wed, 11 Mar 2015 11:07:51 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2BA7mxu029497 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 11 Mar 2015 11:07:48 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t2BA7luR029491 for ; Wed, 11 Mar 2015 11:07:47 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Wed, 11 Mar 2015 11:07:47 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: RE: [RELEASE] libssh2 1.5.0 is released! In-Reply-To: <034c01d05be2$e7e6e630$b7b4b290$@qqmail.nl> Message-ID: References: <034901d05be0$8e846e70$ab8d4b50$@qqmail.nl> <034c01d05be2$e7e6e630$b7b4b290$@qqmail.nl> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2BA7nKK029515 On Wed, 11 Mar 2015, Bert Huijben wrote: > The slightly bigger problem is that it also affects the banner used for > authentication to servers... 1.5.0 build from the tag will now identify as > 1.4.4_dev, while 1.5.0_dev would be more accurate. Right, I should've bumped the version the day I decided the next version would become 1.5.0. -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Mar 11 12:30:17 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2BBTxl7011130; Wed, 11 Mar 2015 12:30:14 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2BBTwdT011117 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 11 Mar 2015 12:29:58 +0100 Received: (qmail 2973 invoked from network); 11 Mar 2015 11:33:09 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 11 Mar 2015 11:33:09 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software To: mzet@owasp.org, daniel@haxx.se X-Trac-Project: libssh2 Date: Wed, 11 Mar 2015 11:33:09 -0000 X-URL: https://trac.libssh2.org/ Subject: Re: [libssh2] #294: DoS condition: read from unmapped memory region causes libssh2 to crash X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/294#comment:1 Message-ID: <056.8435d3085936535ff55303fb626c4888@libssh2.stuge.se> References: <041.8802528337a07a3a2631f04dc8cb92f0@libssh2.stuge.se> X-Trac-Ticket-ID: 294 In-Reply-To: <041.8802528337a07a3a2631f04dc8cb92f0@libssh2.stuge.se> X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2BBTwdT011117 Cc: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: trac@libssh2.stuge.se, libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2BBTxl7011130 #294: DoS condition: read from unmapped memory region causes libssh2 to crash -----------------------+---------------------- Reporter: mzet | Owner: Type: defect | Status: closed Priority: high | Milestone: 1.5.0 Component: protocol | Version: Resolution: fixed | Keywords: security Blocked By: | Blocks: -----------------------+---------------------- Changes (by bagder): * status: new => closed * resolution: => fixed * milestone: 1.4.3 => 1.5.0 Comment: This is fixed in the 1.5.0 release, the security advisory is found here: http://libssh2.org/adv_20150311.html -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Mar 11 18:42:15 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2BHfnUL024927; Wed, 11 Mar 2015 18:42:08 +0100 Received: from mail-lb0-x22e.google.com (mail-lb0-x22e.google.com [IPv6:2a00:1450:4010:c04::22e]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2BHflI5021753 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2015 18:41:47 +0100 Received: by lbiz12 with SMTP id z12so10517818lbi.12 for ; Wed, 11 Mar 2015 10:41:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=ZjBr0Kpjv868uGKwu+rIjB6siROZH2JBW9A/wkB/2N4=; b=UmP+r7mEQF/Wxz0Y5Ad6gaRayWUIeujZLNUmASym6oN5IuYofGUL8qo+kYgRX5sq2N 01n88MWIn1vskgc8McjvFzknCt54rWfuhHTaAyh3T5HJuFgyQa5tWgzCDvOJNNLqVXvL gUPiQt9EyHjjXHbBO6y9/WOYkfNgEjr1xLxpjbMulLMCtuBfuCBFyNdX3QntZh52K/sV TLTgJJupWXES/yIGPfrbKNApu4fDNz2S+XwcZRsd3fVwIT/v3FkqKQamXT60j5RZo/bL l0J4TIfyjwli0jNrgLRzWCX/VIrwUBdhlSNv5p/1Ei2WZAPs1u+Y+lis4uEIXoZxB6uB dAwQ== MIME-Version: 1.0 X-Received: by 10.153.7.69 with SMTP id da5mr35863937lad.108.1426095703249; Wed, 11 Mar 2015 10:41:43 -0700 (PDT) Received: by 10.25.28.129 with HTTP; Wed, 11 Mar 2015 10:41:42 -0700 (PDT) Received: by 10.25.28.129 with HTTP; Wed, 11 Mar 2015 10:41:42 -0700 (PDT) In-Reply-To: <804C94F3-820C-4FF1-B06D-A1AB2E91FF92@eggerapps.at> References: <804C94F3-820C-4FF1-B06D-A1AB2E91FF92@eggerapps.at> Date: Wed, 11 Mar 2015 17:41:42 +0000 X-Google-Sender-Auth: Pb39fphhYh_pkGjBqasg7DtBjsA Message-ID: Subject: Re: git repo on github From: Alexander Lamaison To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============0517304628==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============0517304628== Content-Type: multipart/alternative; boundary=001a11345630ced987051106c7c9 --001a11345630ced987051106c7c9 Content-Type: text/plain; charset=UTF-8 On 10 Mar 2015 13:27, "Jakob Egger" wrote: > > Hi Daniel, > > What do you think about creating a Github "organization" for libssh2? +1 This would also leave you, Daniel, free to use bagder/libssh2 as a staging area for your own contributions and experiments. Alex --001a11345630ced987051106c7c9 Content-Type: text/html; charset=UTF-8

On 10 Mar 2015 13:27, "Jakob Egger" <jakob@eggerapps.at> wrote:
>
> Hi Daniel,
>
> What do you think about creating a Github "organization" for libssh2?

+1

This would also leave you, Daniel, free to use bagder/libssh2 as a staging area for your own contributions and experiments.

Alex

--001a11345630ced987051106c7c9-- --===============0517304628== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============0517304628==-- From libssh2-devel-bounces@cool.haxx.se Wed Mar 11 18:52:32 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2BHqR2o014197; Wed, 11 Mar 2015 18:52:31 +0100 Received: from mail-lb0-x22e.google.com (mail-lb0-x22e.google.com [IPv6:2a00:1450:4010:c04::22e]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2BHqRhO014094 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2015 18:52:27 +0100 Received: by lbjf15 with SMTP id f15so10614056lbj.2 for ; Wed, 11 Mar 2015 10:52:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=GnOpzD+FUL518Wn8rLyfJ0czMFIpf6eztiHiHRaOxzI=; b=pT5fyCJreNejAh+PcCpdL47yfW30mupZ/2V1umP8O1ZGk7bFwg4CFvJAYbIxCVIbkY pm9HMu0aFO7tNEWBfNoaKdcuT8YowNM3c7jksxrfeNI2JokRc7DEMmilLf7naigGm4j1 aFnyPJdGQyCsS4/Q9C4pu320KZPHzxe7APw6SYEziQ/ZtqZsYwv/1PtrKqE4uDvu+t8X JaVj9nKrIVikoJ5LPB3u4hwwH1dKS+5QShKLJ1VOoxdfSJSA8iIM5RltLKO8UmKuj3k3 3RiAZxpPc2XPl5Lf+qx1sQxKmzeE06ahnDamHSvt8Hxo0xRDHz6jKRp8eWXmOSAy4Rxf 4Jew== MIME-Version: 1.0 X-Received: by 10.153.7.69 with SMTP id da5mr35901696lad.108.1426096343374; Wed, 11 Mar 2015 10:52:23 -0700 (PDT) Received: by 10.25.28.129 with HTTP; Wed, 11 Mar 2015 10:52:23 -0700 (PDT) Received: by 10.25.28.129 with HTTP; Wed, 11 Mar 2015 10:52:23 -0700 (PDT) In-Reply-To: References: <109687106.rNUrHsPHZ7@nbkamil> <6E56E98B-6EBD-4B28-B7FD-480B6DF577C0@panic.com> <20150308175243.6848.qmail@stuge.se> <7DCB6E47-4409-45EA-A6A6-6BF58A4CBCD7@panic.com> <20150309144111.11800.qmail@stuge.se> Date: Wed, 11 Mar 2015 17:52:23 +0000 X-Google-Sender-Auth: smWTr9LdFde11yfWuCmh-gRuI8k Message-ID: Subject: Re: Download libssh2 source via HTTPS? From: Alexander Lamaison To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============1602241731==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============1602241731== Content-Type: multipart/alternative; boundary=001a11345630f66097051106eda5 --001a11345630f66097051106eda5 Content-Type: text/plain; charset=UTF-8 On 10 Mar 2015 14:49, "Tor Arntsen" wrote: > > On 10 March 2015 at 13:10, Bill Segall wrote: > > > After the send-email some fraction of the developers engaged enough to be on > > a mailing list might be motivated enough to download and have a look at a > > patch but we've already presented a barrier to entry, cos it's not just > > click to look. > > Actually, no. That's not what happens or how it works. Patches to the > mailing list will a) hit the major group of developers, and b) be > immediately visible and easily discussable. It is *more* accessible > than a pull request from github. I can state this with confidence > because that's what we have on the libcurl mailing list - repo on > github, and we have both pull requests (which I see because my github > account is connected to the repo), and normal patches posted to the > mailing list. The latter is by far the most convenient. > It's already been decided to move the libssh2 repo to github, and I'm > not opposed to that at all. But to me the pull request feature (or > just about all the rest of its features) is not what's good with > github - what's good is simply that it's a reliable, fast, git remote > repo. And that's really all. The rest I don't see much need for. Maybe that's how the curl mailing list works but it's not so good for libssh2. Contributed patches either get an immediate response (great) or they are forgotten. Noone (except Daniel sometimes when he must have had a lot of coffee) takes the trouble to look back through the mailing list and find forgotten patches. Trac is a little better because you can't 'lose' tickets. Github improves things a bit by separating bug reports from pull requests. It's easy to ignore bug reports because they are problems requiring investigation and time. But pull requests are harder to forget because they represent a *solution* waiting for approval. Github puts these in your face every time you visit the project page. Nothing is a silver bullet, but anything increasing our chances of a good thing. Alex --001a11345630f66097051106eda5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On 10 Mar 2015 14:49, "Tor Arntsen" <kspt.tor@gmail.com> wrote:
>
> On 10 March 2015 at 13:10, Bill Segall <bill@segall.net> wrote:
>
> > After the send-email some fraction of the developers engaged enou= gh to be on
> > a mailing list might be motivated enough to download and have a l= ook at a
> > patch but we've already presented a barrier to entry, cos it&= #39;s not just
> > click to look.
>
> Actually, no. That's not what happens or how it works. Patches to = the
> mailing list will a) hit the major group of developers, and b) be
> immediately visible and easily discussable. It is *more* accessible > than a pull request from github. I can state this with confidence
> because that's what we have on the libcurl mailing list - repo on<= br> > github, and we have both pull requests (which I see because my github<= br> > account is connected to the repo), and normal patches posted to the > mailing list. The latter is by far the most convenient.
> It's already been decided to move the libssh2 repo to github, and = I'm
> not opposed to that at all. But to me the pull request feature (or
> just about all the rest of its features) is not what's good with > github - what's good is simply that it's a reliable, fast, git= remote
> repo. And that's really all. The rest I don't see much need fo= r.

Maybe that's how the curl mailing list works but it'= s not so good for libssh2. Contributed patches either get an immediate resp= onse (great) or they are forgotten. Noone (except Daniel sometimes when he = must have had a lot of coffee) takes the trouble to look back through the m= ailing list and find forgotten patches. Trac is a little better because you= can't 'lose' tickets.

Github improves things a bit by separating bug reports from = pull requests. It's easy to ignore bug reports because they are problem= s requiring investigation and time. But pull requests are harder to forget = because they represent a *solution* waiting for approval. Github puts these= in your face every time you visit the project page.

Nothing is a silver bullet, but anything increasing our chan= ces of a good thing.

Alex

--001a11345630f66097051106eda5-- --===============1602241731== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============1602241731==-- From libssh2-devel-bounces@cool.haxx.se Wed Mar 11 22:40:28 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2BLe5Ul001751; Wed, 11 Mar 2015 22:40:23 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2BLe3Rk001661 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 11 Mar 2015 22:40:03 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t2BLe3Bl001657 for ; Wed, 11 Mar 2015 22:40:03 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Wed, 11 Mar 2015 22:40:03 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: Re: git repo on github In-Reply-To: Message-ID: References: <804C94F3-820C-4FF1-B06D-A1AB2E91FF92@eggerapps.at> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2BLe5Ul001751 On Wed, 11 Mar 2015, Alexander Lamaison wrote: > This would also leave you, Daniel, free to use bagder/libssh2 as a staging > area for your own contributions and experiments. Fair enough! https://github.com/libssh2 is now our new organization hub at github. I've invited a bunch of you to join the org and the "teams" I've setup so far. -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Mar 12 01:03:04 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2C02hWG021708; Thu, 12 Mar 2015 01:03:02 +0100 Received: from foo.stuge.se (qmailr@foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2C02fD1021698 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 12 Mar 2015 01:02:41 +0100 Received: (qmail 32182 invoked by uid 501); 12 Mar 2015 00:02:43 -0000 Message-ID: <20150312000243.32181.qmail@stuge.se> Date: Thu, 12 Mar 2015 01:02:43 +0100 From: Peter Stuge To: libssh2-devel@cool.haxx.se Subject: Re: Download libssh2 source via HTTPS? Mail-Followup-To: libssh2-devel@cool.haxx.se References: <109687106.rNUrHsPHZ7@nbkamil> <6E56E98B-6EBD-4B28-B7FD-480B6DF577C0@panic.com> <20150308175243.6848.qmail@stuge.se> <7DCB6E47-4409-45EA-A6A6-6BF58A4CBCD7@panic.com> <20150309144111.11800.qmail@stuge.se> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2C02hWG021708 Alexander Lamaison wrote: > pull requests are harder to forget because they represent a *solution* > waiting for approval. In theory all patches are. In practise, I find it's rarely so simple. //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Mar 12 01:35:39 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2C0ZXRg004058; Thu, 12 Mar 2015 01:35:38 +0100 Received: from mail-yh0-x231.google.com (mail-yh0-x231.google.com [IPv6:2607:f8b0:4002:c01::231]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2C0ZVp4004041 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2015 01:35:31 +0100 Received: by yhot59 with SMTP id t59so6507062yho.7 for ; Wed, 11 Mar 2015 17:35:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=eIA8rFrT/hoK5ubCQPsM/i4h0wVhrmjUQ/e5d2uSORk=; b=kyX18M/gceLtlK/b0ijR+aSgOVV7h7jb37QGSbNiN5ADA5svvk1HtjHDbgI4Mspxip KsWH2zDCCu/Z8MKnstzjbBoWi5M9a8x89dOFnVr3BehGVhqGolSUhURGN09m3wgDy8hf GMC6l0EhsOnkaNvY5eiqZMWLDqsCQEuspI3rev+7HmRxnrsiTpfvmqoueXez7Sw5A+4L AIhwbAZi2VOaT3ZoGBfWNVibs+nwuIivbbD60YbHMzuCg6O6fH9Mhc7gXcnVRmB1jN95 vSMe/BnCuhN+mEue1pFcVg9xn9/gypAWXFuMKXWQks+0uWiCtVkf0Mll9irfgOYXKKOk cyKA== X-Received: by 10.170.100.87 with SMTP id r84mr44077626yka.73.1426120526672; Wed, 11 Mar 2015 17:35:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.170.213.86 with HTTP; Wed, 11 Mar 2015 17:35:06 -0700 (PDT) From: Sagar Chandawale Date: Wed, 11 Mar 2015 17:35:06 -0700 Message-ID: Subject: New to libssh2: LIBSSH2_ERROR_EAGAIN error To: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============0026107336==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============0026107336== Content-Type: multipart/alternative; boundary=001a113b29126637d905110c8ffe --001a113b29126637d905110c8ffe Content-Type: text/plain; charset=UTF-8 Hello, Spent a few days to get the libssh2 VS2010 solution build successfully on a Windows 7 machine and trying to use examples to understand the operation. I am using the "ssh2_echo" example to connect to the Linux PC and simply return the "ls -l" output back. I tried multiple examples and I see that I am getting stuck at the libssh2_session_handshake(session, sock) function where it returns a LIBSSH2_ERROR_EAGAIN (-37) just in the 2nd iteration. I have looked up the documentation but cannot find a resolution. Just FYI, I am able to connect to the Linux PC with PuTTY client. Sorry if this is an ultra basic question, but any help is highly appreciated! Thanks, sa-cha --001a113b29126637d905110c8ffe Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hello,

Spent a few days to get the libs= sh2 VS2010 solution build successfully on a Windows 7 machine and trying to= use examples to understand the operation.

I am us= ing the "ssh2_echo" example to connect to the Linux PC and simply= return the "ls -l" output back. I tried multiple examples and I = see that I am getting stuck at the=C2=A0libssh2_session_handshake(session, = sock) function where it returns a LIBSSH2_ERROR_EAGAIN (-37) just in the 2n= d iteration.=C2=A0

I have looked up the documentat= ion but cannot find a resolution. Just FYI, I am able to connect to the Lin= ux PC with PuTTY client.

Sorry if this is an ultra= basic question, but any help is highly appreciated!=C2=A0

Thanks,
sa-cha
--001a113b29126637d905110c8ffe-- --===============0026107336== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============0026107336==-- From libssh2-devel-bounces@cool.haxx.se Thu Mar 12 11:39:35 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2CAdDB4015053; Thu, 12 Mar 2015 11:39:32 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2CAdC3k014973 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 12 Mar 2015 11:39:12 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t2CAdCvs014969 for ; Thu, 12 Mar 2015 11:39:12 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Thu, 12 Mar 2015 11:39:12 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: 'watch' libssh2 on github Message-ID: User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2CAdDB4015053 Hi! I just wanted to point out to everyone, especially if you're not used to working with projects on github, that you may want to click "watch" or at least "star" the libssh2 source code repo: https://github.com/libssh2/libssh2 Doing so will get you notified when things happen there. Like new pull requests etc. -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Mar 12 15:58:31 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2CEw8lf020463; Thu, 12 Mar 2015 15:58:26 +0100 Received: from mail.panic.com (posh.panic.com [38.103.165.4]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2CEvn9j020221 for ; Thu, 12 Mar 2015 15:57:50 +0100 Received: from [10.0.1.18] (c-76-115-128-120.hsd1.or.comcast.net [76.115.128.120]) by mail.panic.com (Postfix) with ESMTPSA id 5272FB7775ED for ; Thu, 12 Mar 2015 07:57:40 -0700 (PDT) From: Will Cosgrove Mime-Version: 1.0 (1.0) Date: Thu, 12 Mar 2015 07:57:39 -0700 Message-Id: <2258ED7C-F129-45D4-A3B9-64AAB82583F1@panic.com> Subject: Re: 'watch' libssh2 on github References: In-Reply-To: To: libssh2 development X-Mailer: iPhone Mail (12D508) X-MIME-Autoconverted: from quoted-printable to 8bit by giant.haxx.se id t2CEvn9j020221 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2CEw8lf020463 Thanks for doing all the leg work on this, it is appreciated. As time allows I will be committing some of the updates we've made over the years, but I was wondering what to do about commits that break binary compatibility. Should we (you?) create a 1.6 branch to commit bigger changes to? For example, the known hosts error values I submitted yesterday could live there. Furthermore, I have sha256 kex support but is also binary incompatible. Thoughts? Will > On Mar 12, 2015, at 3:39 AM, Daniel Stenberg wrote: > > Hi! > > I just wanted to point out to everyone, especially if you're not used to working with projects on github, that you may want to click "watch" or at least "star" the libssh2 source code repo: > > https://github.com/libssh2/libssh2 > > Doing so will get you notified when things happen there. Like new pull requests etc. > > -- > > / daniel.haxx.se > _______________________________________________ > libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Mar 12 16:16:54 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2CFGliD017238; Thu, 12 Mar 2015 16:16:53 +0100 Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2CFGjmr017162 for ; Thu, 12 Mar 2015 16:16:46 +0100 Received: from OwnerPC311012 (unknown [203.202.164.190]) (Authenticated sender: sisyphus1@optusnet.com.au) by mail104.syd.optusnet.com.au (Postfix) with ESMTPA id 39D47425050 for ; Fri, 13 Mar 2015 02:16:34 +1100 (AEDT) Message-ID: <9CC4F5E65A1F47DFB4C5326712CD50A0@OwnerPC311012> From: To: Subject: [Win32] undefined reference Date: Fri, 13 Mar 2015 02:15:51 +1100 MIME-Version: 1.0 X-Priority: 3 X-MSMail-Priority: Normal Importance: Normal X-Mailer: Microsoft Windows Live Mail 16.4.3505.912 X-MimeOLE: Produced By Microsoft MimeOLE V16.4.3505.912 X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.1 cv=Za4kaKlA c=1 sm=1 tr=0 a=8e8rgZJuizJfF74+JHJpGg==:117 a=8e8rgZJuizJfF74+JHJpGg==:17 a=PO7r1zJSAAAA:8 a=8nJEP1OIZ-IA:10 a=UCSSrT8CIOLZdyGzTa0A:9 a=wPNLvfGTeEIA:10 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2CFGliD017238 Hi, Using a mingw-w64 port of 64-bit gcc-4.8.2 I've built static openssl-1.0.2, and then built a static libssh2-1.5.0 against that openssl library. But when I try to build against that libssh2-1.5.0 library I get hit with: C:\_64\msys\1.0\local\lib\libssh2.a(misc.o):misc.c:(.text+0x40): undefined reference to `__ms_vsnprintf' C:\_64\msys\1.0\local\lib\libssh2.a(scp.o):scp.c:(.text+0x40): undefined reference to `__ms_vsnprintf' What do I need to link to here in order to resolve that ? I've gone through the same process using a mingw-w64 port of *32-bit* gcc-4.8.2 and everything works fine - though I think the 32-bit libssh2.a also contains the same '__ms_vsnprintf' reference. Cheers, Rob _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Mar 12 16:44:18 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2CFiABL031282; Thu, 12 Mar 2015 16:44:17 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2CFi9Rg031248 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 12 Mar 2015 16:44:09 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t2CFi8RR031244 for ; Thu, 12 Mar 2015 16:44:08 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Thu, 12 Mar 2015 16:44:08 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: breaking the ABI (was Re: 'watch' libssh2 on github) In-Reply-To: <2258ED7C-F129-45D4-A3B9-64AAB82583F1@panic.com> Message-ID: References: <2258ED7C-F129-45D4-A3B9-64AAB82583F1@panic.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2CFiABL031282 On Thu, 12 Mar 2015, Will Cosgrove wrote: > As time allows I will be committing some of the updates we've made over the > years, but I was wondering what to do about commits that break binary > compatibility. Should we (you?) create a 1.6 branch to commit bigger > changes to? For example, the known hosts error values I submitted yesterday > could live there. I have some opinions on the matter. I don't think we should take breaking the ABI easily. We should only break it if we REALLY need to. Applications and distros don't like it - understandably. Users will like us more knowing that we have a solid API and ABI. Then, I think each potential breakage should be discussed here to see what to do about it. Maybe we can come up with a way that won't break existing apps? Maybe we deem the new think not worth breaking the ABI. Maybe we think the idea is worth bumping the soname for! The known host error code change you posted (https://github.com/libssh2/libssh2/pull/3) is in the category I would qualify as nice-to-do but not needed enough to break the ABI due to this. So once we do get a bigger change we think it _is_ worth breaking the ABI for we can merge that change too. I don't think we should branch off anything at this point since maintaining several branches is a lot of work. > Furthermore, I have sha256 kex support but is also binary incompatible. How and why is that binary incompatible? -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Mar 12 17:01:14 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2CG105l010416; Thu, 12 Mar 2015 17:01:12 +0100 Received: from mail.panic.com (posh.panic.com [38.103.165.4]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2CG0w8Q010397 for ; Thu, 12 Mar 2015 17:00:59 +0100 Received: from [10.0.0.94] (unknown [38.103.165.36]) by mail.panic.com (Postfix) with ESMTPSA id 2DA01B7794EF for ; Thu, 12 Mar 2015 09:00:54 -0700 (PDT) Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: breaking the ABI (was Re: 'watch' libssh2 on github) From: Will Cosgrove In-Reply-To: Date: Thu, 12 Mar 2015 09:00:53 -0700 Message-Id: <3742F847-D778-43D0-ADA6-B657C81463CF@panic.com> References: <2258ED7C-F129-45D4-A3B9-64AAB82583F1@panic.com> To: libssh2 development X-Mailer: Apple Mail (2.2070.6) X-MIME-Autoconverted: from quoted-printable to 8bit by giant.haxx.se id t2CG0w8Q010397 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2CG105l010416 > >> Furthermore, I have sha256 kex support but is also binary incompatible. > > How and why is that binary incompatible? In kmdhgGPsha1kex_state_t, I changed the following: 1) h_sig_comp to be size of MAX_SHA_DIGEST_LENGTH (which I defined to be SHA256 digest length at the moment) 2) changed exchange_hash to be a void* instead of a libssh2_sha1_ctx to not be sha1 specific. I also renamed kmdhgGPsha1kex_state_t to kmdhgGPshakex_state_t. As for the known_hosts error values, in the future I would strongly encourage the use of unique error codes going forward. Writing end-user applications rely on unique error codes to generate meaningful user error strings to present to the user. Will _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Mar 12 18:42:50 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2CHgUXB021647; Thu, 12 Mar 2015 18:42:47 +0100 Received: from mail-lb0-x233.google.com (mail-lb0-x233.google.com [IPv6:2a00:1450:4010:c04::233]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2CHgSCj021529 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 12 Mar 2015 18:42:28 +0100 Received: by lbvp9 with SMTP id p9so17624826lbv.10 for ; Thu, 12 Mar 2015 10:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=orBDI/j5xfd5sxcYMsNYwjuYA1D6P7STHE4Xmd2WWyo=; b=ikENEUazq1YFD1J3qVNTo4Sj90JsDHjEutSmY/NYcWBrrJDQt9J8AWSJyB5jk9Gqse lKSYqmO2yusuFDhHl7u/hWMX8fuW2Kri7L7CK3DqnJfQqnYVeDYck0RSI8Ro6GkQvCgr MyVhEjKU3zIGpr3UmCZG7Zq5HQlSnWfkNMj+N6ApFmv6UsoDzqPdadGWApc/2+iHeWV3 tD9InpNasJ0je9/4gbEkAN6X9OVTA9Lt6d/ajrQXdC1Xy7zDtRwAm9ZOZD8PPVYBsELr wLqBkDBL9COF1SuiPZT+6rlTSY7/E3g3yAnDgSrYjkByFKuGYFVJvBpp5Cknjr/px6GC 8wZw== MIME-Version: 1.0 X-Received: by 10.153.7.69 with SMTP id da5mr40318554lad.108.1426182144990; Thu, 12 Mar 2015 10:42:24 -0700 (PDT) Received: by 10.25.28.129 with HTTP; Thu, 12 Mar 2015 10:42:24 -0700 (PDT) Received: by 10.25.28.129 with HTTP; Thu, 12 Mar 2015 10:42:24 -0700 (PDT) In-Reply-To: <9CC4F5E65A1F47DFB4C5326712CD50A0@OwnerPC311012> References: <9CC4F5E65A1F47DFB4C5326712CD50A0@OwnerPC311012> Date: Thu, 12 Mar 2015 17:42:24 +0000 X-Google-Sender-Auth: XkO7E1DFP2idn_rHP6dkj-XsMbo Message-ID: Subject: Re: [Win32] undefined reference From: Alexander Lamaison To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============1045383359==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============1045383359== Content-Type: multipart/alternative; boundary=001a1134563023257b05111ae80b --001a1134563023257b05111ae80b Content-Type: text/plain; charset=UTF-8 On 12 Mar 2015 15:17, wrote: > > Hi, > > Using a mingw-w64 port of 64-bit gcc-4.8.2 I've built static openssl-1.0.2, and then built a static libssh2-1.5.0 against that openssl library. > But when I try to build against that libssh2-1.5.0 library I get hit with: > > C:\_64\msys\1.0\local\lib\libssh2.a(misc.o):misc.c:(.text+0x40): undefined reference to `__ms_vsnprintf' > C:\_64\msys\1.0\local\lib\libssh2.a(scp.o):scp.c:(.text+0x40): undefined reference to `__ms_vsnprintf' > > What do I need to link to here in order to resolve that ? I'm not near a computer so can't double check, but those look like CRT functions to me. I'm guessing you built libssh2 to use the static MSVCRT, but you've built your main program against a different CRT version. The versions need to match. Alex --001a1134563023257b05111ae80b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On 12 Mar 2015 15:17, <sisyphus1@optusnet.com.au> wrote:
>
> Hi,
>
> Using a mingw-w64 port of 64-bit gcc-4.8.2 I've built static opens= sl-1.0.2, and then built a static libssh2-1.5.0 against that openssl librar= y.
> But when I try to build against that libssh2-1.5.0 library I get hit w= ith:
>
> C:\_64\msys\1.0\local\lib\libssh2.a(misc.o):misc.c:(.text+0x40): undef= ined reference to `__ms_vsnprintf'
> C:\_64\msys\1.0\local\lib\libssh2.a(scp.o):scp.c:(.text+0x40): undefin= ed reference to `__ms_vsnprintf'
>
> What do I need to link to here in order to resolve that ?

I'm not near a computer so can't double check, but t= hose look like CRT functions to me. I'm guessing you built libssh2 to u= se the static MSVCRT, but you've built your main program against a diff= erent CRT version. The versions need to match.

Alex

--001a1134563023257b05111ae80b-- --===============1045383359== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============1045383359==-- From libssh2-devel-bounces@cool.haxx.se Fri Mar 13 00:02:32 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2CN27jh004936; Fri, 13 Mar 2015 00:02:27 +0100 Received: from mail-lb0-x229.google.com (mail-lb0-x229.google.com [IPv6:2a00:1450:4010:c04::229]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2CN24rj004792 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2015 00:02:05 +0100 Received: by lbdu10 with SMTP id u10so19268578lbd.4 for ; Thu, 12 Mar 2015 16:02:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=xCSqyQEDwhn5FmhqwbYTxyNKPGqqRk2rpPexBjk/LiY=; b=hiuM5uXRv3CI2difjTtkrsTeyp72tQWyxmaVN1vyHeLQcbP1j1gKwJLahwK4YUrnTe mgMi03G8uLhh/ByMOd9qcovQHbGL6hVqSoyRhVcCZQdZR8J43CGkIXMmsO2Wo6/55OaK I++uGFTqIrKcjfR6yGp+FauJFhuobJPsLTqA0h9niOKvmagWaeS6NNGDiqMXy7+O0PS6 qmkqyQqy+YX02u5w4GthNxXxs8x0OT8IDd6JXUFXx2SUrNZSxUErQ2HaRt4FtecqTgJd IcEM3nxAwvoaWJHW/RPNRbEiJpX+OXnvWXODJws6InWiRhWd7lwltr3YXQSlupYHWMfo +GcQ== MIME-Version: 1.0 X-Received: by 10.153.7.69 with SMTP id da5mr41304791lad.108.1426201321541; Thu, 12 Mar 2015 16:02:01 -0700 (PDT) Received: by 10.25.28.129 with HTTP; Thu, 12 Mar 2015 16:02:01 -0700 (PDT) In-Reply-To: References: <548DDCF8.9040705@marc-hoersken.de> <66485C8C-C577-4A75-9E9E-8F36F06B7836@marc-hoersken.de> Date: Thu, 12 Mar 2015 23:02:01 +0000 X-Google-Sender-Auth: 4sU-tm1lNWzFktoKTx7TYzWg8JI Message-ID: Subject: Re: CMake From: Alexander Lamaison To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2CN27jh004936 Any objections if I merge the CMake build system into master? https://github.com/libssh2/libssh2/pull/8 Alex _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Fri Mar 13 00:03:46 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2CN3jfr008933; Fri, 13 Mar 2015 00:03:46 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2CN3hTv008926 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 13 Mar 2015 00:03:43 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t2CN3hv5008923 for ; Fri, 13 Mar 2015 00:03:43 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Fri, 13 Mar 2015 00:03:43 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: Re: CMake In-Reply-To: Message-ID: References: <548DDCF8.9040705@marc-hoersken.de> <66485C8C-C577-4A75-9E9E-8F36F06B7836@marc-hoersken.de> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2CN3jfr008933 On Thu, 12 Mar 2015, Alexander Lamaison wrote: > Any objections if I merge the CMake build system into master? > https://github.com/libssh2/libssh2/pull/8 None from me! It is time to get it in so that we can polish it and feel it out etc. -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Fri Mar 13 00:13:17 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2CNDC0a025234; Fri, 13 Mar 2015 00:13:16 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2CNDAkq025229 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 13 Mar 2015 00:13:10 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t2CNDA1d025226 for ; Fri, 13 Mar 2015 00:13:10 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Fri, 13 Mar 2015 00:13:10 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: Re: breaking the ABI (was Re: 'watch' libssh2 on github) In-Reply-To: <3742F847-D778-43D0-ADA6-B657C81463CF@panic.com> Message-ID: References: <2258ED7C-F129-45D4-A3B9-64AAB82583F1@panic.com> <3742F847-D778-43D0-ADA6-B657C81463CF@panic.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2CNDC0a025234 On Thu, 12 Mar 2015, Will Cosgrove wrote: > In kmdhgGPsha1kex_state_t, I changed the following: Ok, but I don't see how any of those changes cause any breaking change. They're internal and hidden from users so unless I'm missing something they're totally fine and benign. > As for the known_hosts error values, in the future I would strongly > encourage the use of unique error codes going forward. Writing end-user > applications rely on unique error codes to generate meaningful user error > strings to present to the user. But they're different error codes, they're not in a single number range. I will agree though that it is generally more convenient for everyone to keep the error codes in the same range even for different functions. However, I don't think exposing our return codes will be helpful to very many users... -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Fri Mar 13 00:31:14 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2CNV9IK010531; Fri, 13 Mar 2015 00:31:13 +0100 Received: from mail.panic.com (posh.panic.com [38.103.165.4]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2CNV7pm010483 for ; Fri, 13 Mar 2015 00:31:07 +0100 Received: from [10.0.0.94] (unknown [38.103.165.36]) by mail.panic.com (Postfix) with ESMTPSA id 2BD66B782420 for ; Thu, 12 Mar 2015 16:31:03 -0700 (PDT) Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: breaking the ABI (was Re: 'watch' libssh2 on github) From: Will Cosgrove In-Reply-To: Date: Thu, 12 Mar 2015 16:31:02 -0700 Message-Id: <98F1EA0C-6548-4752-B9DA-DDA415B28FEB@panic.com> References: <2258ED7C-F129-45D4-A3B9-64AAB82583F1@panic.com> <3742F847-D778-43D0-ADA6-B657C81463CF@panic.com> To: libssh2 development X-Mailer: Apple Mail (2.2070.6) X-MIME-Autoconverted: from quoted-printable to 8bit by giant.haxx.se id t2CNV7pm010483 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2CNV9IK010531 > On Thu, 12 Mar 2015, Will Cosgrove wrote: > >> In kmdhgGPsha1kex_state_t, I changed the following: > > Ok, but I don't see how any of those changes cause any breaking change. They're internal and hidden from users so unless I'm missing something they're totally fine and benign. > >> As for the known_hosts error values, in the future I would strongly encourage the use of unique error codes going forward. Writing end-user applications rely on unique error codes to generate meaningful user error strings to present to the user. > > But they're different error codes, they're not in a single number range. They are in a single range across the project, look at _FX_ and _KNOWNHOST_ errors. For example: LIBSSH2_KNOWNHOST_CHECK_MISMATCH 1 LIBSSH2_FX_EOF 1 These types of collisions are not great, IMHO. > I will agree though that it is generally more convenient for everyone to keep the error codes in the same range even for different functions. > However, I don't think exposing our return codes will be helpful to very many users... We’re not literally showing these codes to end-users, we are translating them to user friendly error strings. For a concrete example, we have a function like errorMessageFromCode(int code), the _code_ is the code coming from any o’l libssh function call. As you might guess, inside that function is a switch statement on the various Libssh error values. Switch statements need unique values, thus the original pull request. There is value in having unique codes, much more so than having them in the same range across files. Will _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Fri Mar 13 00:32:52 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2CNWmQZ014888; Fri, 13 Mar 2015 00:32:51 +0100 Received: from mail.panic.com (posh.panic.com [38.103.165.4]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2CNWlv8014824 for ; Fri, 13 Mar 2015 00:32:47 +0100 Received: from [10.0.0.94] (unknown [38.103.165.36]) by mail.panic.com (Postfix) with ESMTPSA id 9A003B782453 for ; Thu, 12 Mar 2015 16:32:43 -0700 (PDT) Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: breaking the ABI (was Re: 'watch' libssh2 on github) From: Will Cosgrove In-Reply-To: <98F1EA0C-6548-4752-B9DA-DDA415B28FEB@panic.com> Date: Thu, 12 Mar 2015 16:32:43 -0700 Message-Id: References: <2258ED7C-F129-45D4-A3B9-64AAB82583F1@panic.com> <3742F847-D778-43D0-ADA6-B657C81463CF@panic.com> <98F1EA0C-6548-4752-B9DA-DDA415B28FEB@panic.com> To: libssh2 development X-Mailer: Apple Mail (2.2070.6) X-MIME-Autoconverted: from quoted-printable to 8bit by giant.haxx.se id t2CNWlv8014824 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2CNWmQZ014888 > On Mar 12, 2015, at 4:31 PM, Will Cosgrove wrote: > >> On Thu, 12 Mar 2015, Will Cosgrove wrote: >> >>> In kmdhgGPsha1kex_state_t, I changed the following: >> >> Ok, but I don't see how any of those changes cause any breaking change. They're internal and hidden from users so unless I'm missing something they're totally fine and benign. I missed this; If the user was referencing the size of the struct or referencing the struct directly was my concern. However, as noted, they are internal structures so if they are messing with them, so be it? Will _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Fri Mar 13 02:28:55 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2D1Sd7S026626; Fri, 13 Mar 2015 02:28:53 +0100 Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2D1SbHK026482 for ; Fri, 13 Mar 2015 02:28:38 +0100 Received: from OwnerPC311012 (unknown [203.202.164.190]) (Authenticated sender: sisyphus1@optusnet.com.au) by mail104.syd.optusnet.com.au (Postfix) with ESMTPA id D2961421885 for ; Fri, 13 Mar 2015 12:28:27 +1100 (AEDT) Message-ID: <95F39158BCF84B8784CB26A293E60E1D@OwnerPC311012> From: To: "libssh2 development" References: <9CC4F5E65A1F47DFB4C5326712CD50A0@OwnerPC311012> In-Reply-To: Subject: Re: [Win32] undefined reference Date: Fri, 13 Mar 2015 12:27:32 +1100 MIME-Version: 1.0 X-Priority: 3 X-MSMail-Priority: Normal Importance: Normal X-Mailer: Microsoft Windows Live Mail 16.4.3505.912 X-MimeOLE: Produced By Microsoft MimeOLE V16.4.3505.912 X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.1 cv=Za4kaKlA c=1 sm=1 tr=0 a=8e8rgZJuizJfF74+JHJpGg==:117 a=8e8rgZJuizJfF74+JHJpGg==:17 a=PO7r1zJSAAAA:8 a=IkcTkHD0fZMA:10 a=eVm_8GssBye08LxwOZsA:9 a=QEXdDO2ut3YA:10 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2D1Sd7S026626 From: Alexander Lamaison Sent: Friday, March 13, 2015 4:42 AM To: libssh2 development Subject: Re: [Win32] undefined reference > On 12 Mar 2015 15:17, wrote: >> C:\_64\msys\1.0\local\lib\libssh2.a(misc.o):misc.c:(.text+0x40): >> undefined reference to `__ms_vsnprintf' >> C:\_64\msys\1.0\local\lib\libssh2.a(scp.o):scp.c:(.text+0x40): undefined >> reference to `__ms_vsnprintf' >> >> What do I need to link to here in order to resolve that ? >I'm not near a computer so can't double check, but those look like CRT >functions to me. I'm guessing you built libssh2 to use the static MSVCRT, >but you've built your main program against a different CRT version. The >versions need to match. This was a problem encountered building the Net::SSH2 perl extension. I've been building that extension (and libssh2) for years, and never struck anything like this. The solution was amazingly simple - shutdown the computer (last night) and let the 16 updates from Microsoft install, then restart the computer (this morning). The Net::SSH2 build is fully scripted and the script that was producing the above errors last thing last night, is working fine first thing this morning. Dunno what the problem was .... Thanks for replying, Alex. Cheers, Rob _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Fri Mar 13 09:54:59 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2D8sa5t004148; Fri, 13 Mar 2015 09:54:55 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2D8sZ9U004137 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 13 Mar 2015 09:54:35 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t2D8sYv2004134 for ; Fri, 13 Mar 2015 09:54:34 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Fri, 13 Mar 2015 09:54:34 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: Re: breaking the ABI (was Re: 'watch' libssh2 on github) In-Reply-To: <98F1EA0C-6548-4752-B9DA-DDA415B28FEB@panic.com> Message-ID: References: <2258ED7C-F129-45D4-A3B9-64AAB82583F1@panic.com> <3742F847-D778-43D0-ADA6-B657C81463CF@panic.com> <98F1EA0C-6548-4752-B9DA-DDA415B28FEB@panic.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="1129329158-1249822258-1426236874=:13706" X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --1129329158-1249822258-1426236874=:13706 Content-Type: TEXT/PLAIN; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT On Thu, 12 Mar 2015, Will Cosgrove wrote: >> But they're different error codes, they're not in a single number range. > > They are in a single range across the project, look at _FX_ and _KNOWNHOST_ > errors. For example: > > LIBSSH2_KNOWNHOST_CHECK_MISMATCH 1 > LIBSSH2_FX_EOF 1 > > These types of collisions are not great, IMHO. They are the same values because they actually are in different ranges. But I also recognize that it isn't very ovious since the functions all just return 'int' - which I think is unfortunate but really a design choice made back in the days we still lived in caves. Changing them to different typedef'ed variables depending on what error code range they return would be a good thing for a future API update. > we have a function like errorMessageFromCode(int code), the _code_ is the > code coming from any o’l libssh function call. But that's the mistake. All libssh2 functions don't return the same error code set. The libssh2_knownhost*() functions for example only return error codes in the LIBSSH2_KNOWNHOST_CHECK_* series. -- / daniel.haxx.se --1129329158-1249822258-1426236874=:13706 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --1129329158-1249822258-1426236874=:13706-- From libssh2-devel-bounces@cool.haxx.se Fri Mar 13 09:55:39 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2D8tdDL009395; Fri, 13 Mar 2015 09:55:39 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2D8tbw2009094 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 13 Mar 2015 09:55:37 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t2D8tbft009089 for ; Fri, 13 Mar 2015 09:55:37 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Fri, 13 Mar 2015 09:55:37 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: Re: breaking the ABI (was Re: 'watch' libssh2 on github) In-Reply-To: Message-ID: References: <2258ED7C-F129-45D4-A3B9-64AAB82583F1@panic.com> <3742F847-D778-43D0-ADA6-B657C81463CF@panic.com> <98F1EA0C-6548-4752-B9DA-DDA415B28FEB@panic.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2D8tdDL009395 On Thu, 12 Mar 2015, Will Cosgrove wrote: >>> Ok, but I don't see how any of those changes cause any breaking change. >>> They're internal and hidden from users so unless I'm missing something >>> they're totally fine and benign. > > I missed this; If the user was referencing the size of the struct or > referencing the struct directly was my concern. However, as noted, they are > internal structures so if they are messing with them, so be it? Right. We take responsibility for the API and ABI as documented and as working, we can't also care about users who would do things behind our back. -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Fri Mar 13 10:20:45 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2D9Kemi011090; Fri, 13 Mar 2015 10:20:44 +0100 Received: from mail-la0-x231.google.com (mail-la0-x231.google.com [IPv6:2a00:1450:4010:c03::231]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2D9Kcod011030 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2015 10:20:39 +0100 Received: by labhs14 with SMTP id hs14so20733376lab.5 for ; Fri, 13 Mar 2015 02:20:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=GF5qH6YHGTpftdOUwHkgFgAkKVp2vPsmdBvdp04yTvs=; b=04DKs2jA/8WXCZRlMY1lY441/1qwyn5SRJT20bZA43dut1JkJsCvraws6Z5OxzQWvw GHtty0VzZhWV8EcTVeBin0VCPudoj/Qu9YUhXqZ7xoEu2tHYfUCk8N+AVe339AI6jqgy 3o2xasBu78VcMUzlcRI0iB6vBfe9QASkOSeKZzdzmu5z5Jyg0oS5raX/epukooXrr26I uBjbUIPJ/2nWnJUf7OpQH5YXlygyD8pgogR3CHpvv4c8EegPwPYYV9UvoR4lu/lw8eFp 8vK8COnweLKv2LytxugN6I9E2DUVTHdHBloGUVRmjxiiWa+c+iN0O8NXIr6U60QdFy/n 8eYw== MIME-Version: 1.0 X-Received: by 10.152.10.209 with SMTP id k17mr12926882lab.50.1426238434229; Fri, 13 Mar 2015 02:20:34 -0700 (PDT) Received: by 10.25.28.129 with HTTP; Fri, 13 Mar 2015 02:20:34 -0700 (PDT) Received: by 10.25.28.129 with HTTP; Fri, 13 Mar 2015 02:20:34 -0700 (PDT) In-Reply-To: References: <2258ED7C-F129-45D4-A3B9-64AAB82583F1@panic.com> <3742F847-D778-43D0-ADA6-B657C81463CF@panic.com> <98F1EA0C-6548-4752-B9DA-DDA415B28FEB@panic.com> Date: Fri, 13 Mar 2015 09:20:34 +0000 X-Google-Sender-Auth: bHoEcWzA5puV4qR0-NpWY7G8W4I Message-ID: Subject: Re: breaking the ABI (was Re: 'watch' libssh2 on github) From: Alexander Lamaison To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============0997569301==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============0997569301== Content-Type: multipart/alternative; boundary=001a113325383cc3a20511280396 --001a113325383cc3a20511280396 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 13 Mar 2015 08:55, "Daniel Stenberg" wrote: > > On Thu, 12 Mar 2015, Will Cosgrove wrote: > >>> But they're different error codes, they're not in a single number range= . >> >> >> They are in a single range across the project, look at _FX_ and _KNOWNHOST_ errors. For example: >> >> LIBSSH2_KNOWNHOST_CHECK_MISMATCH 1 >> LIBSSH2_FX_EOF 1 >> >> These types of collisions are not great, IMHO. > > > They are the same values because they actually are in different ranges. But I also recognize that it isn't very ovious since the functions all just return 'int' - which I think is unfortunate but really a design choice made back in the days we still lived in caves. > > Changing them to different typedef'ed variables depending on what error code range they return would be a good thing for a future API update. > > >> we have a function like errorMessageFromCode(int code), the _code_ is the code coming from any o=E2=80=99l libssh function call. > > > But that's the mistake. All libssh2 functions don't return the same error code set. The libssh2_knownhost*() functions for example only return error codes in the LIBSSH2_KNOWNHOST_CHECK_* series. If I may weigh in here, the known_host return codes aren't error codes at all. That's where the misunderstanding has occurred. Most libssh2 return codes are indeed errors. You can think of them as exceptions, in a language that has that feature. Apart from EAGAIN, you never call a libssh2 function expecting to recieve one of those errors. Contrast that with the known_host functions. There the return code is a result, not an error. You call those functions fully expecting to get any of the possible values returned. Alex --001a113325383cc3a20511280396 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On 13 Mar 2015 08:55, "Daniel Stenberg" <daniel@haxx.se> wrote:
>
> On Thu, 12 Mar 2015, Will Cosgrove wrote:
>
>>> But they're different error codes, they're not in a si= ngle number range.
>>
>>
>> They are in a single range across the project, look at _FX_ and _K= NOWNHOST_ errors. For example:
>>
>> LIBSSH2_KNOWNHOST_CHECK_MISMATCH 1
>> LIBSSH2_FX_EOF=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A01
>>
>> These types of collisions are not great, IMHO.
>
>
> They are the same values because they actually are in different ranges= . But I also recognize that it isn't very ovious since the functions al= l just return 'int' - which I think is unfortunate but really a des= ign choice made back in the days we still lived in caves.
>
> Changing them to different typedef'ed variables depending on what = error code range they return would be a good thing for a future API update.=
>
>
>> we have a function like errorMessageFromCode(int code), the _code_= is the code coming from any o=E2=80=99l libssh function call.
>
>
> But that's the mistake. All libssh2 functions don't return the= same error code set. The libssh2_knownhost*() functions for example only r= eturn error codes in the LIBSSH2_KNOWNHOST_CHECK_* series.

If I may weigh in here, the known_host return codes aren'= ;t error codes at all. That's where the misunderstanding has occurred. =

Most libssh2 return codes are indeed errors. You can think o= f them as exceptions, in a language that has that feature. Apart from EAGAI= N, you never call a libssh2 function expecting to recieve one of those erro= rs.

Contrast that with the known_host functions. There the retur= n code is a result, not an error. You call those functions fully expecting = to get any of the possible values returned.

Alex

--001a113325383cc3a20511280396-- --===============0997569301== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============0997569301==-- From libssh2-devel-bounces@cool.haxx.se Fri Mar 13 17:11:20 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2DGAuev012636; Fri, 13 Mar 2015 17:11:16 +0100 Received: from foo.stuge.se (qmailr@foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2DGAswV012630 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 13 Mar 2015 17:10:54 +0100 Received: (qmail 19913 invoked by uid 501); 13 Mar 2015 16:10:54 -0000 Message-ID: <20150313161054.19912.qmail@stuge.se> Date: Fri, 13 Mar 2015 17:10:54 +0100 From: Peter Stuge To: libssh2-devel@cool.haxx.se Subject: Re: The GitHub unicorn Mail-Followup-To: libssh2-devel@cool.haxx.se References: <109687106.rNUrHsPHZ7@nbkamil> <6E56E98B-6EBD-4B28-B7FD-480B6DF577C0@panic.com> <20150308175243.6848.qmail@stuge.se> <7DCB6E47-4409-45EA-A6A6-6BF58A4CBCD7@panic.com> <20150309144111.11800.qmail@stuge.se> <20150310124625.26103.qmail@stuge.se> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150310124625.26103.qmail@stuge.se> X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2DGAuev012636 Here's a tangentially related blog post about a service shutting down: http://google-opensource.blogspot.com/2015/03/farewell-to-google-code.html //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Fri Mar 13 17:18:23 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2DGIKC9022051; Fri, 13 Mar 2015 17:18:23 +0100 Received: from mail.panic.com (posh.panic.com [38.103.165.4]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2DGIJKB021994 for ; Fri, 13 Mar 2015 17:18:19 +0100 Received: from [10.0.0.94] (unknown [38.103.165.36]) by mail.panic.com (Postfix) with ESMTPSA id F043FB79488E for ; Fri, 13 Mar 2015 09:18:13 -0700 (PDT) From: Will Cosgrove Message-Id: Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: breaking the ABI (was Re: 'watch' libssh2 on github) Date: Fri, 13 Mar 2015 09:18:12 -0700 References: <2258ED7C-F129-45D4-A3B9-64AAB82583F1@panic.com> <3742F847-D778-43D0-ADA6-B657C81463CF@panic.com> <98F1EA0C-6548-4752-B9DA-DDA415B28FEB@panic.com> To: libssh2 development In-Reply-To: X-Mailer: Apple Mail (2.2070.6) X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============2035106546==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============2035106546== Content-Type: multipart/alternative; boundary="Apple-Mail=_885CD511-9568-4C75-AB46-01746723EBCE" --Apple-Mail=_885CD511-9568-4C75-AB46-01746723EBCE Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > >> we have a function like errorMessageFromCode(int code), the _code_ = is the code coming from any o=E2=80=99l libssh function call. > > > > > > But that's the mistake. All libssh2 functions don't return the same = error code set. The libssh2_knownhost*() functions for example only = return error codes in the LIBSSH2_KNOWNHOST_CHECK_* series. >=20 > If I may weigh in here, the known_host return codes aren't error codes = at all. That's where the misunderstanding has occurred. >=20 > Most libssh2 return codes are indeed errors. You can think of them as = exceptions, in a language that has that feature. Apart from EAGAIN, you = never call a libssh2 function expecting to recieve one of those errors. >=20 > Contrast that with the known_host functions. There the return code is = a result, not an error. You call those functions fully expecting to get = any of the possible values returned. >=20 I understand these are technically not errors per-say, but that = doesn=E2=80=99t mean I agree with their values being the same. Will --Apple-Mail=_885CD511-9568-4C75-AB46-01746723EBCE Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

>> we have a function like = errorMessageFromCode(int code), the _code_ is the code coming from any = o=E2=80=99l libssh function call.
>
>
> But that's the mistake. All libssh2 functions don't return the same = error code set. The libssh2_knownhost*() functions for example only = return error codes in the LIBSSH2_KNOWNHOST_CHECK_* series.

If I may weigh in here, the known_host return = codes aren't error codes at all. That's where the misunderstanding has = occurred.

Most libssh2 return codes are = indeed errors. You can think of them as exceptions, in a language that = has that feature. Apart from EAGAIN, you never call a libssh2 function = expecting to recieve one of those errors.

Contrast that with the known_host functions. There the return = code is a result, not an error. You call those functions fully expecting = to get any of the possible values returned. =

I understand these are technically not = errors per-say, but that doesn=E2=80=99t mean I agree with their values = being the same.

Will

= --Apple-Mail=_885CD511-9568-4C75-AB46-01746723EBCE-- --===============2035106546== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============2035106546==-- From libssh2-devel-bounces@cool.haxx.se Fri Mar 13 17:47:07 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2DGl1g5032071; Fri, 13 Mar 2015 17:47:06 +0100 Received: from mail-la0-x234.google.com (mail-la0-x234.google.com [IPv6:2a00:1450:4010:c03::234]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2DGl0ga031774 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2015 17:47:00 +0100 Received: by labmn12 with SMTP id mn12so23867006lab.8 for ; Fri, 13 Mar 2015 09:46:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=plNwYDkbMit/oWNt59zGxQVRe2AVBJx6VLfvkGGaYHA=; b=bxj0FigR04VE8LiAM4sdTP8B1s137o0XfUK0gun4wTHbA1pN1UVLjZNTNX3wWs6L0Q XNH3rDlR4m/tPy8e5dxtXax9+Hq6wIHt1fVNaFcRMzER7A9LmW172+ZEPiU06jW2GeOU wWuaBRdBQuHTVnGkI0M1qN69rcRXFniJqnp3/Hz0tjWrB+TZgLW2Yom45LUviGxWMr9S 1TZKGVTeBe2aTvrQlUsf/RI6WwPpRWv/A2aP3qWibwFf8xHVNyyPSoN23xePa2VhUz/P KVQrYqT31lAB/4Ww2FYNgw/xd3z/tWgHTOx7UWUTKaki5p5uPvnaV9mc9T9MhCotgJph G8/A== MIME-Version: 1.0 X-Received: by 10.112.8.68 with SMTP id p4mr43162239lba.37.1426265216338; Fri, 13 Mar 2015 09:46:56 -0700 (PDT) Received: by 10.25.28.129 with HTTP; Fri, 13 Mar 2015 09:46:56 -0700 (PDT) Received: by 10.25.28.129 with HTTP; Fri, 13 Mar 2015 09:46:56 -0700 (PDT) In-Reply-To: References: <2258ED7C-F129-45D4-A3B9-64AAB82583F1@panic.com> <3742F847-D778-43D0-ADA6-B657C81463CF@panic.com> <98F1EA0C-6548-4752-B9DA-DDA415B28FEB@panic.com> Date: Fri, 13 Mar 2015 16:46:56 +0000 X-Google-Sender-Auth: i69OIPaF1E5enhTcNeDhKovf3G8 Message-ID: Subject: Re: breaking the ABI (was Re: 'watch' libssh2 on github) From: Alexander Lamaison To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============1611583199==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============1611583199== Content-Type: multipart/alternative; boundary=001a1135e3d293517905112e3fb1 --001a1135e3d293517905112e3fb1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 13 Mar 2015 16:18, "Will Cosgrove" wrote: >> >> >> we have a function like errorMessageFromCode(int code), the _code_ is the code coming from any o=E2=80=99l libssh function call. >> > >> > >> > But that's the mistake. All libssh2 functions don't return the same error code set. The libssh2_knownhost*() functions for example only return error codes in the LIBSSH2_KNOWNHOST_CHECK_* series. >> >> If I may weigh in here, the known_host return codes aren't error codes at all. That's where the misunderstanding has occurred. >> >> Most libssh2 return codes are indeed errors. You can think of them as exceptions, in a language that has that feature. Apart from EAGAIN, you never call a libssh2 function expecting to recieve one of those errors. >> >> Contrast that with the known_host functions. There the return code is a result, not an error. You call those functions fully expecting to get any of the possible values returned. > > I understand these are technically not errors per-say, but that doesn=E2= =80=99t mean I agree with their values being the same. Would you feel different if the function did a calculation that returned a number? Or checked something and returned a boolean? Both those would return values that overlapped with the error codes. But they aren't error codes, so you presumably wouldn't care. The known_hosts functions are no different. Asked --001a1135e3d293517905112e3fb1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On 13 Mar 2015 16:18, "Will Cosgrove" <will@panic.com> wrote:
>>
>> >> we have a function like errorMessageFromCode(int code), t= he _code_ is the code coming from any o=E2=80=99l libssh function call.
>> >
>> >
>> > But that's the mistake. All libssh2 functions don't r= eturn the same error code set. The libssh2_knownhost*() functions for examp= le only return error codes in the LIBSSH2_KNOWNHOST_CHECK_* series.
>>
>> If I may weigh in here, the known_host return codes aren't err= or codes at all. That's where the misunderstanding has occurred.
>>
>> Most libssh2 return codes are indeed errors. You can think of them= as exceptions, in a language that has that feature. Apart from EAGAIN, you= never call a libssh2 function expecting to recieve one of those errors. >>
>> Contrast that with the known_host functions. There the return code= is a result, not an error. You call those functions fully expecting to get= any of the possible values returned.
>
> I understand these are technically not errors per-say, but that doesn= =E2=80=99t mean I agree with their values being the same.

Would you feel different if the function did a calculation t= hat returned a number? Or checked something and returned a boolean?

Both those would return values that overlapped with the erro= r codes. But they aren't error codes, so you presumably wouldn't ca= re. The known_hosts functions are no different.

Asked

--001a1135e3d293517905112e3fb1-- --===============1611583199== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============1611583199==-- From libssh2-devel-bounces@cool.haxx.se Fri Mar 13 18:47:41 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2DHlNWv020405; Fri, 13 Mar 2015 18:47:38 +0100 Received: from mail-lb0-x229.google.com (mail-lb0-x229.google.com [IPv6:2a00:1450:4010:c04::229]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2DHlMLj020376 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2015 18:47:22 +0100 Received: by lbdu10 with SMTP id u10so24349882lbd.4 for ; Fri, 13 Mar 2015 10:47:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=GeG5UBqeA6tzUjDCZF0zR2MnVadYd7amswJN1A+OWhU=; b=uX+4ogRFkAlQo7LppLB5CjQCrkVQV+h1+UZ/0QAbOE4Xk16rOjfofWG1TkkGNqo7AR 7E6IrfJKjTKRoMlyQAIfyPMURnwWYtdbfGTg5tSOGiAziiTydeU8xzEF5ZNM65lH8sQU qFIcHCWGaZc2No5yxiZtgjOVxKN+Mpj8YArebxlzZxPl2w5d9jjc6HcqiJlzvj4OVhG5 +kjKLiMvxk52ZxzP5TKToGe9ZtpwR+tIrUxU6yKZJtQEIAa2FfqK8f6q20WpqS9NBhzF NNCipshwFXy58St9ufOLuupwl0ktlv9xJPSx5kAPepy35Lk4uqiZpAhvycVirk/wGPRT mVjA== MIME-Version: 1.0 X-Received: by 10.152.88.99 with SMTP id bf3mr43370771lab.37.1426268838555; Fri, 13 Mar 2015 10:47:18 -0700 (PDT) Received: by 10.25.28.129 with HTTP; Fri, 13 Mar 2015 10:47:18 -0700 (PDT) Received: by 10.25.28.129 with HTTP; Fri, 13 Mar 2015 10:47:18 -0700 (PDT) In-Reply-To: References: <2258ED7C-F129-45D4-A3B9-64AAB82583F1@panic.com> <3742F847-D778-43D0-ADA6-B657C81463CF@panic.com> <98F1EA0C-6548-4752-B9DA-DDA415B28FEB@panic.com> Date: Fri, 13 Mar 2015 17:47:18 +0000 X-Google-Sender-Auth: 0Qg659syT-yHhNdgBYXL_gopHJ4 Message-ID: Subject: Re: breaking the ABI (was Re: 'watch' libssh2 on github) From: Alexander Lamaison To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============0757872510==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============0757872510== Content-Type: multipart/alternative; boundary=001a11c3562e79f53e05112f17c8 --001a11c3562e79f53e05112f17c8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 13 Mar 2015 16:46, "Alexander Lamaison" wrote: > > On 13 Mar 2015 16:18, "Will Cosgrove" wrote: > >> > >> >> we have a function like errorMessageFromCode(int code), the _code_ is the code coming from any o=E2=80=99l libssh function call. > >> > > >> > > >> > But that's the mistake. All libssh2 functions don't return the same error code set. The libssh2_knownhost*() functions for example only return error codes in the LIBSSH2_KNOWNHOST_CHECK_* series. > >> > >> If I may weigh in here, the known_host return codes aren't error codes at all. That's where the misunderstanding has occurred. > >> > >> Most libssh2 return codes are indeed errors. You can think of them as exceptions, in a language that has that feature. Apart from EAGAIN, you never call a libssh2 function expecting to recieve one of those errors. > >> > >> Contrast that with the known_host functions. There the return code is a result, not an error. You call those functions fully expecting to get any of the possible values returned. > > > > I understand these are technically not errors per-say, but that doesn= =E2=80=99t mean I agree with their values being the same. > > Would you feel different if the function did a calculation that returned a number? Or checked something and returned a boolean? > > Both those would return values that overlapped with the error codes. But they aren't error codes, so you presumably wouldn't care. The known_hosts functions are no different. I've thought about this some more and I think I understand where the confusion arises. You are understandably assuming that libssh2_knownhost_check returns error codes when it hits an error (a real, unexpected, exception-type failure; not just 'not found'). It doesn't. It actually return there result FAILURE which means you should call libssh2_session_last_errno function to get the real error code (for example LIBSSH2_ERROR_ALLOC). Alex --001a11c3562e79f53e05112f17c8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On 13 Mar 2015 16:46, "Alexander Lamaison" <swish@lammy.co.uk> wrote:
>
> On 13 Mar 2015 16:18, "Will Cosgrove" <will@panic.com> wrote:
> >>
> >> >> we have a function like errorMessageFromCode(int cod= e), the _code_ is the code coming from any o=E2=80=99l libssh function call= .
> >> >
> >> >
> >> > But that's the mistake. All libssh2 functions don= 9;t return the same error code set. The libssh2_knownhost*() functions for = example only return error codes in the LIBSSH2_KNOWNHOST_CHECK_* series. > >>
> >> If I may weigh in here, the known_host return codes aren'= t error codes at all. That's where the misunderstanding has occurred. > >>
> >> Most libssh2 return codes are indeed errors. You can think of= them as exceptions, in a language that has that feature. Apart from EAGAIN= , you never call a libssh2 function expecting to recieve one of those error= s.
> >>
> >> Contrast that with the known_host functions. There the return= code is a result, not an error. You call those functions fully expecting t= o get any of the possible values returned.
> >
> > I understand these are technically not errors per-say, but that d= oesn=E2=80=99t mean I agree with their values being the same.
>
> Would you feel different if the function did a calculation that return= ed a number? Or checked something and returned a boolean?
>
> Both those would return values that overlapped with the error codes. B= ut they aren't error codes, so you presumably wouldn't care. The kn= own_hosts functions are no different.

I've thought about this some more and I think I understa= nd where the confusion arises. You are understandably assuming that libssh2= _knownhost_check returns error codes when it hits an error (a real, unexpec= ted, exception-type failure; not just 'not found'). It doesn't.= It actually return there result FAILURE which means you should call libssh= 2_session_last_errno function to get the real error code (for example LIBSS= H2_ERROR_ALLOC).

Alex

--001a11c3562e79f53e05112f17c8-- --===============0757872510== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============0757872510==-- From libssh2-devel-bounces@cool.haxx.se Fri Mar 13 18:56:21 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2DHuHTb029731; Fri, 13 Mar 2015 18:56:21 +0100 Received: from mail.panic.com (posh.panic.com [38.103.165.4]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2DHuFiK029670 for ; Fri, 13 Mar 2015 18:56:16 +0100 Received: from [10.0.0.94] (unknown [38.103.165.36]) by mail.panic.com (Postfix) with ESMTPSA id CEFB3B795812 for ; Fri, 13 Mar 2015 10:56:10 -0700 (PDT) From: Will Cosgrove Message-Id: Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: breaking the ABI (was Re: 'watch' libssh2 on github) Date: Fri, 13 Mar 2015 10:56:10 -0700 References: <2258ED7C-F129-45D4-A3B9-64AAB82583F1@panic.com> <3742F847-D778-43D0-ADA6-B657C81463CF@panic.com> <98F1EA0C-6548-4752-B9DA-DDA415B28FEB@panic.com> To: libssh2 development In-Reply-To: X-Mailer: Apple Mail (2.2070.6) X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============0112873395==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============0112873395== Content-Type: multipart/alternative; boundary="Apple-Mail=_41285780-CCDE-4D56-B7EE-F68BF43E8041" --Apple-Mail=_41285780-CCDE-4D56-B7EE-F68BF43E8041 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > > >> Contrast that with the known_host functions. There the return = code is a result, not an error. You call those functions fully expecting = to get any of the possible values returned. > > > > > > I understand these are technically not errors per-say, but that = doesn=E2=80=99t mean I agree with their values being the same. > > > > Would you feel different if the function did a calculation that = returned a number? Or checked something and returned a boolean? > > > > Both those would return values that overlapped with the error codes. = But they aren't error codes, so you presumably wouldn't care. The = known_hosts functions are no different. >=20 > I've thought about this some more and I think I understand where the = confusion arises. You are understandably assuming that = libssh2_knownhost_check returns error codes when it hits an error (a = real, unexpected, exception-type failure; not just 'not found'). It = doesn't. It actually return there result FAILURE which means you should = call libssh2_session_last_errno function to get the real error code (for = example LIBSSH2_ERROR_ALLOC). >=20 There is no confusion. I simply do not like conflicting static defined = result values. This scenario is different than returning a bool or a = random value, these are defined values, that do not change and overlap. = It=E2=80=99s not how I would personally do it, perhaps it=E2=80=99s OK = with you, that=E2=80=99s OK, we can agree to disagree. Will= --Apple-Mail=_41285780-CCDE-4D56-B7EE-F68BF43E8041 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

> >> Contrast that with the known_host = functions. There the return code is a result, not an error. You call = those functions fully expecting to get any of the possible values = returned.
> >
> > I understand these are technically not errors per-say, but = that doesn=E2=80=99t mean I agree with their values being the same.
>
> Would you feel different if the function did a calculation that = returned a number? Or checked something and returned a boolean?
>
> Both those would return values that overlapped with the error = codes. But they aren't error codes, so you presumably wouldn't care. The = known_hosts functions are no different.

I've = thought about this some more and I think I understand where the = confusion arises. You are understandably assuming that = libssh2_knownhost_check returns error codes when it hits an error (a = real, unexpected, exception-type failure; not just 'not found'). It = doesn't. It actually return there result FAILURE which means you should = call libssh2_session_last_errno function to get the real error code (for = example LIBSSH2_ERROR_ALLOC).

There is no confusion.  I simply do not like conflicting = static defined result values.  This scenario is different than = returning a bool or a random value, these are defined values, that do = not change and overlap.  It=E2=80=99s not how I would personally do = it, perhaps it=E2=80=99s OK with you, that=E2=80=99s OK, we can agree to = disagree.

Will
= --Apple-Mail=_41285780-CCDE-4D56-B7EE-F68BF43E8041-- --===============0112873395== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============0112873395==-- From libssh2-devel-bounces@cool.haxx.se Fri Mar 13 19:25:57 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2DIPmR9008993; Fri, 13 Mar 2015 19:25:56 +0100 Received: from mail-lb0-x234.google.com (mail-lb0-x234.google.com [IPv6:2a00:1450:4010:c04::234]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2DIPkbS008930 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2015 19:25:46 +0100 Received: by lbvp9 with SMTP id p9so24606222lbv.8 for ; Fri, 13 Mar 2015 11:25:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=XD4+4FHfPjr+L5LhR4Bph7vAfSaHXZguAKAq6knEV3c=; b=mgowFSuiwChnFkDLOe0TxWxe4Tzsafz0Qv8fTfLI5K4x/FdhQ3hjDko75Tio5b+Z7s 456n4rOt08BJEz0rwx23AEzBfMQOyNbE9k9/WH49IxHP59B5WrR8gjKWET/edkS9zmnY 31RUuG+9JupqGom1rYwMw6zWI7Z8FG4NRF735IAaix0Khm9AUP+9kkpLfGtOfmrdFjLR gFaOkvdi1TWUlTCCoIOuLZQaBzqv8wMXQtCBveKW/VpaZ+ezciHBJtPh4DSYAqEsXq0k mcRcMXaWbDa7M/iBDfVYLJEqFaE88kBbKKguoExk/83k2mgpQYCi/52QYeMVOAZn8ijK i9vA== MIME-Version: 1.0 X-Received: by 10.152.10.209 with SMTP id k17mr14857331lab.50.1426271142602; Fri, 13 Mar 2015 11:25:42 -0700 (PDT) Received: by 10.25.28.129 with HTTP; Fri, 13 Mar 2015 11:25:42 -0700 (PDT) In-Reply-To: References: <2258ED7C-F129-45D4-A3B9-64AAB82583F1@panic.com> <3742F847-D778-43D0-ADA6-B657C81463CF@panic.com> <98F1EA0C-6548-4752-B9DA-DDA415B28FEB@panic.com> Date: Fri, 13 Mar 2015 18:25:42 +0000 X-Google-Sender-Auth: Myk1yJw2-H2xRRKICbqmYV47jCo Message-ID: Subject: Re: breaking the ABI (was Re: 'watch' libssh2 on github) From: Alexander Lamaison To: libssh2 development X-MIME-Autoconverted: from quoted-printable to 8bit by giant.haxx.se id t2DIPkbS008930 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2DIPmR9008993 On 13 March 2015 at 17:56, Will Cosgrove wrote: >> >> Contrast that with the known_host functions. There the return code is a >> >> result, not an error. You call those functions fully expecting to get any of >> >> the possible values returned. >> > >> > I understand these are technically not errors per-say, but that doesn’t >> > mean I agree with their values being the same. >> >> Would you feel different if the function did a calculation that returned a >> number? Or checked something and returned a boolean? >> >> Both those would return values that overlapped with the error codes. But >> they aren't error codes, so you presumably wouldn't care. The known_hosts >> functions are no different. > > I've thought about this some more and I think I understand where the > confusion arises. You are understandably assuming that > libssh2_knownhost_check returns error codes when it hits an error (a real, > unexpected, exception-type failure; not just 'not found'). It doesn't. It > actually return there result FAILURE which means you should call > libssh2_session_last_errno function to get the real error code (for example > LIBSSH2_ERROR_ALLOC). > > There is no confusion. I simply do not like conflicting static defined > result values. This scenario is different than returning a bool or a random > value, these are defined values, that do not change and overlap. It’s not > how I would personally do it, perhaps it’s OK with you, that’s OK, we can > agree to disagree. LIBSSH2_KNOWNHOST_CHECK_MATCH, LIBSSH2_HOSTKEY_TYPE_UNKNOWN, LIBSSH2_FX_OK, the boolean value FALSE, the NULL pointer and the unusable socket INVALID_SOCKET are all defined values that share the value 0. But that's OK because they are totally unrelated. It not practical, and not necessary, to make sure that all constants defined in a program exist along a single range, without overlap. Why would you want to? Alex -- Swish - Easy SFTP for Windows Explorer (http://www.swish-sftp.org) _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Sun Mar 15 13:02:19 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2FC1nfL010953; Sun, 15 Mar 2015 13:02:14 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2FC1mYl010773 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 15 Mar 2015 13:01:48 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t2FC1lal010768 for ; Sun, 15 Mar 2015 13:01:48 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Sun, 15 Mar 2015 13:01:47 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: commit notices Message-ID: User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2FC1nfL010953 Hey I added an IRC notice for each commit and an email notice to the libssh2-changes mailing list, for us who want to get a little alert when things move in the git repo... -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Mar 16 15:52:37 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2GEqBii027026; Mon, 16 Mar 2015 15:52:33 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2GEq9vo027021 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 16 Mar 2015 15:52:09 +0100 Received: (qmail 4423 invoked from network); 16 Mar 2015 14:55:26 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 16 Mar 2015 14:55:26 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software To: ios3@moontechnolabs.com X-Trac-Project: libssh2 Date: Mon, 16 Mar 2015 14:55:26 -0000 X-URL: https://trac.libssh2.org/ Subject: Re: [libssh2] #295: latest libssh2 library with support 64 bit architecture fails to authenticate with public key (RSA) libssh2_userauth_publickey_fromfile X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/295#comment:1 Message-ID: <056.7a9e0819afa645db2414e099bbf34fc1@libssh2.stuge.se> References: <041.461ecd84fb49ba812d54e2379f5b653a@libssh2.stuge.se> X-Trac-Ticket-ID: 295 In-Reply-To: <041.461ecd84fb49ba812d54e2379f5b653a@libssh2.stuge.se> X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2GEq9vo027021 Cc: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: trac@libssh2.stuge.se, libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2GEqBii027026 #295: latest libssh2 library with support 64 bit architecture fails to authenticate with public key (RSA) libssh2_userauth_publickey_fromfile ---------------------+------------------- Reporter: ios3 | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.4.3 Component: API | Version: 1.4.2 Resolution: | Keywords: Blocked By: | Blocks: ---------------------+------------------- Comment (by ios3): Hi..please give me some feedback about issue, Is there something wrong with library or am I missing something? As with older version it's working fine. -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Mar 16 17:35:42 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2GGZPOx032249; Mon, 16 Mar 2015 17:35:40 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2GGZOjO032230 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 16 Mar 2015 17:35:24 +0100 Received: (qmail 29248 invoked from network); 16 Mar 2015 16:38:41 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 16 Mar 2015 16:38:41 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software To: ios3@moontechnolabs.com, daniel@haxx.se X-Trac-Project: libssh2 Date: Mon, 16 Mar 2015 16:38:41 -0000 X-URL: https://trac.libssh2.org/ Subject: Re: [libssh2] #295: latest libssh2 library with support 64 bit architecture fails to authenticate with public key (RSA) libssh2_userauth_publickey_fromfile X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/295#comment:2 Message-ID: <056.1cc754e2c70221e695c4e2899eb0d043@libssh2.stuge.se> References: <041.461ecd84fb49ba812d54e2379f5b653a@libssh2.stuge.se> X-Trac-Ticket-ID: 295 In-Reply-To: <041.461ecd84fb49ba812d54e2379f5b653a@libssh2.stuge.se> X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2GGZOjO032230 Cc: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: trac@libssh2.stuge.se, libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2GGZPOx032249 #295: latest libssh2 library with support 64 bit architecture fails to authenticate with public key (RSA) libssh2_userauth_publickey_fromfile ---------------------+------------------- Reporter: ios3 | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.4.3 Component: API | Version: 1.4.2 Resolution: | Keywords: Blocked By: | Blocks: ---------------------+------------------- Comment (by bagder): You need to provide more info. I use libssh2 on nothing but 64bit archs and I have not experienced any problems. Can you bisect your way to the offending commit that introduced the problem you see? -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Mar 18 13:29:34 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2ICT5T7022596; Wed, 18 Mar 2015 13:29:30 +0100 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2ICT2eR022577 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 18 Mar 2015 13:29:03 +0100 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 9075839ABAC; Wed, 18 Mar 2015 12:29:02 +0000 (UTC) Received: from kdudka.brq.redhat.com (kdudka.brq.redhat.com [10.34.4.67]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2ICT0t0023197 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Wed, 18 Mar 2015 08:29:01 -0400 From: Kamil Dudka To: Sagar Chandawale Subject: Re: New to libssh2: LIBSSH2_ERROR_EAGAIN error Date: Wed, 18 Mar 2015 13:28:59 +0100 Message-ID: <1553724.lIoXAjIuMm@kdudka.brq.redhat.com> User-Agent: KMail/4.14.4 (Linux/3.18.7-200.fc21.x86_64; KDE/4.14.4; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Cc: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2ICT5T7022596 On Wednesday 11 March 2015 17:35:06 Sagar Chandawale wrote: > Hello, > > Spent a few days to get the libssh2 VS2010 solution build successfully on a > Windows 7 machine and trying to use examples to understand the operation. > > I am using the "ssh2_echo" example to connect to the Linux PC and simply > return the "ls -l" output back. I tried multiple examples and I see that I > am getting stuck at the libssh2_session_handshake(session, sock) function > where it returns a LIBSSH2_ERROR_EAGAIN (-37) just in the 2nd iteration. This usually means that libssh2 is waiting for data to be send/received over the network. You can try to increase the verbose level to check what data is actually being transmitted. Kamil > I have looked up the documentation but cannot find a resolution. Just FYI, > I am able to connect to the Linux PC with PuTTY client. > > Sorry if this is an ultra basic question, but any help is highly > appreciated! > > Thanks, > sa-cha _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Mar 23 14:53:26 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2NDquKC027959; Mon, 23 Mar 2015 14:53:21 +0100 Received: from smtp-gw21.han.skanova.net (smtp-gw21.han.skanova.net [81.236.55.21]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2NDqsOJ027803 for ; Mon, 23 Mar 2015 14:52:54 +0100 Received: from [192.168.20.198] (81.227.138.114) by smtp-gw21.han.skanova.net (8.5.142.07) id 54EF7C1F006C8FB3 for libssh2-devel@cool.haxx.se; Mon, 23 Mar 2015 14:52:50 +0100 To: libssh2 development Subject: SFTP read in libssh2 compared to SecureCRT From: Lars Nordin message-id: <55101AB2.6080804@SDlabs.se> Date: Mon, 23 Mar 2015 14:52:50 +0100 user-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:37.0) Gecko/20100101 Thunderbird/37.0 mime-version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2NDquKC027959 Hi, I'm using libssh2 for different purpose, one of them is write/read files using SFTP. I just start using version 1.5.0 and I can't get the SFTP-read up to speed. I'm testing with a 76M file and using SecureCRT SFTP I get 81s for the download, with libssh2 SFTP 44 minutes!!! If a use SCP I get download in 12s!! The libssh2_sftp_read() always return 2000, despite I call it with a buffer of 100k. If a look at the network with wireshark and compare the data on the network, I notice that o with SecureCRT SFTP the server send data in 1460 sized packages, at least 10 packets before the client send some data (up to 32 packets I notice) o with libssh2 the server send data in different sizes (1460 and less, many times 1460 followed by 592) and 1-4 packets before the client send something. The test is done using a OpenSSH sshd in a Linux virtual machine. Client is Windows7 I copied the sftp_RW_nonblock example. Can I change something? /Lars _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Mar 23 15:17:49 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2NEHhRD008153; Mon, 23 Mar 2015 15:17:48 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2NEHfY2008132 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 23 Mar 2015 15:17:41 +0100 Received: (qmail 5079 invoked from network); 23 Mar 2015 14:21:06 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 23 Mar 2015 14:21:06 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software To: ios3@moontechnolabs.com, daniel@haxx.se X-Trac-Project: libssh2 Date: Mon, 23 Mar 2015 14:21:06 -0000 X-URL: https://trac.libssh2.org/ Subject: Re: [libssh2] #295: latest libssh2 library with support 64 bit architecture fails to authenticate with public key (RSA) libssh2_userauth_publickey_fromfile X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/295#comment:3 Message-ID: <056.a131df807e02c124811c6b8b91741187@libssh2.stuge.se> References: <041.461ecd84fb49ba812d54e2379f5b653a@libssh2.stuge.se> X-Trac-Ticket-ID: 295 In-Reply-To: <041.461ecd84fb49ba812d54e2379f5b653a@libssh2.stuge.se> X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2NEHfY2008132 Cc: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: trac@libssh2.stuge.se, libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2NEHhRD008153 #295: latest libssh2 library with support 64 bit architecture fails to authenticate with public key (RSA) libssh2_userauth_publickey_fromfile ---------------------+------------------- Reporter: ios3 | Owner: Type: defect | Status: new Priority: normal | Milestone: 1.4.3 Component: API | Version: 1.4.2 Resolution: | Keywords: Blocked By: | Blocks: ---------------------+------------------- Comment (by ios3): We have developed one iOS application to ssh using libssh2 library. There is all things working fine with libssh2 version 1.4.2, But I required to use 1.4.3 version to support arm64 bit architecture. I have update version and now using with 1.4.3 all things is working fine except key authentication. I have made one RSA key to ssh with my server, I have copied public key in authorized key file so that we can connect with that pc/server. Using this key when I try to connect/ssh it returns me error -18"LIBSSH2_ERROR_AUTHENTICATION_FAILED". When I tried to ssh with same key and same server it allows me without any issue using version 1.4.2 (older one). I don't what's happen. USing this method with para to check authenticate status libssh2_userauth_publickey_fromfile(session, username, pubkey,privatekey ,password); Below is detail how I m gettig para const char *pubkey= [_publicKey cStringUsingEncoding:NSUTF8StringEncoding]; const char *privatekey= [_privateKey cStringUsingEncoding:NSUTF8StringEncoding]; password=NULL const char* username = [username1 cStringUsingEncoding:NSUTF8StringEncoding]; const char* password = [passWd cStringUsingEncoding:NSUTF8StringEncoding]; Please let me know if any thing wrong or missing here. FOr key I haven't use any password while generate it. Let me know if any more info require. Thanks. -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Mar 23 16:00:29 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2NF0Ir9014529; Mon, 23 Mar 2015 16:00:28 +0100 Received: from mail-ig0-x22a.google.com (mail-ig0-x22a.google.com [IPv6:2607:f8b0:4001:c05::22a]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2NF0GVX014431 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2015 16:00:17 +0100 Received: by ignm3 with SMTP id m3so34251669ign.0 for ; Mon, 23 Mar 2015 08:00:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=ooEa42/0jFCAPEOKIlB8j5iOTSV2AF4AgEn10dhyQjA=; b=Y7DLuiwLyNfpyBcOFg/a3H617Q5M1SeoNB51Mdj+q1dSHepPHSVKVz0oygHy0OXB8I K8DrIEjmM4YN8tTXudBNiG7wMpDWZptaxYiLj+xS5NFMQ8Va4vN4o0A2j5BL9w5N2zsA Tyzd9CzBaegg+QUEJZrlGFOCuBql3jO6aD7IS3crENYlomW3XE9gA+oQjmmYkf7bNzQW 5RENgj3+WKXhslEFMpAfRNZWm3MUgan9+dx8lGCMRBCe01s3Z3yMiBTdN9GfY4ErlTBR pcjnrtTsZ4OA0/jL+Y0BJ3y1tSc7O57EGdRryrdoE57SgcodTMUIAv65f5Lc6Kg7CFDF FmQw== MIME-Version: 1.0 X-Received: by 10.50.43.198 with SMTP id y6mr15151906igl.16.1427122811641; Mon, 23 Mar 2015 08:00:11 -0700 (PDT) Received: by 10.36.25.74 with HTTP; Mon, 23 Mar 2015 08:00:11 -0700 (PDT) Date: Mon, 23 Mar 2015 17:00:11 +0200 Message-ID: Subject: LIBSSH2_ERROR_OUT_OF_BOUNDARY From: meneldor To: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============2048736799==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============2048736799== Content-Type: multipart/alternative; boundary=089e01537a963d23f10511f5ecf9 --089e01537a963d23f10511f5ecf9 Content-Type: text/plain; charset=UTF-8 Hello, i have a question about libssh2_channel_read() and LIBSSH2_ERROR_OUT_OF_BOUNDARY. When the blocking is disabled, any buffer size bigger than 0xf returns LIBSSH2_ERROR_OUT_OF_BOUNDARY error. Here is the trace of the command "ls": [libssh2] 12.046214 Conn: Writing 3 bytes on channel 3/0, stream #0 [libssh2] 12.046228 Conn: Sending 3 bytes on channel 3/0, stream_id=0 => libssh2_transport_write plain (9 bytes) 0000: 5E 00 00 00 00 00 00 00 03 : ^........ => libssh2_transport_write plain2 (3 bytes) 0000: 6C 73 0A : ls. [libssh2] 12.046279 Socket: Sent 52/52 bytes at 0x28e58f0 => libssh2_transport_write send() (52 bytes) 0000: 07 78 EF C4 34 BA 9F E1 D7 DA 3A BE 94 2A A9 46 : .x..4.....:..*.F 0010: 33 9E C8 FF F2 1A 6B 4F 00 7E 21 2E 47 2D 49 B5 : 3.....kO.~!.G-I. 0020: 6F 6F A4 97 0A E5 7E 7B E6 8C 3E 3C 8F 4A D7 F5 : oo....~{..><.J.. 0030: 6E E5 3A 6B : n.:k [libssh2] 12.046290 Conn: channel_read() wants 40000 bytes from channel 3/0 stream #0 NOTE!: channel_read() returns -37 here so i am waiting in waitsocket() [libssh2] 12.046773 Conn: channel_read() wants 40000 bytes from channel 3/0 stream #0 [libssh2] 12.046784 Socket: Recved 52/16384 bytes to 0x28e18b0+0 => libssh2_transport_read() raw (52 bytes) 0000: C0 B8 79 A6 B3 58 37 85 A9 36 36 90 D3 73 12 F0 : ..y..X7..66..s.. 0010: 4D F3 F8 31 75 CA C5 F7 38 D3 C9 48 F0 5F 04 F3 : M..1u...8..H._.. 0020: 0A 80 36 F9 11 27 18 51 D1 7C 8A F9 1B C6 21 7B : ..6..'.Q.|....!{ 0030: 2C B4 EE 13 : ,... [libssh2] 12.046796 Failure Event: -41 - transport read libssh2_channel_read returned: -41 Thanks! --089e01537a963d23f10511f5ecf9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hello,

i have a question abo= ut libssh2_channel_read() and LIBSSH2_ERROR_OUT_OF_BOUNDARY.
When= the blocking is disabled, any buffer size bigger than 0xf returns LIBSSH2_= ERROR_OUT_OF_BOUNDARY error. Here is the trace of the command "ls"= ;:
[libssh2] 12.046214 Conn: Writing 3 bytes on channel 3/0,= stream #0
[libssh2] 12.046228 Conn: Sending 3 bytes on channel 3= /0, stream_id=3D0
=3D> libssh2_transport_write plain (9 bytes)=
0000: 5E 00 00 00 00 00 00 00 =C2=A003 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: ^........
= =3D> libssh2_transport_write plain2 (3 bytes)
0000: 6C 73 0A = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 : ls.
[libssh2] 12.046279 Socket: Sent 52/52 bytes at 0x28e58f0
=3D> libssh2_transport_write send() (52 bytes)
0000: 07 78 EF= C4 34 BA 9F E1 =C2=A0D7 DA 3A BE 94 2A A9 46 : .x..4.....:..*.F
= 0010: 33 9E C8 FF F2 1A 6B 4F =C2=A000 7E 21 2E 47 2D 49 B5 : 3.....kO.~!.G= -I.
0020: 6F 6F A4 97 0A E5 7E 7B =C2=A0E6 8C 3E 3C 8F 4A D7 F5 := oo....~{..><.J..
0030: 6E E5 3A 6B =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: n.:k
[libssh2] 12.046290 = Conn: channel_read() wants 40000 bytes from channel 3/0 stream #0

NOTE!:=C2=A0channel_read() returns -37 here so i am waiting= in waitsocket()

[libssh2] 12.046773 Conn: channel= _read() wants 40000 bytes from channel 3/0 stream #0
[libssh2] 12= .046784 Socket: Recved 52/16384 bytes to 0x28e18b0+0
=3D> libs= sh2_transport_read() raw (52 bytes)
0000: C0 B8 79 A6 B3 58 37 85= =C2=A0A9 36 36 90 D3 73 12 F0 : ..y..X7..66..s..
0010: 4D F3 F8 = 31 75 CA C5 F7 =C2=A038 D3 C9 48 F0 5F 04 F3 : M..1u...8..H._..
0= 020: 0A 80 36 F9 11 27 18 51 =C2=A0D1 7C 8A F9 1B C6 21 7B : ..6..'.Q.|= ....!{
0030: 2C B4 EE 13 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0: ,...
[libssh2] 12.046796 Failure Event: -41= - transport read
libssh2_channel_read returned: -41
<= div>
Thanks!
--089e01537a963d23f10511f5ecf9-- --===============2048736799== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============2048736799==-- From libssh2-devel-bounces@cool.haxx.se Mon Mar 23 21:49:10 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2NKml55022315; Mon, 23 Mar 2015 21:49:07 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2NKmjwY022263 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 23 Mar 2015 21:48:45 +0100 Received: (qmail 32081 invoked from network); 23 Mar 2015 20:52:11 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 23 Mar 2015 20:52:11 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software To: benjamin.bouvier@alcatel-lucent.com, info@marc-hoersken.de X-Trac-Project: libssh2 Date: Mon, 23 Mar 2015 20:52:11 -0000 X-URL: https://trac.libssh2.org/ Subject: Re: [libssh2] #293: error in direct_tcpip.c example X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/293#comment:1 Message-ID: <055.678217f73d5edacfe614ac03af11a3fb@libssh2.stuge.se> References: <040.50f97f5ec9adf4d67ca239997a1097f9@libssh2.stuge.se> X-Trac-Ticket-ID: 293 In-Reply-To: <040.50f97f5ec9adf4d67ca239997a1097f9@libssh2.stuge.se> X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2NKmjwY022263 Cc: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: trac@libssh2.stuge.se, libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2NKml55022315 #293: error in direct_tcpip.c example -----------------------+-------------------- Reporter: bbo | Owner: Type: defect | Status: closed Priority: normal | Milestone: 1.5.0 Component: examples | Version: 1.4.2 Resolution: fixed | Keywords: Blocked By: | Blocks: -----------------------+-------------------- Changes (by mback2k): * status: new => closed * resolution: => fixed Comment: Fixed with commit a1e744bb5eb2f95026b1392d16a8f24f5136366b. Thanks, Jakob. -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Mar 23 21:49:10 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2NKn917022981; Mon, 23 Mar 2015 21:49:10 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2NKn1ld022585 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 23 Mar 2015 21:49:01 +0100 Received: (qmail 32388 invoked from network); 23 Mar 2015 20:52:27 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 23 Mar 2015 20:52:27 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software To: jakob@eggerapps.at, info@marc-hoersken.de X-Trac-Project: libssh2 Date: Mon, 23 Mar 2015 20:52:27 -0000 X-URL: https://trac.libssh2.org/ Subject: Re: [libssh2] #281: Possible bug in direct_tcpip.c X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/281#comment:1 Message-ID: <057.8e4eab05939965ff9c3f9f4d3573d89c@libssh2.stuge.se> References: <042.cac5eacefef2b00bdcf8792af6f27b62@libssh2.stuge.se> X-Trac-Ticket-ID: 281 In-Reply-To: <042.cac5eacefef2b00bdcf8792af6f27b62@libssh2.stuge.se> X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2NKn1ld022585 Cc: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: trac@libssh2.stuge.se, libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2NKn917022981 #281: Possible bug in direct_tcpip.c -----------------------+-------------------- Reporter: jakob | Owner: Type: defect | Status: closed Priority: normal | Milestone: 1.5.0 Component: examples | Version: 1.4.2 Resolution: fixed | Keywords: Blocked By: | Blocks: -----------------------+-------------------- Changes (by mback2k): * status: new => closed * resolution: => fixed * milestone: 1.4.3 => 1.5.0 Comment: Fixed with commit a1e744bb5eb2f95026b1392d16a8f24f5136366b. Thanks, Jakob. -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Mar 23 22:29:09 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2NLT37j016258; Mon, 23 Mar 2015 22:29:08 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2NLT1sZ016116 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 23 Mar 2015 22:29:01 +0100 Received: (qmail 6955 invoked from network); 23 Mar 2015 21:32:27 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 23 Mar 2015 21:32:27 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software To: douglas.h.masterson@boeing.com, info@marc-hoersken.de X-Trac-Project: libssh2 Date: Mon, 23 Mar 2015 21:32:27 -0000 X-URL: https://trac.libssh2.org/ Subject: Re: [libssh2] #290: segfault in diffie_hellman_sha1 X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/290#comment:1 Message-ID: <058.9905b84a9014845b333400dfcf9e7f8f@libssh2.stuge.se> References: <043.cce56a14b3bf52ccab3a2d7cd67bd8f3@libssh2.stuge.se> X-Trac-Ticket-ID: 290 In-Reply-To: <043.cce56a14b3bf52ccab3a2d7cd67bd8f3@libssh2.stuge.se> X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2NLT1sZ016116 Cc: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: trac@libssh2.stuge.se, libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2NLT37j016258 #290: segfault in diffie_hellman_sha1 ---------------------+-------------------- Reporter: mstrsn | Owner: Type: defect | Status: closed Priority: normal | Milestone: Component: crypto | Version: 1.4.2 Resolution: fixed | Keywords: Blocked By: | Blocks: ---------------------+-------------------- Changes (by mback2k): * status: new => closed * resolution: => fixed * milestone: 1.4.3 => Comment: Fixed with commit 7ca44fbd9467abbe1f54be34f94069c561ded397. Thanks for the suggestion. -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Mar 23 22:50:32 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2NLoLNU028771; Mon, 23 Mar 2015 22:50:31 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2NLoK4t028740 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 23 Mar 2015 22:50:20 +0100 Received: (qmail 9891 invoked from network); 23 Mar 2015 21:53:46 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 23 Mar 2015 21:53:46 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software To: torsten.rupp@gmx.net, daniel@haxx.se, info@marc-hoersken.de X-Trac-Project: libssh2 Date: Mon, 23 Mar 2015 21:53:46 -0000 X-URL: https://trac.libssh2.org/ Subject: Re: [libssh2] #244: scp_send may transmit not initialised memory X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/244#comment:2 Message-ID: <064.02ca369c8d5105d5aedc61190a72d1a1@libssh2.stuge.se> References: <049.3d0b86bd5582c23e69e2320401bc3593@libssh2.stuge.se> X-Trac-Ticket-ID: 244 In-Reply-To: <049.3d0b86bd5582c23e69e2320401bc3593@libssh2.stuge.se> X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2NLoK4t028740 Cc: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: trac@libssh2.stuge.se, libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2NLoLNU028771 #244: scp_send may transmit not initialised memory ---------------------------+---------------------- Reporter: torsten.rupp | Owner: Type: defect | Status: closed Priority: normal | Milestone: Component: SCP | Version: 1.4.1 Resolution: fixed | Keywords: scp_send Blocked By: | Blocks: ---------------------------+---------------------- Changes (by mback2k): * status: new => closed * resolution: => fixed Comment: Fixed with commit b99204f2896b0cdafa3ecc0736f0252ce44c32c7. Thanks. -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Mar 25 11:46:26 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2PAk0M0000900; Wed, 25 Mar 2015 11:46:22 +0100 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2PAjx3X000894 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 25 Mar 2015 11:45:59 +0100 Received: (qmail 24821 invoked from network); 25 Mar 2015 10:49:26 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 25 Mar 2015 10:49:26 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software To: benjamin.bouvier@alcatel-lucent.com, info@marc-hoersken.de X-Trac-Project: libssh2 Date: Wed, 25 Mar 2015 10:49:26 -0000 X-URL: https://trac.libssh2.org/ Subject: Re: [libssh2] #293: error in direct_tcpip.c example X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/293#comment:2 Message-ID: <055.bf1e27bb56b3f127b5c1e6940191750b@libssh2.stuge.se> References: <040.50f97f5ec9adf4d67ca239997a1097f9@libssh2.stuge.se> X-Trac-Ticket-ID: 293 In-Reply-To: <040.50f97f5ec9adf4d67ca239997a1097f9@libssh2.stuge.se> X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2PAjx3X000894 Cc: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: trac@libssh2.stuge.se, libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2PAk0M0000900 #293: error in direct_tcpip.c example -----------------------+-------------------- Reporter: bbo | Owner: Type: defect | Status: closed Priority: normal | Milestone: 1.5.0 Component: examples | Version: 1.4.2 Resolution: fixed | Keywords: Blocked By: | Blocks: -----------------------+-------------------- Comment (by bbo): I think it would be good to apply the fix in other examples which also use the libssh2_channel_write API: - tcpip-forward.c - x11.c - subsystem_netconf.c - ssh2_echo.c -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Mar 25 23:30:00 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2PMTbAt008182; Wed, 25 Mar 2015 23:29:57 +0100 Received: from smtp-gw11.han.skanova.net (smtp-gw11.han.skanova.net [81.236.55.20]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2PMTa6q008020 for ; Wed, 25 Mar 2015 23:29:36 +0100 Received: from [192.168.20.198] (81.227.138.114) by smtp-gw11.han.skanova.net (8.5.142.07) id 54E6F8320097D4B4 for libssh2-devel@cool.haxx.se; Wed, 25 Mar 2015 23:29:33 +0100 Subject: Re: SFTP slow read in libssh2 compared to SecureCRT To: libssh2-devel@cool.haxx.se references: <55101AB2.6080804@SDlabs.se> From: Lars Nordin message-id: <551336CD.7040009@SDlabs.se> Date: Wed, 25 Mar 2015 23:29:33 +0100 user-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:37.0) Gecko/20100101 Thunderbird/37.0 mime-version: 1.0 in-reply-to: <55101AB2.6080804@SDlabs.se> X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2PMTbAt008182 Hi again, I have enabled trace and gets a bunch of [libssh2] 4.816541 SFTP: Marking request ID 63 as a zombie request [libssh2] 4.816541 SFTP: Marking request ID 64 as a zombie request [libssh2] 4.816541 SFTP: Marking request ID 65 as a zombie request up to ID 266. I don't see any ID on the packages received, just: [libssh2] 0.675533 SFTP: Received packet 103 (len 2009) and then some [libssh2] 4.826541 SFTP: recv packet [libssh2] 4.826541 SFTP: Data begin - Packet Length: 28 [libssh2] 4.826541 SFTP: Received packet 101 (len 28) [libssh2] 4.826541 SFTP: Removing request ID 63 from the list of zombie requests The code to read is: do { /* read in a loop until we block */ rc = libssh2_sftp_read(sftp_handle, mem, amount); NOTE("libssh2_sftp_read returned %d\n", rc); if(rc > 0) { fwrite(mem, 1, rc, local); got += rc; NOTE("got = %d\n", got); } } while (rc > 0); and I get 2000 bytes each time. The testfile is 116K. Any thoughts? I will try to dig into the sftp-code... /Lars On 2015-03-23 14:52, Lars Nordin wrote: > Hi, > > I'm using libssh2 for different purpose, one of them is write/read > files using SFTP. I just start using version 1.5.0 and I can't get the > SFTP-read up to speed. I'm testing with a 76M file and using SecureCRT > SFTP I get 81s for the download, with libssh2 SFTP 44 minutes!!! > > If a use SCP I get download in 12s!! > > The libssh2_sftp_read() always return 2000, despite I call it with a > buffer of 100k. > > If a look at the network with wireshark and compare the data on the > network, I notice that > o with SecureCRT SFTP the server send data in 1460 sized packages, > at least 10 packets before the client send some data (up to 32 packets > I notice) > o with libssh2 the server send data in different sizes (1460 and > less, many times 1460 followed by 592) and 1-4 packets before the > client send something. > > The test is done using a OpenSSH sshd in a Linux virtual machine. > Client is Windows7 > > I copied the sftp_RW_nonblock example. > > Can I change something? > > /Lars > > > _______________________________________________ > libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Wed Mar 25 23:53:31 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2PMrP3d024361; Wed, 25 Mar 2015 23:53:29 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2PMrOLN024304 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 25 Mar 2015 23:53:24 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t2PMrO2Q024301 for ; Wed, 25 Mar 2015 23:53:24 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Wed, 25 Mar 2015 23:53:24 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: Re: SFTP slow read in libssh2 compared to SecureCRT In-Reply-To: <551336CD.7040009@SDlabs.se> Message-ID: References: <55101AB2.6080804@SDlabs.se> <551336CD.7040009@SDlabs.se> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2PMrP3d024361 On Wed, 25 Mar 2015, Lars Nordin wrote: > and I get 2000 bytes each time. The testfile is 116K. Let me explain in rough terms why you see this 2000 bytes data and how the libssh2 SFTP code works. The SFTP code will take your given buffer size and split it into 2000 bytes chunks and ask the server for such data packets, as many as can fit in your buffer. A 20000 buffer thus ends up asking for 10 such packets - at once. libssh2 will then return data back as soon as there is data to return, which initially could be a single 2000 bytes packet but over time should become a whole bunch of such packets assuming the bandwidth is good enough. This concept is used because SFTP requires ACKs for ever packet it asks for so it better ask for a whole bunch at once to suffer less RTT pains. -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Mar 26 00:19:47 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2PNJekH020741; Thu, 26 Mar 2015 00:19:46 +0100 Received: from smtp-gw21.han.skanova.net (smtp-gw21.han.skanova.net [81.236.55.21]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2PNJdHU018685 for ; Thu, 26 Mar 2015 00:19:39 +0100 Received: from [192.168.20.198] (81.227.138.114) by smtp-gw21.han.skanova.net (8.5.142.07) id 54EF7C1F0079D65D for libssh2-devel@cool.haxx.se; Thu, 26 Mar 2015 00:19:36 +0100 Subject: Re: SFTP slow read in libssh2 compared to SecureCRT To: libssh2-devel@cool.haxx.se references: <55101AB2.6080804@SDlabs.se> <551336CD.7040009@SDlabs.se> From: Lars Nordin message-id: <55134288.10609@SDlabs.se> Date: Thu, 26 Mar 2015 00:19:36 +0100 user-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:37.0) Gecko/20100101 Thunderbird/37.0 mime-version: 1.0 in-reply-to: X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2PNJekH020741 On 2015-03-25 23:53, Daniel Stenberg wrote: > On Wed, 25 Mar 2015, Lars Nordin wrote: > >> and I get 2000 bytes each time. The testfile is 116K. > > Let me explain in rough terms why you see this 2000 bytes data and how > the libssh2 SFTP code works. > > The SFTP code will take your given buffer size and split it into 2000 > bytes chunks and ask the server for such data packets, as many as can > fit in your buffer. > > A 20000 buffer thus ends up asking for 10 such packets - at once. > libssh2 will then return data back as soon as there is data to return, > which initially could be a single 2000 bytes packet but over time > should become a whole bunch of such packets assuming the bandwidth is > good enough. But the code is just returning one packet of data, ie 2000 bytes (as I get all the time) rc32 = _libssh2_ntohu32(data + 5); ... if(rc32 > 0) { /* we must return as we wrote some data to the buffer */ return rc32; the buffer is just one chunk, from your explanation I thought I would find something like: outlen +=rc32 and a buffer-pointer slider through the receive-buffer in the sftp_read() parameter. > > This concept is used because SFTP requires ACKs for ever packet it > asks for so it better ask for a whole bunch at once to suffer less RTT > pains. > My WireShark session tells different, I see a client package, and the 1 to 4 server packages, the output should be 10 client packages asking for data (or maybe only one??) and then 10 server packages (using your example) I will try to read the code and add some debug. My 76M file transfers in 44 minutes using SFTP_read, 81s using SecureCRT SFTP_read and 12s using scp... /Lars _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Mar 26 08:39:02 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2Q7ccVl024092; Thu, 26 Mar 2015 08:38:59 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2Q7camW024088 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 26 Mar 2015 08:38:36 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t2Q7caUL024084 for ; Thu, 26 Mar 2015 08:38:36 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Thu, 26 Mar 2015 08:38:36 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: Re: SFTP slow read in libssh2 compared to SecureCRT In-Reply-To: <55134288.10609@SDlabs.se> Message-ID: References: <55101AB2.6080804@SDlabs.se> <551336CD.7040009@SDlabs.se> <55134288.10609@SDlabs.se> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2Q7ccVl024092 On Thu, 26 Mar 2015, Lars Nordin wrote: > But the code is just returning one packet of data, ie 2000 bytes (as I get > all the time) If it does that, it is a bug. -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Mar 26 14:49:15 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2QDmm9p013395; Thu, 26 Mar 2015 14:49:11 +0100 Received: from mail-la0-f41.google.com (mail-la0-f41.google.com [209.85.215.41]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2QDmkJU013356 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 26 Mar 2015 14:48:46 +0100 Received: by labto5 with SMTP id to5so46058176lab.0 for ; Thu, 26 Mar 2015 06:48:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:content-type; bh=eiRKbSKQ5VbEwW7VJFDCmlHcnEXbAQwoxmefGDXTxbA=; b=Iu09Tpfui9OhnSDRPcHmXCaERf7O5kO3TIENnvCC/gxhlKC/LWObiaXSB/0VGRXgpx 80qrDx9iotSYvWzs75n6rTOS0NgEZb+gd1wcz11hKtfr6tWU21vqH+ZKr70mX5N0eUcN 4fuktFPYDPrDpC+ZeAtitmIxjwMG9O7yW4DVv8c3mvZrb+GYqRwEwJ9Ga+i0N3NwVux8 Q3y3JMJ05liWdrhNbTP1dtKf0PHW3yAUKVrFYbH6C6m4Fixr1ZESSG3HJrcO8DrtQwOi W5/CnMRuhg2awMt9kkkZj/D8kwxke+cOvZN93N9+IAhajqS2fHnBA1ENyNbCiADC8Z10 T/TA== X-Gm-Message-State: ALoCoQl1ufe9s6aZB1LVuKVa4fhpE/j5bjF6YDu6a/rL0Rgk7MyxgW9Ly6bETMqgHUTzaaPRQDwO X-Received: by 10.112.239.1 with SMTP id vo1mr13407430lbc.110.1427377722108; Thu, 26 Mar 2015 06:48:42 -0700 (PDT) From: Nitin Deokate References: <55101AB2.6080804@SDlabs.se> <551336CD.7040009@SDlabs.se> <55134288.10609@SDlabs.se> In-Reply-To: <55134288.10609@SDlabs.se> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQG8nK6WT9xiVmyt/z0Edz8zj2hDOgNBUTkPA1KzLUcCSZt7pJ0PcH1Q Date: Thu, 26 Mar 2015 19:18:41 +0530 Message-ID: <41b80ccd52d1c4c76b6df1c1cdd5ad60@mail.gmail.com> Subject: RE: SFTP slow read in libssh2 compared to SecureCRT To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2QDmm9p013395 Hi Lars, I had reported same issue around 8-9 months back. Please refer this mail thread: http://www.libssh2.org/mail/libssh2-devel-archive-2014-06/0001.shtml Is anybody already looking into this issue to fix? Thanks Nitin -----Original Message----- From: libssh2-devel [mailto:libssh2-devel-bounces@cool.haxx.se] On Behalf Of Lars Nordin Sent: Thursday, March 26, 2015 4:50 AM To: libssh2-devel@cool.haxx.se Subject: Re: SFTP slow read in libssh2 compared to SecureCRT On 2015-03-25 23:53, Daniel Stenberg wrote: > On Wed, 25 Mar 2015, Lars Nordin wrote: > >> and I get 2000 bytes each time. The testfile is 116K. > > Let me explain in rough terms why you see this 2000 bytes data and how > the libssh2 SFTP code works. > > The SFTP code will take your given buffer size and split it into 2000 > bytes chunks and ask the server for such data packets, as many as can > fit in your buffer. > > A 20000 buffer thus ends up asking for 10 such packets - at once. > libssh2 will then return data back as soon as there is data to return, > which initially could be a single 2000 bytes packet but over time > should become a whole bunch of such packets assuming the bandwidth is > good enough. But the code is just returning one packet of data, ie 2000 bytes (as I get all the time) rc32 = _libssh2_ntohu32(data + 5); ... if(rc32 > 0) { /* we must return as we wrote some data to the buffer */ return rc32; the buffer is just one chunk, from your explanation I thought I would find something like: outlen +=rc32 and a buffer-pointer slider through the receive-buffer in the sftp_read() parameter. > > This concept is used because SFTP requires ACKs for ever packet it > asks for so it better ask for a whole bunch at once to suffer less RTT > pains. > My WireShark session tells different, I see a client package, and the 1 to 4 server packages, the output should be 10 client packages asking for data (or maybe only one??) and then 10 server packages (using your example) I will try to read the code and add some debug. My 76M file transfers in 44 minutes using SFTP_read, 81s using SecureCRT SFTP_read and 12s using scp... /Lars _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Mar 26 15:30:03 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2QETtYT030085; Thu, 26 Mar 2015 15:30:01 +0100 Received: from smtp-gw11.han.skanova.net (smtp-gw11.han.skanova.net [81.236.55.20]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2QETscK030036 for ; Thu, 26 Mar 2015 15:29:54 +0100 Received: from [172.20.10.2] (95.204.235.157) by smtp-gw11.han.skanova.net (8.5.142.07) id 54E6F832009C90BB for libssh2-devel@cool.haxx.se; Thu, 26 Mar 2015 15:29:51 +0100 Subject: Re: SFTP slow read in libssh2 compared to SecureCRT To: libssh2-devel@cool.haxx.se references: <55101AB2.6080804@SDlabs.se> <551336CD.7040009@SDlabs.se> <55134288.10609@SDlabs.se> <41b80ccd52d1c4c76b6df1c1cdd5ad60@mail.gmail.com> From: Lars Nordin message-id: <551417DE.70702@SDlabs.se> Date: Thu, 26 Mar 2015 15:29:50 +0100 user-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:37.0) Gecko/20100101 Thunderbird/37.0 mime-version: 1.0 in-reply-to: <41b80ccd52d1c4c76b6df1c1cdd5ad60@mail.gmail.com> X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2QETtYT030085 On 2015-03-26 14:48, Nitin Deokate wrote: > Hi Lars, > I had reported same issue around 8-9 months back. Please refer this mail > thread: http://www.libssh2.org/mail/libssh2-devel-archive-2014-06/0001.shtml > Is anybody already looking into this issue to fix? I will try to solve this, I need better speed in SFTP download. I found a way to get more then the internal datasize, but didn't get improvment in speed. I report back when I have an solution! /Lars > Thanks > Nitin > > -----Original Message----- > From: libssh2-devel [mailto:libssh2-devel-bounces@cool.haxx.se] On Behalf Of > Lars Nordin > Sent: Thursday, March 26, 2015 4:50 AM > To: libssh2-devel@cool.haxx.se > Subject: Re: SFTP slow read in libssh2 compared to SecureCRT > > On 2015-03-25 23:53, Daniel Stenberg wrote: >> On Wed, 25 Mar 2015, Lars Nordin wrote: >> >>> and I get 2000 bytes each time. The testfile is 116K. >> Let me explain in rough terms why you see this 2000 bytes data and how >> the libssh2 SFTP code works. >> >> The SFTP code will take your given buffer size and split it into 2000 >> bytes chunks and ask the server for such data packets, as many as can >> fit in your buffer. >> >> A 20000 buffer thus ends up asking for 10 such packets - at once. >> libssh2 will then return data back as soon as there is data to return, >> which initially could be a single 2000 bytes packet but over time >> should become a whole bunch of such packets assuming the bandwidth is >> good enough. > But the code is just returning one packet of data, ie 2000 bytes (as I get > all the time) > rc32 = _libssh2_ntohu32(data + 5); > ... > if(rc32 > 0) { > /* we must return as we wrote some data to the buffer > */ > return rc32; > > the buffer is just one chunk, from your explanation I thought I would find > something like: > outlen +=rc32 > > and a buffer-pointer slider through the receive-buffer in the > sftp_read() parameter. >> This concept is used because SFTP requires ACKs for ever packet it >> asks for so it better ask for a whole bunch at once to suffer less RTT >> pains. >> > My WireShark session tells different, I see a client package, and the 1 to 4 > server packages, the output should be 10 client packages asking for data (or > maybe only one??) and then 10 server packages (using your example) > > I will try to read the code and add some debug. > > My 76M file transfers in 44 minutes using SFTP_read, 81s using SecureCRT > SFTP_read and 12s using scp... > > /Lars > > > _______________________________________________ > libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel > _______________________________________________ > libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Thu Mar 26 15:43:43 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2QEhcdS011942; Thu, 26 Mar 2015 15:43:42 +0100 Received: from mail-yh0-f41.google.com (mail-yh0-f41.google.com [209.85.213.41]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2QEhaEs011803 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 26 Mar 2015 15:43:36 +0100 Received: by yhch68 with SMTP id h68so26982675yhc.1 for ; Thu, 26 Mar 2015 07:43:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:message-id:from:to:cc:references :in-reply-to:subject:content-type:content-transfer-encoding :mime-version; bh=V+vyZyl5RjER+3xCZPMq+mPh6CmBz4xKYy5E+9bS6OY=; b=EhUYxbfqp8ztGNpWKoNVkFvREPFTz0LEmBGCeWrj2y1RWhUTEzD2i+GRi41FETj4Uo u6FCEfvxDFXD8aXWDPPx1Y+3IdSyX4w8ZunHZuCEmDxKogxbqtSIk1HU1nW1jdxPs49A 29aIBJYh1i1zhjPcspVKs7z/FlrOG3D9/8GF4qRnwG70BABemtC2PVjPrUkHQC9iXiDe HpTarmoB+pk7NJNtbuuwAskwzhkfq1euZzKesKeUqjoeLkcy1uwrvyax9L2SUryOHcG5 ADAXPfw7QTLNjaKJltRQr6VLh/SiNESMktCiEPKNDQio8LaV8Amo8i6OUj/nLRaMSgpH cCDg== X-Gm-Message-State: ALoCoQmAyWZlUK6/Tvjk+dwpV+OPteolSwwQsVzSOpe8voiCegHlSz2LhgfHiXEQderMZIo0Ryj0 X-Received: by 10.52.157.72 with SMTP id wk8mr17314568vdb.12.1427381011614; Thu, 26 Mar 2015 07:43:31 -0700 (PDT) Received: from [127.0.0.1] (ec2-54-210-254-204.compute-1.amazonaws.com. [54.210.254.204]) by mx.google.com with ESMTPSA id 4sm4260389vdr.23.2015.03.26.07.43.30 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 26 Mar 2015 07:43:30 -0700 (PDT) X-Mailer: CloudMagic Date: Thu, 26 Mar 2015 20:13:26 +0530 Message-Id: <0b47c61fdb7bd91411f44a62faf148@ip-10-0-3-72> X-Cm-Message-Id: 1427381009462762b839c5cbfafc7047a5804d0a6231115f55141b117105b1645751753 X-Cm-Draft-Id: WyJhIiwzLCJkcmFmdF9pZCIsMTQyNzM4MTAwNjUxNSwiYyIsIjE0OTY2NTY0MjU0MTkyNDA0ODQiLCJ2IiwxXQ== From: "Nitin Deokate" To: "libssh2 development" Cc: libssh2-devel@cool.haxx.se References: <55101AB2.6080804@SDlabs.se> <551336CD.7040009@SDlabs.se> <55134288.10609@SDlabs.se> <41b80ccd52d1c4c76b6df1c1cdd5ad60@mail.gmail.com> <551417DE.70702@SDlabs.se> In-Reply-To: <551417DE.70702@SDlabs.se> Subject: Re: SFTP slow read in libssh2 compared to SecureCRT MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============0591205972==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============0591205972== Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

Thanks for update Lars.

On Thu, Mar 26,= 2015 at 8:03 PM, Lars Nordin <Lars.Nordin@sdlabs.se> wrote:

On 2015-03-26 = 14:48, Nitin Deokate wrote:
> Hi Lars,
> I had reported same issue around 8-9 months back. Please refer this = mail
> thread: http://www.libssh2.org/mail/libssh2-devel-archive-2014-06/0001= .shtml
> Is anybody already looking into this issue to fix=3F
I will try to solve this, I need better speed in SFTP download. I found =
a way to get more then the internal datasize, but didn't get improvment =
in speed.

I report back when I have an solution!

/Lars
> Thanks
> Nitin
>
> -----Original Message-----
> From: libssh2-devel [mailto:libssh2-devel-bounces@cool.haxx.se] On = Behalf Of
> Lars Nordin
> Sent: Thursday, March 26, 2015 4:50 AM
> To: libssh2-devel@cool.haxx.se
> Subject: Re: SFTP slow read in libssh2 compared to SecureCRT
>
> On 2015-03-25 23:53, Daniel Stenberg wrote:
>> On Wed, 25 Mar 2015, Lars Nordin wrote:
>>
>>> and I get 2000 bytes each time. The testfile is 116K.
>> Let me explain in rough terms why you see this 2000 bytes data and= how
>> the libssh2 SFTP code works.
>>
>> The SFTP code will take your given buffer size and split it into = 2000
>> bytes chunks and ask the server for such data packets, as many as = can
>> fit in your buffer.
>>
>> A 20000 buffer thus ends up asking for 10 such packets - at once.=
>> libssh2 will then return data back as soon as there is data to = return,
>> which initially could be a single 2000 bytes packet but over = time
>> should become a whole bunch of such packets assuming the bandwidth= is
>> good enough.
> But the code is just returning one packet of data, ie 2000 bytes (as I= get
> all the time)
> rc32 =3D =5Flibssh2=5Fntohu32(data + 5);
> ...
> if(rc32 > 0) {
>            = ;           /* we must = return as we wrote some data to the buffer
> */
>            = ;           return = rc32;
>
> the buffer is just one chunk, from your explanation I thought I would = find
> something like:
> outlen +=3Drc32
>
> and a buffer-pointer slider through the receive-buffer in the
> sftp=5Fread() parameter.
>> This concept is used because SFTP requires ACKs for ever packet = it
>> asks for so it better ask for a whole bunch at once to suffer less= RTT
>> pains.
>>
> My WireShark session tells different, I see a client package, and the = 1 to 4
> server packages, the output should be 10 client packages asking for = data (or
> maybe only one=3F=3F)  and then 10 server packages (using your = example)
>
> I will try to read the code and add some debug.
>
> My 76M file transfers in 44 minutes using SFTP=5Fread, 81s using = SecureCRT
> SFTP=5Fread and 12s using scp...
>
> /Lars
>
>
> =5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F= =5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F > libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-dev= el
> =5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F= =5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F > libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-dev= el

=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F= =5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F=5F= =5F=5F=5F=5F
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

--===============0591205972== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============0591205972==-- From libssh2-devel-bounces@cool.haxx.se Fri Mar 27 02:07:38 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2R17Eri021602; Fri, 27 Mar 2015 02:07:33 +0100 Received: from mail-oi0-f43.google.com (mail-oi0-f43.google.com [209.85.218.43]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2R17B8M021556 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 27 Mar 2015 02:07:12 +0100 Received: by oicf142 with SMTP id f142so55123861oic.3 for ; Thu, 26 Mar 2015 18:07:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=CAgLnoAYkPDpUHfR0++tLtwl7pfhC2IETUn6w4mNUE8=; b=B/SnIVdWAvIHxUuU67lQlQ2xIditsw5XParM15vix/Q8O5kdwFx2XOuwLTyywbgkq5 s8uYPLtyepg/3Xv8lKocrNoPt1Uo649uHL0/xETy1zmT9Kl7IspCME3/853uBv1bjFfi 4zrXZOD1pjk2mFEpBEi6ylBZWL6VF/VcE7rlIlYKy7WhdF11SW+RrkPMaqIA/R8yINgh XMAFV1SBAC9eVOOgUv8DWmnBPrzxTrt9KofCTgl8Z6sFR2KZhGwOcrO3bOAq2l+0VkEV C2T4h0yvgXNDptO0Eny8yyYt6Bbyo0laEILta73D/9D3u4MVv9Wyb0H+AhJabAsqcRJ7 pwvg== X-Gm-Message-State: ALoCoQm/otveX97oqQ//mtA8t6mB69ez1bxLaGrtEHGUFTXqil1cSjaszCwXHbFtVLxqG2r0Z7KN MIME-Version: 1.0 X-Received: by 10.60.160.9 with SMTP id xg9mr511001oeb.43.1427418427465; Thu, 26 Mar 2015 18:07:07 -0700 (PDT) Received: by 10.76.132.196 with HTTP; Thu, 26 Mar 2015 18:07:07 -0700 (PDT) X-Originating-IP: [24.149.57.67] Date: Thu, 26 Mar 2015 21:07:07 -0400 Message-ID: Subject: llibssh2 may drop data packets beyond receive window From: "Gilbert (Gang) Chen" To: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============2050906918==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============2050906918== Content-Type: multipart/alternative; boundary=089e0112c7a650b7f005123ac0fc --089e0112c7a650b7f005123ac0fc Content-Type: text/plain; charset=UTF-8 Hi, there, I'm the developer of Acrosync , a new rsync client built from scratch, independent of the GPL'ed rsync. libssh2 is used for the ssh layer. Recently I found out that libssh2 may drop some data packets, which presents a serious problem for rsync because the data stream becomes corrupted and the error is irrecoverable. I traced that down to a place in packet.c where it says "The current receive window is full, data ignored". The root cause of this error is still unknown (the server side could have miscalculated the window size), but is it the right decision to drop packets under this circumstance, even if the Spec said so? I think keeping all data packets regardless of the receive window size would make libssh2 more resilient to bugs. Thanks, Gang --089e0112c7a650b7f005123ac0fc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi, there,

=C2=A0 =C2=A0 I'm the de= veloper of Acrosync, a new rsync clien= t built from scratch, independent of the GPL'ed rsync. =C2=A0libssh2 is= used for the ssh layer.

=C2=A0 =C2=A0 Recently I = found out that libssh2 may drop some data packets, which presents a serious= problem for rsync because the data stream becomes corrupted and the error = is irrecoverable.=C2=A0 I traced that down to a place in packet.c where it = says "The current receive window is full, data ignored".=C2=A0 Th= e root cause of this error is still unknown (the server side could have mis= calculated the window size), but is it the right decision to drop packets u= nder this circumstance, even if the Spec said so?=C2=A0 I think keeping all= data packets regardless of the receive window size would make libssh2 more= resilient to bugs.

Thanks,
Gang
--089e0112c7a650b7f005123ac0fc-- --===============2050906918== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============2050906918==-- From libssh2-devel-bounces@cool.haxx.se Fri Mar 27 08:35:49 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2R7ZRs5003185; Fri, 27 Mar 2015 08:35:46 +0100 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2R7ZO4Y003164 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 27 Mar 2015 08:35:24 +0100 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t2R7ZOPe003158 for ; Fri, 27 Mar 2015 08:35:24 +0100 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Fri, 27 Mar 2015 08:35:24 +0100 (CET) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: Re: llibssh2 may drop data packets beyond receive window In-Reply-To: Message-ID: References: User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2R7ZRs5003185 On Thu, 26 Mar 2015, Gilbert (Gang) Chen wrote: > Recently I found out that libssh2 may drop some data packets, which > presents a serious problem for rsync because the data stream becomes > corrupted and the error is irrecoverable. I traced that down to a place in > packet.c where it says "The current receive window is full, data ignored". > The root cause of this error is still unknown (the server side could have > miscalculated the window size), but is it the right decision to drop packets > under this circumstance, even if the Spec said so? Perhaps not, but then if the remote doesn't adhere to the limits where do we draw the line? The times we have seen this happen in the past it has been due to some sort of broken server. > I think keeping all data packets regardless of the receive window size would > make libssh2 more resilient to bugs. Resiliance to bad behavior however is not necessarily a good thing. It is better to fail early and hard then. So how can we tell which kind it is? -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Sun Mar 29 11:48:13 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2T9ljNH030806; Sun, 29 Mar 2015 11:48:09 +0200 Received: from mail-ie0-x230.google.com (mail-ie0-x230.google.com [IPv6:2607:f8b0:4001:c03::230]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2T9lgRE030518 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sun, 29 Mar 2015 11:47:43 +0200 Received: by ierf6 with SMTP id f6so30886491ier.2 for ; Sun, 29 Mar 2015 02:47:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=H+3DzqJedrRyP13SI8I6JtiLVbTHZdH3u89C8dEBQD0=; b=lp7bQ2ghzVlmLHn8N5b19uyAgXnRxKWUvtbqZBdT3VNWABhu9KJMRmIsQqenwSYiC/ H67ahJZNZzR3zIsWjXh8eS0AXEzs3aWTebZ20oeK+BXli1nS9LQm+BlU/2t5dBiJ3jkD k2YGlRFDBEo7l28hVVJjNfW9nq+R8B6+cCsBaLshWZeN3fTrCtXmLedtyAMeTYRkrg3e fU6eL6CyArMnlDu6HyvrnlCkXWNM9dBUDt2LfmQnVg5bO0oK5gnu3z6baXKcXaLaZgZ/ NL3vMr5R8cYJLrjC/JBuQ8LqLOpv2JWfa6m46PsERd2z+CmbXazykyUjB9mr8IQMiE6z ZkgQ== MIME-Version: 1.0 X-Received: by 10.42.25.17 with SMTP id y17mr13377864icb.68.1427622457586; Sun, 29 Mar 2015 02:47:37 -0700 (PDT) Received: by 10.36.25.74 with HTTP; Sun, 29 Mar 2015 02:47:37 -0700 (PDT) Date: Sun, 29 Mar 2015 12:47:37 +0300 Message-ID: Subject: repeated colored prompts From: meneldor To: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============1729356760==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============1729356760== Content-Type: multipart/alternative; boundary=20cf303f64ee753d8c05126a4119 --20cf303f64ee753d8c05126a4119 Content-Type: text/plain; charset=UTF-8 Hello, I stuck on a problem where when im reading the remote shell, if its colored, i receive the prompts several times. Is that related to the window size which is not properly calculated because of the not printable escape codes? Can i use any of the libssh2_channel_window_* functions to solve this problem? Thanks! --20cf303f64ee753d8c05126a4119 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hello,

I stuck on a problem where when = im reading the remote shell, if its colored, i receive the prompts several = times. Is that related to the window size which is not properly calculated = because of the not printable escape codes? Can i use any of the=C2=A0libssh= 2_channel_window_* functions to solve this problem?

Thanks!
--20cf303f64ee753d8c05126a4119-- --===============1729356760== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============1729356760==-- From libssh2-devel-bounces@cool.haxx.se Sun Mar 29 13:28:33 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2TBSMPu028727; Sun, 29 Mar 2015 13:28:32 +0200 Received: from giant.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2TBRkrL028240 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 29 Mar 2015 13:27:46 +0200 Received: from localhost (dast@localhost) by giant.haxx.se (8.14.4/8.14.4/Submit) with ESMTP id t2TBRkha028236 for ; Sun, 29 Mar 2015 13:27:46 +0200 X-Authentication-Warning: giant.haxx.se: dast owned process doing -bs Date: Sun, 29 Mar 2015 13:27:46 +0200 (CEST) From: Daniel Stenberg X-X-Sender: dast@giant.haxx.se To: libssh2 development Subject: Re: repeated colored prompts In-Reply-To: Message-ID: References: User-Agent: Alpine 2.11 (DEB 23 2013-08-11) X-fromdanielhimself: yes MIME-Version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2TBSMPu028727 On Sun, 29 Mar 2015, meneldor wrote: > I stuck on a problem where when im reading the remote shell, if its colored, > i receive the prompts several times. Is that related to the window size > which is not properly calculated because of the not printable escape codes? > Can i use any of the libssh2_channel_window_* functions to solve this > problem? Very unlikely I'd say. The windows functions are about flow control on individual SSH channels, I don't see how they would make anything with escape codes different. -- / daniel.haxx.se _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Sun Mar 29 13:50:16 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2TBo94d029404; Sun, 29 Mar 2015 13:50:15 +0200 Received: from mail-ig0-x236.google.com (mail-ig0-x236.google.com [IPv6:2607:f8b0:4001:c05::236]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2TBo7jO029142 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sun, 29 Mar 2015 13:50:08 +0200 Received: by igbqf9 with SMTP id qf9so51110594igb.1 for ; Sun, 29 Mar 2015 04:50:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=WwkKEbceS0RDsX8Zxa3FYTgkrEJlZWumrDbcLpJPtm0=; b=Qz14cTPE3YuV4xjisCYxRPnojtF7pU8ymygyI5WxNTdkmzo4oEWHz0tx0rStt4Yfi4 BwNANAKFBtSpjY+1lK6SvOoP2koA50g1ThhaVs/hBoU82GvzgFQvFgVLXac8KymMTV9B AnGAW9waRXaSLYGK7WXIQBpjdnNXEHI+ER0tgbEphGQGNYPeqXsKRoY2zKwdU1AM6HUo BAoflAllyird7Ta3Qmen1/+r1xZylv5EwcNFxn7xJAX/102d7kBgfZ7jLbepGJo9YclE n6vw13hAsovGk19VW7kO6fmq7er0QxWz7zsH5LXpVkYi115TIHGuqsrTq2SeYYfJmEsI Zsrg== MIME-Version: 1.0 X-Received: by 10.107.27.143 with SMTP id b137mr41911655iob.76.1427629802246; Sun, 29 Mar 2015 04:50:02 -0700 (PDT) Received: by 10.36.25.74 with HTTP; Sun, 29 Mar 2015 04:50:02 -0700 (PDT) In-Reply-To: References: Date: Sun, 29 Mar 2015 14:50:02 +0300 Message-ID: Subject: Re: repeated colored prompts From: meneldor To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============0132871771==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============0132871771== Content-Type: multipart/alternative; boundary=001a1140a87c3bd9cb05126bf756 --001a1140a87c3bd9cb05126bf756 Content-Type: text/plain; charset=UTF-8 I am not sure and just trying to figure out why is this happening. Only if the prompt is colored (for example libssh2_channel_request_pty() "xterm" or "ansi") so there are some escape codes. On 29.03.2015 14:30 "Daniel Stenberg" wrote: > On Sun, 29 Mar 2015, meneldor wrote: > > I stuck on a problem where when im reading the remote shell, if its >> colored, i receive the prompts several times. Is that related to the window >> size which is not properly calculated because of the not printable escape >> codes? Can i use any of the libssh2_channel_window_* functions to solve >> this problem? >> > > Very unlikely I'd say. The windows functions are about flow control on > individual SSH channels, I don't see how they would make anything with > escape codes different. > > -- > > / daniel.haxx.se > _______________________________________________ > libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel > --001a1140a87c3bd9cb05126bf756 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

I am not sure and just trying to figure out= why is this happening. Only if the prompt is colored (for example=C2=A0lib= ssh2_channel_request_pty()=C2=A0"xterm" or "ansi") so t= here are some escape codes.

On 29.03.2015 14:30 "Daniel Stenberg" = <daniel@haxx.se&= gt;=C2=A0wrote:
On Sun, 29 Mar 201= 5, meneldor wrote:

I stuck on a problem where when im reading the remote shell, if its colored= , i receive the prompts several times. Is that related to the window size w= hich is not properly calculated because of the not printable escape codes? = Can i use any of the libssh2_channel_window_* functions to solve this probl= em?

Very unlikely I'd say. The windows functions are about flow control on = individual SSH channels, I don't see how they would make anything with = escape codes different.

--

=C2=A0/ daniel.haxx.se<= /a>
_______________________________________________
libssh2-devel
http://cool.haxx.se/cgi-bin/mailman/list= info/libssh2-devel
--001a1140a87c3bd9cb05126bf756-- --===============0132871771== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============0132871771==-- From libssh2-devel-bounces@cool.haxx.se Sun Mar 29 19:10:07 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2TH9maF027568; Sun, 29 Mar 2015 19:10:05 +0200 Received: from foo.stuge.se (qmailr@foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2TH9ld0027558 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 29 Mar 2015 19:09:47 +0200 Received: (qmail 21768 invoked by uid 501); 29 Mar 2015 17:09:47 -0000 Message-ID: <20150329170947.21767.qmail@stuge.se> Date: Sun, 29 Mar 2015 19:09:47 +0200 From: Peter Stuge To: libssh2-devel@cool.haxx.se Subject: Re: repeated colored prompts Mail-Followup-To: libssh2-devel@cool.haxx.se References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2TH9maF027568 meneldor wrote: > I am not sure and just trying to figure out why is this happening. > Only if the prompt is colored (for example libssh2_channel_request_pty() > "xterm" or "ansi") so there are some escape codes. You are implementing a terminal emulator. That is completely unrelated to the terminal transport, which is what libssh2 is in this case. //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Mar 30 13:14:20 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2UBDsH1031181; Mon, 30 Mar 2015 13:14:16 +0200 Received: from mail-ie0-x22a.google.com (mail-ie0-x22a.google.com [IPv6:2607:f8b0:4001:c03::22a]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2UBDpcQ031084 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2015 13:13:52 +0200 Received: by ierf6 with SMTP id f6so47025725ier.2 for ; Mon, 30 Mar 2015 04:13:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=I4gakl1R5Eu9sKv0GgmJzCIIGMPk2b6sKySEvPvYNCY=; b=ggPMOAgq2P6Ke4j0gEe/DmieAHmbb5sZK0DfQjR1C8/ULXS/RtnW9tmj4aFIk9I631 FizSEzZOOtpBib5wr/eU0GwqfzQsKoFoNnunRwhW6JFjYlSLWrxwwExUIJ7LG3myX+N0 oX+sZgT6um2ULjAKk9GuqJ0m5XBma+5MwD3TMugfcig2tyqrL+xNJtmV1xs5jTQPngbU Q+tqSgNbnD5w7Do6keKvCHGUphKmYtfE4uIW45fFEfWQdIDdSxCK3UMURM+xlL5qR0ZU NYiAbBLBfUxeLpx/WVhIB4GmIuKQ2fcb5qVxmbdYOhOLZkpjsidavev2LodtueYFXIGK BPrw== MIME-Version: 1.0 X-Received: by 10.50.171.170 with SMTP id av10mr16762721igc.28.1427714027145; Mon, 30 Mar 2015 04:13:47 -0700 (PDT) Received: by 10.36.25.74 with HTTP; Mon, 30 Mar 2015 04:13:47 -0700 (PDT) In-Reply-To: <20150329170947.21767.qmail@stuge.se> References: <20150329170947.21767.qmail@stuge.se> Date: Mon, 30 Mar 2015 14:13:47 +0300 Message-ID: Subject: Re: repeated colored prompts From: meneldor To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============2135748863==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============2135748863== Content-Type: multipart/alternative; boundary=089e0111c0786dce9d05127f938c --089e0111c0786dce9d05127f938c Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Im not implementing terminal emulator. Just need to parse the prompt when any command finishes. Here is an example prompt when i connect to colored terminal: =1B[m=1B]0;testuser@sttest:~=07[testuser@sttest ~]$ there are some escape chars here which i didnt paste (for ex. 0x1b, etc). The things are getting ugly if i open python script which uses python's "cmd" lib for custom interactive prompt. So i open that script which "should" print the prompt "prompt> ". Then i send "use test\n". The prompt is colored. Here is the result: =1B[0;36prompt>=1B[0m u =1B[0;36prompt>=1B[0m =1B[0;36prompt>=1B[0m u =1B[0;36prompt>=1B[0m =1B[0;36prompt>=1B[0m us =1B[0;36prompt>=1B[0m =1B[0;36prompt>=1B[0m us =1B[0;36prompt>=1B[0m =1B[0;36prompt>=1B[0m use =1B[0;36prompt>=1B[0m =1B[0;36prompt>=1B[0m use =1B[0;36prompt>=1B[0m =1B[0;36prompt>=1B[0m use =1B[0;36prompt>=1B[0m =1B[0;36prompt>=1B[0m use =1B[0;36prompt>=1B[0m =1B[0;36prompt>=1B[0m use t =1B[0;36prompt>=1B[0m =1B[0;36prompt>=1B[0m use t =1B[0;36prompt>=1B[0m =1B[0;36prompt>=1B[0m use te =1B[0;36prompt>=1B[0m =1B[0;36prompt>=1B[0m use te =1B[0;36prompt>=1B[0m =1B[0;36prompt>=1B[0m use tes =1B[0;36prompt>=1B[0m =1B[0;36prompt>=1B[0m use tes =1B[0;36prompt>=1B[0m =1B[0;36prompt>=1B[0m use test =1B[0;36prompt>=1B[0m =1B[0;36prompt>=1B[0m use test I have no idea why i receive so many prompts :) If i remove the colors the prompt returns it only once as expected. Thats why i guessed that there is something wrong with the calculations of the screen/pty size/columns because of the un-printable color codes. On Sun, Mar 29, 2015 at 8:09 PM, Peter Stuge wrote: > meneldor wrote: > > I am not sure and just trying to figure out why is this happening. > > Only if the prompt is colored (for example libssh2_channel_request_pty(= ) > > "xterm" or "ansi") so there are some escape codes. > > You are implementing a terminal emulator. That is completely > unrelated to the terminal transport, which is what libssh2 is > in this case. > > > //Peter > _______________________________________________ > libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel > --089e0111c0786dce9d05127f938c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Im not implementing terminal emulator. Just need to parse = the prompt when any command finishes. Here is an example prompt when i conn= ect to colored terminal:

=1B[m=1B]0;testuser@sttest:~=07[testuser@sttest ~]$= =C2=A0

there are some escape chars here which i = didnt paste (for ex. 0x1b, etc).=C2=A0

The thing= s are getting ugly if i open python script which uses python's "cm= d" lib for custom interactive prompt. So i open that script which &quo= t;should" print the prompt "prompt> ". Then i send "= use test\n". The prompt is colored. Here is the result:

=1B[0;36prompt>=1B[0m u

=1B[0;36prompt>=1B[0m

=1B[0;36prompt>=1B[0m u

=1B[0;36prompt>=1B[0m

=1B[0;36prompt>=1B[0m us

=1B[0;36prompt>=1B[0m

=1B= [0;36prompt>=1B[0m us

=1B[0;3= 6prompt>=1B[0m

=1B[0;36promp= t>=1B[0m use

=1B[0;36prompt&g= t;=1B[0m

=1B[0;36prompt>=1B[= 0m use

=1B[0;36prompt>=1B[0m =

=1B[0;36prompt>=1B[0m use

=1B[0;36prompt>=1B[0m

=1B[0;36prompt>=1B[0m use

=1B[0;36prompt>=1B[0m

=1B[0;36prompt>=1B[0m use t

=1B[0;36prompt>=1B[0m

=1B[0;36prompt>=1B[0m use t

=1B[0;36prompt>=1B[0m

=1B[0;36prompt>=1B[0m use te

=1B[0;36prompt>=1B[0m

=1B[0;36prompt>=1B[0m use te

=1B[0;36prompt>=1B[0m

=1B[0;36prompt>=1B[0m use tes

=1B[0;36prompt>=1B[0m

= =1B[0;36prompt>=1B[0m use tes

=1B[0;36prompt>=1B[0m

=1B[0= ;36prompt>=1B[0m use test

=1B= [0;36prompt>=1B[0m

=1B[0;36prompt>=1B[0m use test


I have no idea why i receiv= e so many prompts :) If i remove the colors the prompt returns it only once= as expected. Thats why i guessed that there is something wrong with the ca= lculations of the screen/pty size/columns because of the un-printable color= codes.

=C2=A0


On Sun, Mar 29, 2015 at 8:09 PM= , Peter Stuge <peter@stuge.se> wrote:
meneldor wrote:
> I am not sure and just trying to figure out why is this happening.
> Only if the prompt is colored (for example libssh2_channel_request_pty= ()
> "xterm" or "ansi") so there are some escape codes.=

You are implementing a terminal emulator. That is completely
unrelated to the terminal transport, which is what libssh2 is
in this case.


//Peter
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/li= bssh2-devel

--089e0111c0786dce9d05127f938c-- --===============2135748863== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============2135748863==-- From libssh2-devel-bounces@cool.haxx.se Mon Mar 30 13:59:31 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2UBxOtC004619; Mon, 30 Mar 2015 13:59:30 +0200 Received: from foo.stuge.se (qmailr@foo.stuge.se [212.116.89.98]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2UBxLja004575 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 30 Mar 2015 13:59:21 +0200 Received: (qmail 15592 invoked by uid 501); 30 Mar 2015 11:59:21 -0000 Message-ID: <20150330115921.15591.qmail@stuge.se> Date: Mon, 30 Mar 2015 13:59:21 +0200 From: Peter Stuge To: libssh2-devel@cool.haxx.se Subject: Re: repeated colored prompts Mail-Followup-To: libssh2-devel@cool.haxx.se References: <20150329170947.21767.qmail@stuge.se> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-MIME-Autoconverted: from quoted-printable to 8bit by giant.haxx.se id t2UBxLja004575 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2UBxOtC004619 meneldor wrote: > Im not implementing terminal emulator. Just need to parse the prompt when > any command finishes. To do that you must implement a proper terminal emulator. > The things are getting ugly if i open python script which uses python's > "cmd" lib for custom interactive prompt. So i open that script which > "should" print the prompt "prompt> ". Then i send "use test\n". The prompt > is colored. Here is the result: > > rompt> u > rompt> > rompt> u > rompt> > rompt> us > rompt> > rompt> us .. > I have no idea why i receive so many prompts :) Because of how the terminal behaves. > i guessed that there is something wrong with the calculations of > the screen/pty size/columns because of the un-printable color codes. No, what is wrong is that you are not correctly implementing a terminal emulator. You must do that. //Peter _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Mar 30 14:13:12 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2UCD8iC003596; Mon, 30 Mar 2015 14:13:11 +0200 Received: from mail-ig0-x236.google.com (mail-ig0-x236.google.com [IPv6:2607:f8b0:4001:c05::236]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2UCD57w003313 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2015 14:13:06 +0200 Received: by igcxg11 with SMTP id xg11so70164130igc.0 for ; Mon, 30 Mar 2015 05:13:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=K2xFzJzLi/dn/pj+4aJCKWQ0dnkcrhinLE9dasE2llg=; b=ARJoKCS4s68IcPWbfnkrSmvmiAcMxTe5AtXzvNqzzarUP8vX5QE1Kp8uhH/VaD8c8d 2lOo980u8aC2erWaHXpOfUeq5yUPO89jAXETraZu+XRPb3Wcaq9U2Efs/589cf0EqmAm HjQTQY31hcpOIwjopF46M3O8HLySDbojEVW7EO+ZwWuG9lfv5qxU/0E/Z1gDUM+Er7yC Ms6ioWOZdB6Q4DESePdoZmGubckc38wY3re2LQfd73nkgs/m7UhivUBJ6GxKaLP7bTtI D3uNLq+k2htX8304FIsW56ZMv3+jgDy/mabZKlodQf6yotzXfnUS08CQNkkFtiEfsTLG lp2A== MIME-Version: 1.0 X-Received: by 10.107.29.21 with SMTP id d21mr48652019iod.11.1427717581321; Mon, 30 Mar 2015 05:13:01 -0700 (PDT) Received: by 10.36.25.74 with HTTP; Mon, 30 Mar 2015 05:13:01 -0700 (PDT) In-Reply-To: <20150330115921.15591.qmail@stuge.se> References: <20150329170947.21767.qmail@stuge.se> <20150330115921.15591.qmail@stuge.se> Date: Mon, 30 Mar 2015 15:13:01 +0300 Message-ID: Subject: Re: repeated colored prompts From: meneldor To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============0634479077==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============0634479077== Content-Type: multipart/alternative; boundary=001a1140a4fa4644740512806715 --001a1140a4fa4644740512806715 Content-Type: text/plain; charset=UTF-8 Thank you, Peter. I will search for any info about it. If anyone could point me to any tutorial/howto i will appreciate it. On Mon, Mar 30, 2015 at 2:59 PM, Peter Stuge wrote: > meneldor wrote: > > Im not implementing terminal emulator. Just need to parse the prompt when > > any command finishes. > > To do that you must implement a proper terminal emulator. > > > > The things are getting ugly if i open python script which uses python's > > "cmd" lib for custom interactive prompt. So i open that script which > > "should" print the prompt "prompt> ". Then i send "use test\n". The > prompt > > is colored. Here is the result: > > > > [0;36prompt> [0m u > > [0;36prompt> [0m > > [0;36prompt> [0m u > > [0;36prompt> [0m > > [0;36prompt> [0m us > > [0;36prompt> [0m > > [0;36prompt> [0m us > .. > > I have no idea why i receive so many prompts :) > > Because of how the terminal behaves. > > > > i guessed that there is something wrong with the calculations of > > the screen/pty size/columns because of the un-printable color codes. > > No, what is wrong is that you are not correctly implementing a > terminal emulator. You must do that. > > > //Peter > > _______________________________________________ > libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel > --001a1140a4fa4644740512806715 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thank you, Peter. I will search for any info about it. If = anyone could point me to any tutorial/howto i will appreciate it.

On Mon, Mar 30, 2015 = at 2:59 PM, Peter Stuge <peter@stuge.se> wrote:
meneldor wrote:
> Im not implementing terminal emulator. Just need to parse the prompt w= hen
> any command finishes.

To do that you must implement a proper terminal emulator.


> The things are getting ugly if i open python script which uses python&= #39;s
> "cmd" lib for custom interactive prompt. So i open that scri= pt which
> "should" print the prompt "prompt> ". Then i se= nd "use test\n". The prompt
> is colored. Here is the result:
>
>=C2=A0 [0;36prompt> [0m u
>=C2=A0 [0;36prompt> [0m
>=C2=A0 [0;36prompt> [0m u
>=C2=A0 [0;36prompt> [0m
>=C2=A0 [0;36prompt> [0m us
>=C2=A0 [0;36prompt> [0m
>=C2=A0 [0;36prompt> [0m us
..
> I have no idea why i receive so many prompts :)

Because of how the terminal behaves.


> i guessed that there is something wrong with the calculations of
> the screen/pty size/columns because of the un-printable color codes.
No, what is wrong is that you are not correctly implementing a
terminal emulator. You must do that.


//Peter

_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/li= bssh2-devel

--001a1140a4fa4644740512806715-- --===============0634479077== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============0634479077==-- From libssh2-devel-bounces@cool.haxx.se Mon Mar 30 14:33:32 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2UCXMrw022373; Mon, 30 Mar 2015 14:33:31 +0200 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2UCXLde022367 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 30 Mar 2015 14:33:21 +0200 Received: (qmail 7927 invoked from network); 30 Mar 2015 12:36:54 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 30 Mar 2015 12:36:54 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software To: dottedmag@dottedmag.net X-Trac-Project: libssh2 Date: Mon, 30 Mar 2015 12:36:54 -0000 X-URL: https://trac.libssh2.org/ Subject: [libssh2] #296: OpenSSL picked up even with `--enable-gcrypt` X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/296 Message-ID: <046.15b246dbeaf36a0d48579881fcbca67d@libssh2.stuge.se> X-Trac-Ticket-ID: 296 X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2UCXLde022367 Cc: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: trac@libssh2.stuge.se, libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2UCXMrw022373 #296: OpenSSL picked up even with `--enable-gcrypt` -----------------------+------------------ Reporter: dottedmag | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: misc | Version: Keywords: | Blocked By: Blocks: | -----------------------+------------------ If there are OpenSSL headers/library on the system, it gets picked up automatically even if `--enable-gcrypt` is specified. One has to explicitly pass `--disable-openssl` to get `gcrypt`-enabled build. -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Mar 30 14:34:26 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2UCYP4L023121; Mon, 30 Mar 2015 14:34:26 +0200 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2UCYO5g023112 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 30 Mar 2015 14:34:24 +0200 Received: (qmail 8248 invoked from network); 30 Mar 2015 12:37:57 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 30 Mar 2015 12:37:57 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software To: dottedmag@dottedmag.net X-Trac-Project: libssh2 Date: Mon, 30 Mar 2015 12:37:57 -0000 X-URL: https://trac.libssh2.org/ Subject: [libssh2] #297: `libssh2_{md5, sha1}{, _init}` symbols are exposed in OpenSSL build X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/297 Message-ID: <046.447a6d51c4e53de3286fd4a097b0e51d@libssh2.stuge.se> X-Trac-Ticket-ID: 297 X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2UCYO5g023112 Cc: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: trac@libssh2.stuge.se, libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2UCYP4L023121 #297: `libssh2_{md5,sha1}{,_init}` symbols are exposed in OpenSSL build -----------------------+------------------ Reporter: dottedmag | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: misc | Version: Keywords: | Blocked By: Blocks: | -----------------------+------------------ If libssh2 is built with OpenSSL, then internal symbols `libssh2_md5_init`, `libssh2_md5`, `libssh2_sha1_init`, `libssh2_sha1` are exposed. `gcrypt`-based builds do not expose them. -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Mar 30 15:22:45 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2UDMVLs004649; Mon, 30 Mar 2015 15:22:43 +0200 Received: from mail-ie0-x229.google.com (mail-ie0-x229.google.com [IPv6:2607:f8b0:4001:c03::229]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2UDMSb0004509 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2015 15:22:29 +0200 Received: by ierf6 with SMTP id f6so49904595ier.2 for ; Mon, 30 Mar 2015 06:22:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=f5MQmKqtk1TFtSqOiCIn2FvhqFH6fmLG0Dce+FSUJ2A=; b=cj8Na7WvBoB+0HcaaTMGLRpG+sntNEHZe1Xhsf2LeiJgBQoJz02sguKb70MnhaefY0 hEkw+IYI8FQeV5OA/pgvbDGzcJwZXxa6tJ8CqWv5FcDxCgdZysYioJUR+i5LFpqVK581 ks0JAlx0NckX7HGUngVem2CAG1gRZ7IXsH7baOswKcouPNreWKt6vDfLllIjyB+MSpmk M6jtSr3SKiJN8aF8ESzVabFMM1KFI8sT5ouX5DOi+86LQUjHG4aX0+kb3nNJqdNSnlvq i7HsX6yp/Bmo22HVJUmOoD4pB27QaaB/W4ld2NBVUod2Ew4qqp3RREXADdDO9I5RyGBr /hnQ== MIME-Version: 1.0 X-Received: by 10.42.226.69 with SMTP id iv5mr52899593icb.58.1427721742703; Mon, 30 Mar 2015 06:22:22 -0700 (PDT) Received: by 10.36.25.74 with HTTP; Mon, 30 Mar 2015 06:22:22 -0700 (PDT) Date: Mon, 30 Mar 2015 16:22:22 +0300 Message-ID: Subject: libssh2_sftp_init() returns LIBSSH2_ERROR_EAGAIN forever From: meneldor To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: multipart/mixed; boundary="===============0268175090==" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" --===============0268175090== Content-Type: multipart/alternative; boundary=001a11c319a64fe2170512815fbd --001a11c319a64fe2170512815fbd Content-Type: text/plain; charset=UTF-8 Hi again :) Im trying to open LIBSSH2_SFTP session in non-blocking mode but it always returns LIBSSH2_ERROR_EAGAIN. Here is the code: do { m_sftp_session = libssh2_sftp_init(m_ssh_session); if (!m_sftp_session) { if (libssh2_session_last_errno(m_ssh_session) == LIBSSH2_ERROR_EAGAIN){ qDebug() << "waitsocket"; waitsocket(); } else{ qDebug() << "Unable to init SFTP session"; return false; } } } while (!m_sftp_session); *m_ssh_session *is valid LIBSSH2_SESSION which i use for libssh2_channel_open_session(m_ssh_session) without any problem. Here is the trace log: http://pastebin.com/2uK6tqvB --001a11c319a64fe2170512815fbd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi again :)

Im trying to open=C2=A0LIBS= SH2_SFTP session in non-blocking mode but it always returns LIBSSH2_ERROR_E= AGAIN. Here is the code:

=C2=A0 =C2=A0 =C2=A0do {
=C2=A0 = =C2=A0 =C2=A0 =C2=A0 m_sftp_session =3D libssh2_sftp_init(m_ssh_session);=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (!m_sftp_session) =C2=A0{
=C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (libssh2_session_last_errno(m_ssh_session) = =3D=3D LIBSSH2_ERROR_EAGAIN){
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 qDebug() << "waitsocket";
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 waitsocket();
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 } else{
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 qDebug() << "Unable to init SFTP session&qu= ot;;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return fals= e;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 }
=C2=A0 =C2=A0 } while (!m_sftp_session);
m_ssh_session is valid=C2=A0LIBSSH2_SESSION which i use for=C2= =A0libssh2_channel_open_session(m_ssh_session) without any problem.=C2=A0
Here is the trace log:=C2=A0http://pastebin.com/2uK6tqvB


=


--001a11c319a64fe2170512815fbd-- --===============0268175090== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlic3NoMi1k ZXZlbCBodHRwOi8vY29vbC5oYXh4LnNlL2NnaS1iaW4vbWFpbG1hbi9saXN0aW5mby9saWJzc2gy LWRldmVsCg== --===============0268175090==-- From libssh2-devel-bounces@cool.haxx.se Mon Mar 30 15:27:06 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2UDR5UC012053; Mon, 30 Mar 2015 15:27:05 +0200 Received: from earth.stuge.se (earth.stuge.se [212.116.89.126]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2UDR37w012041 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 30 Mar 2015 15:27:03 +0200 Received: (qmail 28553 invoked from network); 30 Mar 2015 13:30:36 -0000 Received: from unknown (HELO earth.stuge.se) (127.0.0.1) by localhost with SMTP; 30 Mar 2015 13:30:36 -0000 MIME-Version: 1.0 From: "libssh2 Trac" X-Trac-Version: 1.0dev Precedence: bulk Auto-Submitted: auto-generated X-Mailer: Trac 1.0dev, by Edgewall Software To: dottedmag@dottedmag.net X-Trac-Project: libssh2 Date: Mon, 30 Mar 2015 13:30:36 -0000 X-URL: https://trac.libssh2.org/ Subject: Re: [libssh2] #296: OpenSSL picked up even with `--enable-gcrypt` X-Trac-Ticket-URL: https://trac.libssh2.org/ticket/296#comment:1 Message-ID: <061.9090167d675298ee6b284072d5f54f3a@libssh2.stuge.se> References: <046.15b246dbeaf36a0d48579881fcbca67d@libssh2.stuge.se> X-Trac-Ticket-ID: 296 In-Reply-To: <046.15b246dbeaf36a0d48579881fcbca67d@libssh2.stuge.se> X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2UDR37w012041 Cc: libssh2-devel@cool.haxx.se X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: trac@libssh2.stuge.se, libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2UDR5UC012053 #296: OpenSSL picked up even with `--enable-gcrypt` ------------------------+------------------- Reporter: dottedmag | Owner: Type: defect | Status: new Priority: normal | Milestone: Component: misc | Version: 1.5.0 Resolution: | Keywords: Blocked By: | Blocks: ------------------------+------------------- Changes (by dottedmag): * version: => 1.5.0 -- Ticket URL: libssh2 C library for writing portable SSH2 clients _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Mar 30 17:22:35 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2UFMDrf032272; Mon, 30 Mar 2015 17:22:29 +0200 Received: from smtp-gw21.han.skanova.net (smtp-gw21.han.skanova.net [81.236.55.21]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2UFMClw032244 for ; Mon, 30 Mar 2015 17:22:12 +0200 Received: from [192.168.20.198] (81.227.138.114) by smtp-gw21.han.skanova.net (8.5.142.07) id 54EF7C1F008DA5DD for libssh2-devel@cool.haxx.se; Mon, 30 Mar 2015 17:22:08 +0200 To: libssh2 development Subject: Github commits From: Lars Nordin message-id: <55196A1D.5080309@SDlabs.se> Date: Mon, 30 Mar 2015 17:22:05 +0200 user-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:37.0) Gecko/20100101 Thunderbird/37.0 mime-version: 1.0 X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2UFMDrf032272 Hi, I now started to commit the changes I made to improve speed in SFTP_read. My first try was a change in openssl.c, the #ifdef LIBSSH2_DSA was needed on more places in the code (yes, I work with an openSSL without DSA) My name on GitHub is LarsNordin-LNdata Should I just continue to add the rest of the patches or... /Lars _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Mar 30 17:41:25 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2UFfHSs011827; Mon, 30 Mar 2015 17:41:23 +0200 Received: from mail-wg0-x235.google.com (mail-wg0-x235.google.com [IPv6:2a00:1450:400c:c00::235]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2UFfF4l011787 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2015 17:41:15 +0200 Received: by wgdm6 with SMTP id m6so179814135wgd.2 for ; Mon, 30 Mar 2015 08:41:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=nUKuG8nPBtEqF/1GN3sPvEDEUssY5q1CzqidVYCeFME=; b=G/R5tUkLzrdSdlkSPqhGqNDKKHSe0sOkv7jHXu/P81AR0EurmkrFQptlZ2PKYUsJwI BOFY1eeReNN/o3+c+SFKAMQVdRp9idtz+UbJZxqAk8sOFTbbGDE5g/jWI5cuvDsrJHTy /7YFTpBZQLtj0b6rB2aEcCarKc9+hPDVsvSg/flQsjE1BS1KwKBIpu/zfV0yGpP1uJ2r cMyrVF5BFkHcCtlgGLQu1ip1LkFPC/xkGlAT2BCn55mianC0RAsUrA+gJpZeqGxv1QFv ITMGbqi5NVzXeqRBNklSwCmtn+qaPlPI2e56vnrZq+VJh83o/h7eILM+JxW4g52OU1mo a44w== MIME-Version: 1.0 X-Received: by 10.180.189.69 with SMTP id gg5mr23540768wic.93.1427730071506; Mon, 30 Mar 2015 08:41:11 -0700 (PDT) Received: by 10.194.74.232 with HTTP; Mon, 30 Mar 2015 08:41:11 -0700 (PDT) In-Reply-To: <55196A1D.5080309@SDlabs.se> References: <55196A1D.5080309@SDlabs.se> Date: Mon, 30 Mar 2015 16:41:11 +0100 X-Google-Sender-Auth: Ehow5H8vsH1GZ50fhHnXUS4lDj8 Message-ID: Subject: Re: Github commits From: Alexander Lamaison To: libssh2 development X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2UFfHSs011827 On 30 March 2015 at 16:22, Lars Nordin wrote: > > I now started to commit the changes I made to improve speed in SFTP_read. > > My first try was a change in openssl.c, the #ifdef LIBSSH2_DSA was needed on > more places in the code (yes, I work with an openSSL without DSA) > > My name on GitHub is LarsNordin-LNdata > > Should I just continue to add the rest of the patches or... You'll need to create pull requests for your patches, or send them to this list, if you want us to find them. We aren't actively monitoring forks. On something as fundamental as the SFTP-read mechanism, it would also be good to explain your proposed changed here on this list. Apologies if you've already done this and I missed it. Alex -- Swish - Easy SFTP for Windows Explorer (http://www.swish-sftp.org) _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel From libssh2-devel-bounces@cool.haxx.se Mon Mar 30 17:58:39 2015 Return-Path: Received: from www.haxx.se (localhost.localdomain [127.0.0.1]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2UFwWht019312; Mon, 30 Mar 2015 17:58:38 +0200 Received: from smtp-gw11.han.skanova.net (smtp-gw11.han.skanova.net [81.236.55.20]) by giant.haxx.se (8.14.4/8.14.4/Debian-7) with ESMTP id t2UFwUKh019221 for ; Mon, 30 Mar 2015 17:58:30 +0200 Received: from [192.168.20.198] (81.227.138.114) by smtp-gw11.han.skanova.net (8.5.142.07) id 54E6F83200ABD67F for libssh2-devel@cool.haxx.se; Mon, 30 Mar 2015 17:58:26 +0200 Subject: Re: Github commits To: libssh2-devel@cool.haxx.se references: <55196A1D.5080309@SDlabs.se> From: Lars Nordin message-id: <5519729F.8080106@SDlabs.se> Date: Mon, 30 Mar 2015 17:58:23 +0200 user-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:37.0) Gecko/20100101 Thunderbird/37.0 mime-version: 1.0 in-reply-to: X-BeenThere: libssh2-devel@cool.haxx.se X-Mailman-Version: 2.1.18 Precedence: list List-Id: libssh2 development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: libssh2 development Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: libssh2-devel-bounces@cool.haxx.se Sender: "libssh2-devel" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by giant.haxx.se id t2UFwWht019312 On 2015-03-30 17:41, Alexander Lamaison wrote: > On 30 March 2015 at 16:22, Lars Nordin wrote: >> I now started to commit the changes I made to improve speed in SFTP_read. >> >> My first try was a change in openssl.c, the #ifdef LIBSSH2_DSA was needed on >> more places in the code (yes, I work with an openSSL without DSA) >> >> My name on GitHub is LarsNordin-LNdata >> >> Should I just continue to add the rest of the patches or... > You'll need to create pull requests for your patches, or send them to > this list, if you want us to find them. We aren't actively monitoring > forks. I started with two simple changes, one with more LIBSSH2_DSA #ifdefs in openssl.c and a change in the openssh.h, the ifdef is OPENSSL_NO_BF. I hope my pull request works! > On something as fundamental as the SFTP-read mechanism, it would also > be good to explain your proposed changed here on this list. Apologies > if you've already done this and I missed it. No, I just asked about how it should work, I have increased the speed! I make a separate post about the changes > Alex > > -- > Swish - Easy SFTP for Windows Explorer (http://www.swish-sftp.org) > _______________________________________________ > libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel _______________________________________________ libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel