Subject: Re: git tag for libssh2-1.8.0

Re: git tag for libssh2-1.8.0

From: Afschin Hormozdiary <Afschin.Hormozdiary_at_Sophos.com>
Date: Fri, 2 Nov 2018 10:27:55 +0000

The tag on github associates version 1.8.0 with 30e9c13. Here is a link to the libssh2.h at 30e9c13.
https://github.com/libssh2/libssh2/blob/30e9c1347e3b8baa2951db612f05e6d87fc8e2f2/include/libssh2.h#L54

There must be something that changes this macro definition between commit and tarball packaging.
Here it is:
https://github.com/libssh2/libssh2/commit/d75e9c5c0db75e87715d6fdd410e76296b53b886#diff-d0e781ac3006f6ad820471d567561762

The version macros have not been updated between 1.7.0 and 1.8.1 git-wise but are correct in the tarballs. That means if someone
builds from the git source the version info was wrong until aforementioned commit.

´╗┐On 11/2/18, 11:16 AM, "Afschin Hormozdiary" <Afschin.Hormozdiary_at_Sophos.com> wrote:

    Hi Daniel,
    
    thanks for your reply. "The tag in the git repo is the exact state of the files when the release was generated".
    Please verify this:
> git checkout libssh2-1.8.0
    HEAD is now at 30e9c13... RELEASE-NOTES: adjusted for 1.8.0
>
> grep LIBSSH2_VERSION_MINOR include/libssh2.h
    #define LIBSSH2_VERSION_MINOR 7
>
    
    This is what i get after cloning the git repo git_at_github.com:libssh2/libssh2.git.
    And this differs from what i can find in the same header file taken from the 1.8.0 tarball.
    
    This is not what i expected and not something that i am used to from other projects.
    Just wanted to point you to this. Maybe i fooled myself somehow, but to me it seems to be
    inconsistent.
    
    Cheers,
    Afschin
    
    On 11/2/18, 10:58 AM, "libssh2-devel on behalf of Daniel Stenberg" <libssh2-devel-bounces_at_cool.haxx.se on behalf of daniel_at_haxx.se> wrote:
    
        On Fri, 2 Nov 2018, Afschin Hormozdiary wrote:
        
> Could you please correct this version insonsistency or let me know if this
> is intentionally?
        
        The official libssh2 releases are the tarballs on the web page that also are
        attached to the release tags on github. The tarballs are also signed (by me)
        to allow everyone to verify their authenticity.
        
        The tag in the git repo is the exact state of the files when the release was
        generated. It is consistent and reproducible.
        
        --
        
          / daniel.haxx.se
        _______________________________________________
        libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
        
    
    

_______________________________________________
libssh2-devel https://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2018-11-02