Subject: Re: curl / libssh2 sftp write performance (with patch)

Re: curl / libssh2 sftp write performance (with patch)

From: Peter Stuge <>
Date: Tue, 28 Aug 2018 10:08:31 +0000

Daniel Jeliński wrote:
> Limiting the number of outstanding packets sounds reasonable

Can you use channel windowing in the transport protocol here? If not, why not?

> > Can we make users opt-in to this and if not, do like before?
> How would you suggest to implement that? I don't see any existing
> mechanism that could be used for this

Add a new API which would be used to enable the new behavior. The API
should probably not be too specific to this behavior, but should also
not be too generic.

Also consider whether a new API really belongs on SFTP level or perhaps
rather on channel level.

> I could implement this as a new set of functions duplicating the
> existing functionality

No, don't do that.

Received on 2018-08-28