Subject: Re: Patches for Windows, Wincng, Visual Studio

Re: Patches for Windows, Wincng, Visual Studio

From: Marc Hoersken <>
Date: Mon, 19 May 2014 20:50:29 +0200

On 19.05.2014 20:43, Bob Kast wrote:
> If it is included outside of that ifdef, then the linker will be told to
> link with those libraries even though wincng is not being compiled in (not a
> disaster, but not necessary).

Of course I would have put them inside an #ifdef LIBSSH2_WINCNG within
the header file. ;-)

> This pragma inserts a comment record into the object file generated by the
> compiler that tells the linker to add that library to the libs being linked.
> Think of it more as executable code. It is not something that would go into
> a header file.

Thanks, that makes sense. Merged and pushed with a slight modification
to only add crypt32.lib if HAVE_LIBCRYPT32 is defined and therefore
wincrypt.h is included, even though that will probably always be the
case on Windows.
Received on 2014-05-19