Subject: Re: timeouts in libssh2 blocking-mode

Re: timeouts in libssh2 blocking-mode

From: Peter Stuge <peter_at_stuge.se>
Date: Tue, 3 May 2011 02:48:25 +0200

Matt Lilley wrote:
>> Btw, it doesn't make sense to have while(1) immediately preceded by a
>> conditional break IMO.
> Agreed, changed.
..
> +++ b/src/session.h
> @@ -53,15 +53,16 @@
..
> - if(rc) \
> - break; \
> - } while(1)
..
> + } while(rc); \

I think you inverted the logic. Add the ! I wrote. :)

//Peter
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2011-05-03