Subject: RE: win32 build issue

RE: win32 build issue

From: Grubsky Grigory <g.grubsky_at_securitycode.ru>
Date: Fri, 4 Jun 2010 03:16:07 +0400

Hi GŁn

-----Original Message-----
From: libssh2-devel-bounces_at_cool.haxx.se [mailto:libssh2-devel-bounces_at_cool.haxx.se] On Behalf Of Guenter
Sent: Thursday, June 03, 2010 8:00 AM
To: libssh2-devel_at_cool.haxx.se
Subject: Re: win32 build issue

>Am 03.06.2010 03:54, schrieb Grubsky Grigory:
>> 1>..\src\scp.c(744): warning C4244: '=' : conversion from 'long' to 'unsigned short', possible loss of data
>can you please try if this works, or if it causes new warnings:
>
>diff --git a/src/libssh2_priv.h b/src/libssh2_priv.h
>index fd570e4..4020059 100644
>--- a/src/libssh2_priv.h
>+++ b/src/libssh2_priv.h
>@@ -895,7 +895,7 @@ struct _LIBSSH2_SESSION
> unsigned long scpRecv_command_len;
> unsigned char scpRecv_response[LIBSSH2_SCP_RESPONSE_BUFLEN];
> unsigned long scpRecv_response_len;
>- long scpRecv_mode;
>+ mode_t scpRecv_mode;
> #if defined(HAVE_LONGLONG) && defined(HAVE_STRTOLL)
> /* we have the type and we can parse such numbers */
> long long scpRecv_size;
>@@ -904,8 +904,8 @@ struct _LIBSSH2_SESSION
> long scpRecv_size;
> #define scpsize_strtol strtol
> #endif
>- long scpRecv_mtime;
>- long scpRecv_atime;
>+ time_t scpRecv_mtime;
>+ time_t scpRecv_atime;
> char *scpRecv_err_msg;
> long scpRecv_err_len;
> LIBSSH2_CHANNEL *scpRecv_channel;

The first part leads to an error - there are not mode_t in VC headers.
Field st_mode is declared as unsigned short in all stat-structs (stat, _stat32, _stat32i64, _stat64i32, _stat64).
Second part (long to time_t) has not affect.

Regards,
Grigory
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2010-06-04