Subject: Re: [libssh2] #164: Knownhost API handles comments badly

Re: [libssh2] #164: Knownhost API handles comments badly

From: libssh2 Trac <trac_at_libssh2.stuge.se>
Date: Sun, 14 Mar 2010 20:03:25 -0000

#164: Knownhost API handles comments badly
-----------------------+----------------------------------------------------
 Reporter: alamaison | Owner:
     Type: defect | Status: new
 Priority: normal | Milestone: 1.2.5
Component: API | Version: 1.2.4
 Keywords: knownhost | Blocking:
Blockedby: |
-----------------------+----------------------------------------------------
Changes (by alamaison):

  * milestone: => 1.2.5

Comment:

 Committed a fix for this: [9abf81de97f5496e904eb855170026dd9fd1a4b8].

 It leaves most of the API unchanged but adds a new function
 `libssh2_knowhost_addc` that takes an optional comment and changes
 `readline` to use it.

 The fix isn't perfect as parsing the comment is harder than it seems.
 `ssh-rsa` and `ssh-dsa` keys can't contain spaces but `rsa1` blocks can.
 As we don't support checking these anyway it shouldn't matter. 

-- 
Ticket URL: <http://libssh2.stuge.se/ticket/164#comment:6>
libssh2 <http://libssh2.stuge.se/>
C library for writing portable SSH2 clients
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2010-03-14