Subject: Re: [libssh2] #164: Knownhost API handles comments badly

Re: [libssh2] #164: Knownhost API handles comments badly

From: libssh2 Trac <trac_at_libssh2.stuge.se>
Date: Tue, 09 Mar 2010 21:43:24 -0000

#164: Knownhost API handles comments badly
-----------------------+----------------------------------------------------
 Reporter: alamaison | Owner:
     Type: defect | Status: new
 Priority: normal | Milestone:
Component: API | Version: 1.2.4
 Keywords: knownhost | Blocking:
Blockedby: |
-----------------------+----------------------------------------------------

Comment(by bagder):

 Replying to [comment:4 alamaison]:
> Replying to [comment:3 bagder]:
> > Right, we would use a new version of libssh2_knownhost_add() that
 supports the comment part.
>
> Do you mean adding an extra parameter to `add` (this wouldn't change the
 ABI, right?)

 I'm quite sure we can't safely add arguments without changing the ABI. So
 I meant:

> or adding a new version of `add`, say
 `libssh2_knownhost_add_with_comment` that
> takes a separate comment parameter.

 That's what I meant. And when we add that, we mark the first one as
 deprecated and we add a mention in the TODO to remove it completely at the
 next soname bump. 

-- 
Ticket URL: <http://libssh2.stuge.se/ticket/164#comment:5>
libssh2 <http://libssh2.stuge.se/>
C library for writing portable SSH2 clients
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2010-03-09