Subject: Re: [libssh2] #164: Knownhost API handles comments badly

Re: [libssh2] #164: Knownhost API handles comments badly

From: libssh2 Trac <trac_at_libssh2.stuge.se>
Date: Sun, 07 Mar 2010 22:40:58 -0000

#164: Knownhost API handles comments badly
-----------------------+----------------------------------------------------
 Reporter: alamaison | Owner:
     Type: defect | Status: new
 Priority: normal | Milestone:
Component: API | Version: 1.2.4
 Keywords: knownhost | Blocking:
Blockedby: |
-----------------------+----------------------------------------------------

Comment(by alamaison):

 Replying to [comment:1 bagder]:
> Surely libssh2_knownhost_readline() can be fixed to also parse and store
 the comment internally, separately from the key and that won't break any
 ABI.

 `libssh2_knownhost_readline` eventually delegates to
 `libssh2_knownhost_add`. I suppose we could replace that with a call to
 an internal version of `add` that take a comment parameter or we could
 change `add` so that it parses the key into two pieces. But we're still
 left with `libssh2_knownhost_get` that returns the key and the comment as
 one. 

-- 
Ticket URL: <http://libssh2.stuge.se/ticket/164#comment:2>
libssh2 <http://libssh2.stuge.se/>
C library for writing portable SSH2 clients
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2010-03-07