Subject: Re: ssh-agent support

Re: ssh-agent support

From: Peter Stuge <peter_at_stuge.se>
Date: Mon, 21 Dec 2009 12:09:16 +0100

Daiki Ueno wrote:
> FWIW, I have tried to minimize the number of patches using git
> rebase -i agaist the current origin/master (after the
> example/simple -> example move).
> Now there are only three patches orthogonal each other:
>
> http://www.unixuser.org/~ueno/software/libssh2-agent/

Nice!

Please check the logic in libssh2_agent_connect() ? It looks like it
will return failure if _any_ of possibly several supported backends
are not running, rather than failing when _none_ of them are
reachable? Also the comment mentions NULL, but code returns 0.

I think this can be pushed.

//Peter
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2009-12-21