Subject: Re: ifdef in Makefile.inc?

Re: ifdef in Makefile.inc?

From: Simon Josefsson <simon_at_josefsson.org>
Date: Mon, 07 Sep 2009 17:39:31 +0200

Guenter <lists_at_gknw.net> writes:

> Hi,
> Daniel Stenberg schrieb:
>> I think that's a good idea. It will also make it easier for non
>> configure-based systems to alter what to build: just build all files and
>> set the defines correctly to alter the build...
> yup - anybody already on it, or should I start changing it this way?
> I would then use in the sources libgcrypt.c and pem.c:
>
> #include <libssh2_config.h>
> #ifdef LIBSSH2_LIBGCRYPT
> ...
> #endif /* LIBSSH2_LIBGCRYPT */
>
> and in openssl.c:
>
> #include <libssh2_config.h>
> #ifndef LIBSSH2_LIBGCRYPT
> ...
> #endif /* !LIBSSH2_LIBGCRYPT */
>
> that's ok?

No objection from me, although I suggest you use HAVE_LIBSSL and
HAVE_LIBGCRYPT as the symbols to check -- configure already checks and
sets those variables as appropriate.

/Simon
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2009-09-07