Subject: Re: libssh2 master 8dabb1c... added knownhost.c to makefiles.

Re: libssh2 master 8dabb1c... added knownhost.c to makefiles.

From: Tor Arntsen <tor_at_spacetec.no>
Date: Mon, 7 Sep 2009 13:18:38 +0200

On Wed, Sep 2, 2009 at 22:39, Daniel Stenberg<daniel_at_haxx.se> wrote:
> On Wed, 2 Sep 2009, libssh2_at_git.stuge.se wrote:
>
>> commit 8dabb1c5eb2b988612ee12e032ca262c4aed2a2a
>> Author: Hacki <hacki_at_linux-nt36.site>
>> Date:   Wed Sep 2 20:03:27 2009 +0200
>>
>>   added knownhost.c to makefiles.
>
> I lack info about who did the commit. These mails only tell the author of
> the patch that someone committed, but it doesn't tell who did the commit -
> which is very useful information ...

As I understand it there's a server that generates commit messages?
Maybe that one could be changed to use another option so that the
committer ID is shown: git log -s --pretty=raw will do it, for
example.

git show -s --pretty=raw 2a142a65249568134010c7b5fef344c8f6b4c64b
commit 2a142a65249568134010c7b5fef344c8f6b4c64b
tree 0ef1e2173e9061e483f0b46a5e762ed72270954b
parent afcf63b43313b7144b9cb67d159122ab2c0215d2
author Tor Arntsen <tor_at_spacetec.no> 1244128620 +0200
committer Daniel Stenberg <daniel_at_haxx.se> 1244132429 +0200

    Ignore generated files

For the one in question it seems the commiter and author are the same:

git show -s --pretty=raw 8dabb1c5eb2b988612ee12e032ca262c4aed2a2a
commit 8dabb1c5eb2b988612ee12e032ca262c4aed2a2a
tree d388806a55f664425106732a3fe00cc911041962
parent 0d6aaa1f56c54ed3f748fe7cd293d9afd729d407
author Hacki <hacki_at_linux-nt36.site> 1251914607 +0200
committer Hacki <hacki_at_linux-nt36.site> 1251914607 +0200

    added knownhost.c to makefiles.

When commiting other people's changes (in my own other projects) I
often use the 'signed-off-by' feature, e.g.
git commit --signoff
which will add a 'Signed-off by: ' message to the commit log. It's BTW
possible to also specify
 --author="Name LastName <email address>"
with git commit, for those cases where you commit someone else's patch
without having a git-format-patch - compatible (for git-am) patch
which would set Author correctly.

-Tor
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Received on 2009-09-07