Re: [libssh2] memory leak in kex.c

On Jun 14, 2007, at 11:18 PM, Gutjahr, Troy wrote:

> I found a tricky memory leak in kex.c. The following lines of code
> appear at the end of the function
> libssh2_kex_method_diffie_hellman_group_exchange_sha1_key_exchange.
>
> It's obvious, right? :-}
>
> _libssh2_bn_free(key_state->g);
> key_state->p = NULL;
> _libssh2_bn_free(key_state->p);
> key_state->g = NULL;
>
>
> Interestingly, the same bug does not appear in the
> other ...key_exchange
> functions.

Thanks, committed.

--
/"\   ASCII Ribbon Campaign  .
\ / - NO HTML/RTF in e-mail  .
  X  - NO Word docs in e-mail .
/ \ -----------------------------------------------------------------
                      http://www.FreeBSD.org     The Power to Serve
jim@TheHousleys.Net  http://www.TheHousleys.net
---------------------------------------------------------------------
Q: Because it reverses the logical flow of conversation.
A: Why is putting a reply at the top of the message frowned upon?
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
libssh2-devel mailing list
libssh2-devel_at_lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libssh2-devel