Subject: Re: [libssh2] libssh2 0.15 release candidate

Re: [libssh2] libssh2 0.15 release candidate

From: Simon Josefsson <simon_at_josefsson.org>
Date: Tue, 27 Mar 2007 15:09:04 +0200

"Heiko Jansen" <jansen_at_hbz-nrw.de> writes:

>>>> Simon Josefsson <simon_at_josefsson.org> 22.03.07 14.45 Uhr >>>
>
>> Please test the daily snapshots from
>> <http://josefsson.org/daily/libssh2/> as if it were the 0.15 release,
>> and report any problems ASAP.
>
> Fetched http://josefsson.org/daily/libssh2/libssh2-20070325.tar.gz today
> and tried to compile it on openSuSE 10.2 (32Bit) and Solaris 10/SPARC 64Bit.
> This is what I found:

Wonderful, thank you!

> -- snip --
>
> ### Doc out of date:
>
> Either update or remove ~/INSTALL

I made several doc changes: I let the INSTALL file be the "standard"
INSTALL file about how to use configure, and moved the libssh2
specific installation instructions (really only about configure
parameters) to README. I also moved what was in README to NEWS, since
that consisted of NEWS entries. While I was at it, I added a rule to
create ChangeLog using cvs2cl.

> ### This seems to be a problem of the snapshot tarball (missing files):
>
> make[1]: Entering directory `/home/heiko/libssh/libssh2-0.15/docs'
> make[1]: *** Keine Regel vorhanden, um das Target »libssh2_channel_forward_accept.3«,
> benötigt von »all-am«, zu erstellen. Schluss.
> make[1]: Leaving directory `/home/heiko/libssh/libssh2-0.15/docs'
> make: *** [all-recursive] Fehler 1
>
> ~> ls -l /home/heiko/libssh/libssh2-0.15/docs
> -rw-r--r-- 1 heiko users 11396 25. Mär 13:13 Makefile
> -rw-r--r-- 1 heiko users 470 23. Feb 22:30 Makefile.am
> -rw-r--r-- 1 heiko users 11117 25. Mär 06:00 Makefile.in
> -rw-r--r-- 1 heiko users 415 2. Feb 17:09 template.3
>
> ==> The files for the man pages are not there.

I have fixed this.

> Also the buildconf script is missing from the tarball.

I'm not sure the script should be included. The recommended way to
bootstrap a project is to run 'autoreconf -vi'. But since it is in
CVS, it might as well be in the tarball too, so I added it.

> ### On Solaris 10, Sun CC, 64Bit
>
> cc -D_POSIX_PTHREAD_SEMANTICS -xarch=v9b -mt -D_REENTRANT -D_NDEBUG -I/digibib/tools/include -I/digibib/tools/include -xarch=v9b -o .libs/ssh2 ssh2.o -L/digibib/tools/lib ../../src/.libs/libssh2.so -lpthread -lcrypto -lz -lsocket -R/usr/local/lib
> Undefined first referenced
> symbol in file
> libssh2_poll_channel_write ../../src/.libs/libssh2.so
> libssh2_packet_x11_open ../../src/.libs/libssh2.so
> libssh2_packet_queue_listener ../../src/.libs/libssh2.so
> libssh2_poll_listener_queued ../../src/.libs/libssh2.so
> ld: fatal: Symbol referencing errors. No output written to .libs/ssh2
>
> ==> Can be fixed by adding
>
> LIBSSH2_API int libssh2_packet_x11_open(LIBSSH2_SESSION *session, unsigned char *data, unsigned long datalen);
> LIBSSH2_API int libssh2_poll_channel_write(LIBSSH2_CHANNEL *channel);
> LIBSSH2_API int libssh2_packet_queue_listener(LIBSSH2_SESSION *session, unsigned char *data, unsigned long datalen);
> LIBSSH2_API int libssh2_poll_listener_queued(LIBSSH2_LISTENER *listener);
>
> to
>
> ~/include/libssh2.h
>
> (cf. http://sourceforge.net/mailarchive/message.php?msg_id=37483753)

This seems to be the wrong fix, I don't think those functions should
be part of the external API. Or what do others think? I have tried
to fix this in another way in CVS, by adding 'static' keywords. Does
it work for you?

> ### Also on Solaris 10, Sun CC, 64Bit
>
> A bunch of warnings, where in different files (especially in kex.c,
> scp.c, userauth.c) assignment type mismatches are reported. Most of
> the time the code uses 'pointer to char "=" pointer to unsigned
> char'. (I can provide the detailed make output if needed).

More details would be useful, although I'm not sure worrying about all
kind of compiler warnings is useful. But if there is a real problem,
we should fix it.

> ### Also on Solaris 10, Sun CC, 64Bit
>
> cc -D_POSIX_PTHREAD_SEMANTICS -xarch=v9b -mt -D_REENTRANT -D_NDEBUG -I/digibib/tools/include -I/digibib/tools/include -xarch=v9b -o .libs/sftp sftp.o -L/digibib/tools/lib ../../src/.libs/libssh2.so -lpthread -lcrypto -lz -lsocket -R/usr/local/lib
> Undefined first referenced
> symbol in file
> inet_addr sftp.o (symbol belongs to implicit dependency /usr/lib/64/libnsl.so.1)
> ld: fatal: Symbol referencing errors. No output written to .libs/sftp
>
> ==> Can be fixed by adding -lnsl to the libraries linked in

I tried to fix this by adding:

# Solaris has inet_addr in -lnsl.
AC_SEARCH_LIB(inet_addr, nsl)

> Hope these issues can be fixed before releasing 0.15

Yes, I have tried to fix everything in CVS. Please test tomorrow's
snapshot again.

/Simon

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
libssh2-devel mailing list
libssh2-devel_at_lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libssh2-devel
Received on 2007-03-27